Files
odysseus/static/js/features/notes/application/drafts.js
T
Alexandre TeixeiraandLéo f1a47f3812 refactor(notes): decompose Notes into feature-owned modules (#6713)
* refactor(notes): decompose Notes into feature-owned modules

* fix(notes): avoid HTML interpolation in reminder picker

* docs(notes): drop checkpoint archives, session logs and publication drafts

The N0-N6 tarballs and raw pytest/node logs are not read by any script or
test, and the logs carry absolute home-directory paths. Once squashed into
dev they would stay in history for good. notes-pr.md and notes-issue.md
were the drafts used to open #6712 and #6713, not documentation.

notes-validation.md keeps the counts, the checkpoint hashes and
implementation.sha256 as the record; local interpreter paths and the local
Docker image name are replaced with portable placeholders.

* fix(notes): keep the state store raw and stop masonry re-observing after close

- state: writes built from views (filter, spread, splice) stored nested
  read-only views in the store, so structuredClone on a stored note threw
  DataCloneError. Store writes now unwrap nested views.
- layout: a save that resolves after closePanel re-renders the leaving pane
  and re-created the masonry ResizeObserver that teardown had disposed.
  Skip creating it once Notes is closed.
- index.js: drop 30 imported or declared names that were never used and
  group the imports at the top. Import order is unchanged.
- Revert unrelated punctuation edits in .gitattributes and keep the header
  comment and docstring first in compare/vote.js and
  test_notes_dom_xss_helpers.py.

Both fixes have a node test that fails on the previous head.

* test(notes): make script rejection assertion case-insensitive

Address CodeQL js/bad-tag-filter alert #1150 in test-only assertion and refresh Notes evidence manifest checksum.

---------

Co-authored-by: Léo <leograndcontact@gmail.com>
2026-10-15 09:29:41 +01:00

56 lines
2.0 KiB
JavaScript

/** Serialized autosave and synchronous local draft backup. DOM collection is a supplied port. */
export function createNotesDrafts({
app,
api,
persistence,
scheduler,
effects
}) {
const state = app.state;
const { _draftKey, _clearDraft } = persistence;
function bindDraft({ collect, id, view }) {
let t = null;
let pending = Promise.resolve();
let stopped = false;
let warned = false;
const save = () => {
const d = collect();
// An empty edit can be intentional: don't restore stale server text over it.
try { persistence.setItem(_draftKey(id), JSON.stringify(d)); }
catch {
if (!warned) effects.showError('Draft backup unavailable. Keep this note open until saved.');
warned = true;
}
return d;
};
const persist = (d) => {
if (!id || id === '__new__' || d.note_type === 'draw') return pending;
const { _ts, ...payload } = d;
payload.label = [...new Set(payload.label.split(/\s+/).map(s => s.replace(/^#+/, '')).filter(Boolean))].join(' ') || null;
pending = pending.then(async () => {
try {
await api.patchNote(id, payload);
view.failed = false;
const note = state.notes.find(n => n.id === id);
if (note) app.mergeNote(note, payload);
if (persistence.getItem(_draftKey(id)) === JSON.stringify(d)) _clearDraft(id);
} catch {
if (!view.failed) effects.showError('Note not synced. Your edits are kept on this device; retry Save.');
view.failed = true;
}
});
return pending;
};
const flush = () => { scheduler.clearTimeout(t); return save(); };
const stop = () => { stopped = true; scheduler.clearTimeout(t); return pending; };
const sched = () => {
const d = save();
if (stopped) return;
scheduler.clearTimeout(t);
t = scheduler.setTimeout(() => persist(d), 500);
};
return { flush, stop, schedule: sched };
}
return { bindDraft };
}