Files
odysseus/tests/notesInfrastructure.test.mjs
T
Alexandre TeixeiraandLéo f1a47f3812 refactor(notes): decompose Notes into feature-owned modules (#6713)
* refactor(notes): decompose Notes into feature-owned modules

* fix(notes): avoid HTML interpolation in reminder picker

* docs(notes): drop checkpoint archives, session logs and publication drafts

The N0-N6 tarballs and raw pytest/node logs are not read by any script or
test, and the logs carry absolute home-directory paths. Once squashed into
dev they would stay in history for good. notes-pr.md and notes-issue.md
were the drafts used to open #6712 and #6713, not documentation.

notes-validation.md keeps the counts, the checkpoint hashes and
implementation.sha256 as the record; local interpreter paths and the local
Docker image name are replaced with portable placeholders.

* fix(notes): keep the state store raw and stop masonry re-observing after close

- state: writes built from views (filter, spread, splice) stored nested
  read-only views in the store, so structuredClone on a stored note threw
  DataCloneError. Store writes now unwrap nested views.
- layout: a save that resolves after closePanel re-renders the leaving pane
  and re-created the masonry ResizeObserver that teardown had disposed.
  Skip creating it once Notes is closed.
- index.js: drop 30 imported or declared names that were never used and
  group the imports at the top. Import order is unchanged.
- Revert unrelated punctuation edits in .gitattributes and keep the header
  comment and docstring first in compare/vote.js and
  test_notes_dom_xss_helpers.py.

Both fixes have a node test that fails on the previous head.

* test(notes): make script rejection assertion case-insensitive

Address CodeQL js/bad-tag-filter alert #1150 in test-only assertion and refresh Notes evidence manifest checksum.

---------

Co-authored-by: Léo <leograndcontact@gmail.com>
2026-10-15 09:29:41 +01:00

48 lines
2.9 KiB
JavaScript

import test from 'node:test';
import assert from 'node:assert/strict';
import { createNotesApi } from '../frontend/src/features/notes/infrastructure/http.js';
import { createNotesPersistence, REMINDER_FIRED_KEY } from '../frontend/src/features/notes/infrastructure/storage.js';
test('list, reorder, upload, reminder and agent transports retain exact requests', async () => {
const calls = [], result = { ok: false, status: 403 };
const api = createNotesApi({ origin: 'https://notes.invalid', request: async (...args) => { calls.push(args); return result; } });
const body = { opaque: true };
assert.equal(await api.listNotes(true), result);
await api.listNotes(false); await api.reorder(['b', 'a']); await api.upload(body);
await api.fireReminder({ note_id: 'a' }); await api.defaultChat();
await api.createSession(body); await api.startChat(body);
assert.deepEqual(calls.map(([url, o]) => [url, o.method || 'GET', o.credentials]), [
['https://notes.invalid/api/notes?archived=true', 'GET', 'same-origin'],
['https://notes.invalid/api/notes', 'GET', 'same-origin'],
['https://notes.invalid/api/notes/reorder', 'POST', 'same-origin'],
['https://notes.invalid/api/upload', 'POST', 'same-origin'],
['/api/notes/fire-reminder', 'POST', 'same-origin'],
['https://notes.invalid/api/default-chat', 'GET', 'same-origin'],
['https://notes.invalid/api/session', 'POST', 'same-origin'],
['https://notes.invalid/api/chat_stream', 'POST', 'same-origin'],
]);
assert.equal(calls[2][1].body, '{"ids":["b","a"]}');
assert.equal(calls[3][1].body, body);
assert.equal(api.uploadUrl('file'), 'https://notes.invalid/api/upload/file');
});
test('draft and marker persistence retain keys, formats and malformed fallback', () => {
const values = new Map();
const storage = { getItem: key => values.get(key) ?? null, setItem: (key, value) => values.set(key, value), removeItem: key => values.delete(key) };
const persistence = createNotesPersistence({ storage });
assert.equal(persistence._draftKey(null), 'odysseus-note-draft-__new__');
persistence._saveFiredReminders(new Set(['a', 'b']));
assert.equal(values.get(REMINDER_FIRED_KEY), '["a","b"]');
assert.deepEqual([...persistence._loadFiredReminders()], ['a', 'b']);
values.set(REMINDER_FIRED_KEY, '{broken');
assert.equal(persistence._loadFiredReminders().size, 0);
storage.setItem(persistence._draftKey('a'), '{"content":"","_ts":1}');
assert.deepEqual(persistence._loadDraft('a'), { content: '', _ts: 1 });
persistence._clearDraft('a');
assert.equal(persistence._loadDraft('a'), null);
const failing = createNotesPersistence({ storage: { getItem() { throw Error('blocked'); }, setItem() { throw Error('full'); } } });
assert.equal(failing._loadDraft('a'), null);
assert.doesNotThrow(() => failing._saveFiredReminders(new Set(['a'])));
assert.throws(() => failing.setItem('odysseus-note-draft-a', '{}'), /full/, 'draft caller must observe backup failure');
});