Files
odysseus/static/js/features/notes/application/selection.js
T
Alexandre TeixeiraandLéo f1a47f3812 refactor(notes): decompose Notes into feature-owned modules (#6713)
* refactor(notes): decompose Notes into feature-owned modules

* fix(notes): avoid HTML interpolation in reminder picker

* docs(notes): drop checkpoint archives, session logs and publication drafts

The N0-N6 tarballs and raw pytest/node logs are not read by any script or
test, and the logs carry absolute home-directory paths. Once squashed into
dev they would stay in history for good. notes-pr.md and notes-issue.md
were the drafts used to open #6712 and #6713, not documentation.

notes-validation.md keeps the counts, the checkpoint hashes and
implementation.sha256 as the record; local interpreter paths and the local
Docker image name are replaced with portable placeholders.

* fix(notes): keep the state store raw and stop masonry re-observing after close

- state: writes built from views (filter, spread, splice) stored nested
  read-only views in the store, so structuredClone on a stored note threw
  DataCloneError. Store writes now unwrap nested views.
- layout: a save that resolves after closePanel re-renders the leaving pane
  and re-created the masonry ResizeObserver that teardown had disposed.
  Skip creating it once Notes is closed.
- index.js: drop 30 imported or declared names that were never used and
  group the imports at the top. Import order is unchanged.
- Revert unrelated punctuation edits in .gitattributes and keep the header
  comment and docstring first in compare/vote.js and
  test_notes_dom_xss_helpers.py.

Both fixes have a node test that fails on the previous head.

* test(notes): make script rejection assertion case-insensitive

Address CodeQL js/bad-tag-filter alert #1150 in test-only assertion and refresh Notes evidence manifest checksum.

---------

Co-authored-by: Léo <leograndcontact@gmail.com>
2026-10-15 09:29:41 +01:00

40 lines
1.5 KiB
JavaScript

/** Selected-note attachment retains synchronous acceptance; bulk requests retain partial-failure behavior. */
export function createSelectionOperations({
app,
api,
effects,
sendContext,
exitSelection,
fetchNotes
}) {
const state = app.state;
function attachSelected() {
const ids = [...state.selectedIds];
if (!ids.length) return;
const detail = { noteIds: ids, accepted: false };
sendContext(detail);
if (!detail.accepted) {
effects.showToast('Choose a chat or model before attaching notes');
return;
}
exitSelection();
}
async function archiveSelected() {
const ids = [...state.selectedIds];
if (!ids.length) return;
await Promise.all(ids.map(id => api.patchNote(id, { archived: true }).catch(() => {})));
exitSelection(); await fetchNotes(); effects.render(); effects.showToast(`Archived ${ids.length}`);
}
async function deleteSelected() {
const ids = [...state.selectedIds];
if (!ids.length) return;
if (effects.styledConfirm) {
const ok = await effects.styledConfirm(`Delete ${ids.length} note${ids.length === 1 ? '' : 's'}?`, { confirmText: 'Delete', danger: true });
if (!ok) return;
}
await Promise.all(ids.map(id => api.deleteNote(id).catch(() => {})));
exitSelection(); await fetchNotes(); effects.render(); effects.showToast(`Deleted ${ids.length}`);
}
return { attachSelected, archiveSelected, deleteSelected };
}