Files
odysseus/static/js/features/notes/ui/selection.js
T
Alexandre TeixeiraandLéo f1a47f3812 refactor(notes): decompose Notes into feature-owned modules (#6713)
* refactor(notes): decompose Notes into feature-owned modules

* fix(notes): avoid HTML interpolation in reminder picker

* docs(notes): drop checkpoint archives, session logs and publication drafts

The N0-N6 tarballs and raw pytest/node logs are not read by any script or
test, and the logs carry absolute home-directory paths. Once squashed into
dev they would stay in history for good. notes-pr.md and notes-issue.md
were the drafts used to open #6712 and #6713, not documentation.

notes-validation.md keeps the counts, the checkpoint hashes and
implementation.sha256 as the record; local interpreter paths and the local
Docker image name are replaced with portable placeholders.

* fix(notes): keep the state store raw and stop masonry re-observing after close

- state: writes built from views (filter, spread, splice) stored nested
  read-only views in the store, so structuredClone on a stored note threw
  DataCloneError. Store writes now unwrap nested views.
- layout: a save that resolves after closePanel re-renders the leaving pane
  and re-created the masonry ResizeObserver that teardown had disposed.
  Skip creating it once Notes is closed.
- index.js: drop 30 imported or declared names that were never used and
  group the imports at the top. Import order is unchanged.
- Revert unrelated punctuation edits in .gitattributes and keep the header
  comment and docstring first in compare/vote.js and
  test_notes_dom_xss_helpers.py.

Both fixes have a node test that fails on the previous head.

* test(notes): make script rejection assertion case-insensitive

Address CodeQL js/bad-tag-filter alert #1150 in test-only assertion and refresh Notes evidence manifest checksum.

---------

Co-authored-by: Léo <leograndcontact@gmail.com>
2026-10-15 09:29:41 +01:00

62 lines
2.7 KiB
JavaScript

/** Selection controls and view feedback for accepted attachments. */
export function createSelection({
operations,
_renderNotes,
app,
state
}) {
function _enterSelectMode(initialId = null) {
app.setSelectMode(true);
app.clearSelection();
if (initialId) app.selectId(initialId);
const bar = document.getElementById('notes-bulk-bar');
const btn = document.getElementById('notes-select-btn');
if (bar) bar.classList.remove('hidden');
if (btn) { btn.classList.add('active'); btn.textContent = 'Cancel'; }
_renderNotes();
_updateBulkBar();
}
function _exitSelectMode() {
app.setSelectMode(false);
app.clearSelection();
const bar = document.getElementById('notes-bulk-bar');
const btn = document.getElementById('notes-select-btn');
const all = document.getElementById('notes-select-all');
if (bar) bar.classList.add('hidden');
if (btn) { btn.classList.remove('active'); btn.textContent = 'Select'; }
if (all) all.checked = false;
_renderNotes();
}
function _updateBulkBar() {
const count = state.selectedIds.size;
const countEl = document.getElementById('notes-selected-count');
const sendAgentBtn = document.getElementById('notes-send-agent');
const archiveBtn = document.getElementById('notes-bulk-archive');
const deleteBtn = document.getElementById('notes-bulk-delete');
const allEl = document.getElementById('notes-select-all');
if (countEl) countEl.textContent = `${count} Selected`;
if (sendAgentBtn) sendAgentBtn.disabled = count === 0;
if (archiveBtn) archiveBtn.disabled = count === 0;
if (deleteBtn) deleteBtn.disabled = count === 0;
if (allEl) allEl.checked = state.notes.length > 0 && state.notes.every(n => state.selectedIds.has(n.id));
// Toggle select-mode class so todo dots don't react to hover
const pane = document.getElementById('notes-pane');
if (pane) pane.classList.toggle('notes-select-mode', count > 0);
}
function wireSelectionActions() {
document.getElementById('notes-select-all').addEventListener('change', e => {
if (e.target.checked) state.notes.forEach(n => app.selectId(n.id));
else app.clearSelection();
_renderNotes(); _updateBulkBar();
});
document.getElementById('notes-send-agent').addEventListener('click', operations.attachSelected);
document.getElementById('notes-bulk-archive').addEventListener('click', operations.archiveSelected);
document.getElementById('notes-bulk-delete').addEventListener('click', operations.deleteSelected);
document.getElementById('notes-bulk-cancel').addEventListener('click', _exitSelectMode);
}
return { wireSelectionActions, _enterSelectMode, _exitSelectMode, _updateBulkBar };
}