mirror of
https://github.com/pewdiepie-archdaemon/odysseus.git
synced 2026-10-15 19:32:21 +02:00
Alexandre TeixeiraandLéo
f1a47f3812
* refactor(notes): decompose Notes into feature-owned modules * fix(notes): avoid HTML interpolation in reminder picker * docs(notes): drop checkpoint archives, session logs and publication drafts The N0-N6 tarballs and raw pytest/node logs are not read by any script or test, and the logs carry absolute home-directory paths. Once squashed into dev they would stay in history for good. notes-pr.md and notes-issue.md were the drafts used to open #6712 and #6713, not documentation. notes-validation.md keeps the counts, the checkpoint hashes and implementation.sha256 as the record; local interpreter paths and the local Docker image name are replaced with portable placeholders. * fix(notes): keep the state store raw and stop masonry re-observing after close - state: writes built from views (filter, spread, splice) stored nested read-only views in the store, so structuredClone on a stored note threw DataCloneError. Store writes now unwrap nested views. - layout: a save that resolves after closePanel re-renders the leaving pane and re-created the masonry ResizeObserver that teardown had disposed. Skip creating it once Notes is closed. - index.js: drop 30 imported or declared names that were never used and group the imports at the top. Import order is unchanged. - Revert unrelated punctuation edits in .gitattributes and keep the header comment and docstring first in compare/vote.js and test_notes_dom_xss_helpers.py. Both fixes have a node test that fails on the previous head. * test(notes): make script rejection assertion case-insensitive Address CodeQL js/bad-tag-filter alert #1150 in test-only assertion and refresh Notes evidence manifest checksum. --------- Co-authored-by: Léo <leograndcontact@gmail.com>
80 lines
3.3 KiB
JavaScript
80 lines
3.3 KiB
JavaScript
/** Optimistic card mutations and rollback. Animation completion is a UI-supplied boundary. */
|
|
export function createCardOperations({
|
|
app,
|
|
api,
|
|
effects,
|
|
pushUndo,
|
|
undoArchive
|
|
}) {
|
|
const state = app.state;
|
|
function togglePin(id) {
|
|
const note = state.notes.find(n => n.id === id);
|
|
if (!note) return;
|
|
const prevPinned = note.pinned, prevSortOrder = note.sort_order;
|
|
app.mergeNote(note, { pinned: !prevPinned });
|
|
const patch = { pinned: note.pinned };
|
|
if (note.pinned) {
|
|
const minPinned = state.notes.filter(n => n.pinned && n.id !== id).reduce((m, n) => Math.min(m, n.sort_order || 0), 0);
|
|
app.mergeNote(note, { sort_order: minPinned - 1 });
|
|
patch.sort_order = note.sort_order;
|
|
}
|
|
effects.render();
|
|
api.patchNote(id, patch).catch(() => {
|
|
app.mergeNote(note, { pinned: prevPinned, sort_order: prevSortOrder });
|
|
effects.render(); effects.showError('Failed to pin');
|
|
});
|
|
}
|
|
async function updateColor(id, color) {
|
|
try {
|
|
await api.patchNote(id, { color: color || null });
|
|
const note = state.notes.find(n => n.id === id);
|
|
if (note) app.mergeNote(note, { color });
|
|
} catch { effects.showError('Failed to update color'); }
|
|
}
|
|
function stageArchive(id) {
|
|
const index = state.notes.findIndex(n => n.id === id);
|
|
if (index < 0) return null;
|
|
const removed = app.removeNoteAt(index);
|
|
const undo = () => undoArchive(removed, index);
|
|
pushUndo({ label: 'archive', run: undo });
|
|
return () => {
|
|
effects.render();
|
|
api.patchNote(id, { archived: true }).then(() => effects.archived(undo)).catch(() => {
|
|
app.insertNoteAt(index, removed); effects.render(); effects.showError('Failed to archive');
|
|
});
|
|
};
|
|
}
|
|
function unarchive(id) {
|
|
const index = state.notes.findIndex(n => n.id === id);
|
|
if (index < 0) return;
|
|
const removed = app.removeNoteAt(index);
|
|
effects.render();
|
|
api.patchNote(id, { archived: false }).then(() => effects.showToast('Unarchived')).catch(() => {
|
|
app.insertNoteAt(index, removed); effects.render(); effects.showError('Failed to unarchive');
|
|
});
|
|
}
|
|
function deleteOptimistically(id, toast = false) {
|
|
const index = state.notes.findIndex(n => n.id === id);
|
|
if (index < 0) return;
|
|
const removed = app.removeNoteAt(index);
|
|
effects.render();
|
|
const deletion = api.deleteNote(id);
|
|
const completion = toast ? deletion.then(() => effects.showToast('Deleted')) : deletion;
|
|
completion.catch(() => {
|
|
app.insertNoteAt(index, removed); effects.render(); effects.showError('Failed to delete');
|
|
});
|
|
}
|
|
// Desktop deliberately persists without updating local sort_order, as before.
|
|
function persistOrder(ids) { return api.reorder(ids); }
|
|
async function commitMobileOrder(ids) {
|
|
try {
|
|
await api.reorder(ids);
|
|
ids.forEach((id, index) => {
|
|
const note = state.notes.find(note => note.id === id);
|
|
if (note) app.mergeNote(note, { sort_order: index });
|
|
});
|
|
} catch (error) { console.warn('reorder failed', error); }
|
|
}
|
|
return { togglePin, updateColor, stageArchive, unarchive, deleteOptimistically, persistOrder, commitMobileOrder };
|
|
}
|