Files
odysseus/frontend/src/features/notes/ui/windowLayout.js
T
Alexandre TeixeiraandLéo f1a47f3812 refactor(notes): decompose Notes into feature-owned modules (#6713)
* refactor(notes): decompose Notes into feature-owned modules

* fix(notes): avoid HTML interpolation in reminder picker

* docs(notes): drop checkpoint archives, session logs and publication drafts

The N0-N6 tarballs and raw pytest/node logs are not read by any script or
test, and the logs carry absolute home-directory paths. Once squashed into
dev they would stay in history for good. notes-pr.md and notes-issue.md
were the drafts used to open #6712 and #6713, not documentation.

notes-validation.md keeps the counts, the checkpoint hashes and
implementation.sha256 as the record; local interpreter paths and the local
Docker image name are replaced with portable placeholders.

* fix(notes): keep the state store raw and stop masonry re-observing after close

- state: writes built from views (filter, spread, splice) stored nested
  read-only views in the store, so structuredClone on a stored note threw
  DataCloneError. Store writes now unwrap nested views.
- layout: a save that resolves after closePanel re-renders the leaving pane
  and re-created the masonry ResizeObserver that teardown had disposed.
  Skip creating it once Notes is closed.
- index.js: drop 30 imported or declared names that were never used and
  group the imports at the top. Import order is unchanged.
- Revert unrelated punctuation edits in .gitattributes and keep the header
  comment and docstring first in compare/vote.js and
  test_notes_dom_xss_helpers.py.

Both fixes have a node test that fails on the previous head.

* test(notes): make script rejection assertion case-insensitive

Address CodeQL js/bad-tag-filter alert #1150 in test-only assertion and refresh Notes evidence manifest checksum.

---------

Co-authored-by: Léo <leograndcontact@gmail.com>
2026-10-15 09:29:41 +01:00

115 lines
4.1 KiB
JavaScript

/** Shared-window integration: safe fullscreen bounds, docking and stacking. */
export function createWindowLayout({
makeWindowDraggable,
snapModalToZone,
clearDockSide,
applyEdgeDock,
topToolWindowZ
}) {
function _notesFullscreenSafeRect() {
const vw = window.innerWidth || document.documentElement.clientWidth || 0;
const vh = window.innerHeight || document.documentElement.clientHeight || 0;
let left = 0;
let right = vw;
const sidebar = document.getElementById('sidebar');
const rail = document.getElementById('icon-rail');
const hamburgerRight = document.body.classList.contains('hamburger-right')
|| sidebar?.classList.contains('right-side')
|| rail?.classList.contains('right-side');
const reserve = (el) => {
if (!el || getComputedStyle(el).display === 'none') return;
const rect = el.getBoundingClientRect();
if (rect.width <= 0 || rect.height <= 0) return;
if (hamburgerRight) right = Math.min(right, rect.left);
else left = Math.max(left, rect.right);
};
if (sidebar && !sidebar.classList.contains('hidden')) reserve(sidebar);
reserve(rail);
// The fixed hamburger can remain visible even when the rail/sidebar is
// collapsed. Reserve its strip too so fullscreen Notes does not sit beneath it.
const hamburger = document.getElementById('hamburger-btn');
if (hamburger && getComputedStyle(hamburger).display !== 'none') {
const rect = hamburger.getBoundingClientRect();
const pad = 8;
if (hamburgerRight) right = Math.min(right, rect.left - pad);
else left = Math.max(left, rect.right + pad);
}
left = Math.max(0, Math.min(left, vw - 80));
right = Math.max(left + 80, Math.min(right, vw));
return { left, top: 0, width: right - left, height: vh };
}
function _wireNotesWindow(pane) {
if (!pane || pane.dataset.windowDragWired === '1') return;
const header = pane.querySelector('.notes-pane-header');
if (!header) return;
pane.dataset.windowDragWired = '1';
makeWindowDraggable(pane, {
content: pane,
header,
fsClass: 'notes-window-fullscreen',
skipSelector: 'button, input, select, textarea, label, .notes-mobile-grabber',
enableDock: true,
enableLeftDock: true,
onEnterFullscreen: () => {
pane.classList.add('notes-window-fullscreen');
snapModalToZone(pane, {
name: 'fullscreen',
rect: _notesFullscreenSafeRect(),
});
},
onExitFullscreen: () => {
_restoreNotesSidebarDock(pane);
},
});
}
function _clearNotesSnapStyles(pane) {
if (!pane) return;
const hadLeft = pane.classList.contains('modal-left-docked');
const hadRight = pane.classList.contains('modal-right-docked');
pane.classList.remove('notes-window-fullscreen', 'modal-left-docked', 'modal-right-docked');
if (hadLeft) clearDockSide('left', pane);
if (hadRight) clearDockSide('right', pane);
['position', 'left', 'top', 'right', 'bottom', 'width', 'max-width', 'height',
'max-height', 'margin', 'transform', 'border-radius']
.forEach((prop) => pane.style.removeProperty(prop));
delete pane.dataset._tilePreSnap;
delete pane.dataset._tileZone;
delete pane._preDockSnapshot;
delete pane._dockSide;
delete pane._dockSuspended;
}
function _restoreNotesSidebarDock(pane) {
if (!pane || window.innerWidth <= 768) return;
_clearNotesSnapStyles(pane);
if (!pane.isConnected) return;
applyEdgeDock(pane, 'right');
}
function _topToolWindowZ(exclude = null) {
return topToolWindowZ({ exclude });
}
function _bringNotesToFront(pane = document.getElementById('notes-pane')) {
if (!pane) return;
const backdrop = document.getElementById('notes-pane-backdrop') || pane.parentElement;
const z = _topToolWindowZ(backdrop) + 1;
if (backdrop) backdrop.style.setProperty('z-index', String(z), 'important');
try {
window.dispatchEvent(new CustomEvent('odysseus:modal-opened', {
detail: { id: 'notes-panel', modal: pane },
}));
} catch (_) {}
}
return { _wireNotesWindow, _restoreNotesSidebarDock, _bringNotesToFront };
}