Files
odysseus/frontend/src/features/notes/ui/draftEditor.js
T
Alexandre TeixeiraandLéo f1a47f3812 refactor(notes): decompose Notes into feature-owned modules (#6713)
* refactor(notes): decompose Notes into feature-owned modules

* fix(notes): avoid HTML interpolation in reminder picker

* docs(notes): drop checkpoint archives, session logs and publication drafts

The N0-N6 tarballs and raw pytest/node logs are not read by any script or
test, and the logs carry absolute home-directory paths. Once squashed into
dev they would stay in history for good. notes-pr.md and notes-issue.md
were the drafts used to open #6712 and #6713, not documentation.

notes-validation.md keeps the counts, the checkpoint hashes and
implementation.sha256 as the record; local interpreter paths and the local
Docker image name are replaced with portable placeholders.

* fix(notes): keep the state store raw and stop masonry re-observing after close

- state: writes built from views (filter, spread, splice) stored nested
  read-only views in the store, so structuredClone on a stored note threw
  DataCloneError. Store writes now unwrap nested views.
- layout: a save that resolves after closePanel re-renders the leaving pane
  and re-created the masonry ResizeObserver that teardown had disposed.
  Skip creating it once Notes is closed.
- index.js: drop 30 imported or declared names that were never used and
  group the imports at the top. Import order is unchanged.
- Revert unrelated punctuation edits in .gitattributes and keep the header
  comment and docstring first in compare/vote.js and
  test_notes_dom_xss_helpers.py.

Both fixes have a node test that fails on the previous head.

* test(notes): make script rejection assertion case-insensitive

Address CodeQL js/bad-tag-filter alert #1150 in test-only assertion and refresh Notes evidence manifest checksum.

---------

Co-authored-by: Léo <leograndcontact@gmail.com>
2026-10-15 09:29:41 +01:00

68 lines
2.6 KiB
JavaScript

/** Collect editor drafts, restore them and wire the autosave workflow. */
export function createDraftEditor({
bindDraft,
_collectItems,
_loadDraft
}) {
function _collectFormDraft(form) {
if (!form) return null;
const type = form.querySelector('.note-form-type-pill.active')?.dataset.type || form.dataset.noteType || 'note';
const d = {
_ts: Date.now(),
note_type: type,
color: form.dataset.noteColor || '',
title: form.querySelector('.note-form-title')?.value || '',
label: form.querySelector('.note-form-label')?.value || '',
due_date: form.querySelector('.note-form-due')?.value || null,
repeat: form.querySelector('.note-form-repeat')?.value || 'none',
};
if (type === 'note') d.content = form.querySelector('.note-form-content')?.value || '';
else if (type === 'goal') { d.content = form.querySelector('.note-form-goal-desc')?.value || ''; d.items = _collectItems(form); }
else d.items = _collectItems(form);
return d;
}
function _isDraftEmpty(d) {
if (!d) return true;
if ((d.title || '').trim()) return false;
if ((d.content || '').trim()) return false;
if (Array.isArray(d.items) && d.items.some(it => (it.text || '').trim())) return false;
return true;
}
function _wireDraftAutosave(form, id) {
const view = {
get failed() { return form._autosaveFailed; },
set failed(value) { form._autosaveFailed = value; },
};
const draft = bindDraft({ collect: () => _collectFormDraft(form), id, view });
form._flushDraft = draft.flush;
form._stopDraftAutosave = draft.stop;
form.addEventListener('input', draft.schedule);
form.addEventListener('change', draft.schedule);
form.addEventListener('click', event => {
if (event.target.closest('.note-cl-dot, .note-cl-rm')) draft.schedule();
});
}
function _commitOpenInPlaceEditor() {
const form = document.querySelector('#notes-pane .note-form');
if (!form) return;
const d = _collectFormDraft(form);
if (_isDraftEmpty(d)) { form.querySelector('.note-form-cancel')?.click(); return; }
form.querySelector('.note-form-save')?.click();
}
function _applyDraftToNote(note, id) {
const d = _loadDraft(id);
if (!d) return { note, restored: false };
const merged = { ...(note || {}) };
['note_type', 'color', 'title', 'label', 'due_date', 'repeat', 'content', 'items'].forEach(k => {
if (d[k] !== undefined) merged[k] = d[k];
});
return { note: merged, restored: true };
}
return { _collectFormDraft, _isDraftEmpty, _wireDraftAutosave, _commitOpenInPlaceEditor, _applyDraftToNote };
}