mirror of
https://github.com/pewdiepie-archdaemon/odysseus.git
synced 2026-10-15 19:32:21 +02:00
Alexandre TeixeiraandLéo
f1a47f3812
* refactor(notes): decompose Notes into feature-owned modules * fix(notes): avoid HTML interpolation in reminder picker * docs(notes): drop checkpoint archives, session logs and publication drafts The N0-N6 tarballs and raw pytest/node logs are not read by any script or test, and the logs carry absolute home-directory paths. Once squashed into dev they would stay in history for good. notes-pr.md and notes-issue.md were the drafts used to open #6712 and #6713, not documentation. notes-validation.md keeps the counts, the checkpoint hashes and implementation.sha256 as the record; local interpreter paths and the local Docker image name are replaced with portable placeholders. * fix(notes): keep the state store raw and stop masonry re-observing after close - state: writes built from views (filter, spread, splice) stored nested read-only views in the store, so structuredClone on a stored note threw DataCloneError. Store writes now unwrap nested views. - layout: a save that resolves after closePanel re-renders the leaving pane and re-created the masonry ResizeObserver that teardown had disposed. Skip creating it once Notes is closed. - index.js: drop 30 imported or declared names that were never used and group the imports at the top. Import order is unchanged. - Revert unrelated punctuation edits in .gitattributes and keep the header comment and docstring first in compare/vote.js and test_notes_dom_xss_helpers.py. Both fixes have a node test that fails on the previous head. * test(notes): make script rejection assertion case-insensitive Address CodeQL js/bad-tag-filter alert #1150 in test-only assertion and refresh Notes evidence manifest checksum. --------- Co-authored-by: Léo <leograndcontact@gmail.com>
88 lines
3.3 KiB
Python
88 lines
3.3 KiB
Python
from tests.helpers.notes_source import notes_source
|
|
from pathlib import Path
|
|
from tests.helpers.stylesheets import app_css
|
|
|
|
|
|
ROOT = Path(__file__).resolve().parents[1]
|
|
|
|
|
|
def test_notes_sidebar_new_action_matches_library_structure_and_animation():
|
|
html = (ROOT / "static/index.html").read_text(encoding="utf-8")
|
|
css = app_css()
|
|
|
|
assert 'class="list-item-plus-btn sidebar-new-item-btn" id="notes-new-note-btn"' in html
|
|
assert '<span class="list-item-plus-label">new</span>' in html[html.index('id="notes-new-note-btn"'):]
|
|
assert "#tool-notes-btn:hover #notes-new-note-btn" in css
|
|
assert "#notes-new-note-btn:hover svg" in css
|
|
|
|
|
|
def test_notes_sidebar_new_action_opens_a_note_without_toggling_panel_closed():
|
|
app = (ROOT / "static/app.js").read_text(encoding="utf-8")
|
|
notes = notes_source("ui/quickAdd", "ui/cardInteractions", "ui/reminderDisplay", "index")
|
|
|
|
assert "event.stopPropagation()" in app[app.index("const notesNewNoteBtn"):]
|
|
assert "notesModule?.newNote?.()" in app
|
|
assert "function newNote()" in notes
|
|
assert "requestAnimationFrame(() => _createNote('note'))" in notes
|
|
assert "newNote: quickAdd.newNote" in notes
|
|
assert "publicNewNote as newNote" in notes
|
|
|
|
|
|
def test_sidebar_new_note_focuses_note_body_instead_of_title():
|
|
notes = notes_source("ui/quickAdd", "ui/cardInteractions", "ui/reminderDisplay", "index")
|
|
|
|
assert "form.querySelector('.note-form-content')" in notes
|
|
assert "initialField?.focus()" in notes
|
|
|
|
|
|
def test_notes_reminder_dot_stays_before_new_note_action():
|
|
notes = notes_source("ui/quickAdd", "ui/cardInteractions", "ui/reminderDisplay", "index")
|
|
|
|
assert "sidebarBtn.querySelector('#notes-new-note-btn')" in notes
|
|
assert "sidebarBtn.insertBefore(dot, newNoteBtn || null)" in notes
|
|
|
|
|
|
def test_checklist_preview_starts_at_first_unfinished_item():
|
|
notes = notes_source("ui/quickAdd", "ui/cardInteractions", "ui/reminderDisplay", "index")
|
|
start = notes.index("function _bindCardEvents(body)")
|
|
end = notes.index("const tapToEditOrSelect", start)
|
|
setup = notes[start:end]
|
|
|
|
assert ".note-checkbox:not(.done)" in setup
|
|
assert "preview.scrollTop" in setup
|
|
|
|
|
|
def test_checklist_preview_releases_scroll_at_its_boundaries():
|
|
notes = notes_source("ui/quickAdd", "ui/cardInteractions", "ui/reminderDisplay", "index")
|
|
css = app_css()
|
|
|
|
assert "el.addEventListener('wheel'" in notes
|
|
assert "el.closest('.notes-pane-body')" in notes
|
|
assert "pane.scrollTop += e.deltaY" in notes
|
|
assert "overscroll-behavior-y: auto" in css
|
|
|
|
|
|
def test_notes_tags_toggle_is_nudged_down():
|
|
css = app_css()
|
|
rule = css[css.index(".notes-search-bar .notes-label-toggle {"):]
|
|
rule = rule[:rule.index("}")]
|
|
|
|
assert "top: 4px" in rule
|
|
|
|
|
|
def test_notes_body_and_tag_arrow_are_nudged_down():
|
|
css = app_css()
|
|
|
|
assert css.count("padding: 10px 8px 8px") >= 2
|
|
assert ".notes-pane-body .doclib-chip-scroll-arrow.right" in css
|
|
assert "top: calc(50% - 6px) !important" in css[css.index(".notes-pane-body .doclib-chip-scroll-arrow.right"):]
|
|
|
|
|
|
def test_notes_tag_strip_cannot_grow_into_blank_space():
|
|
css = app_css()
|
|
rule = css[css.index(".notes-pane-body > .doclib-chip-scroll-frame:has(> .notes-labels-bar) {"):]
|
|
rule = rule[:rule.index("}")]
|
|
|
|
assert "flex: 0 0 auto" in rule
|
|
assert "width: 100%" in rule
|