mirror of
https://github.com/pewdiepie-archdaemon/odysseus.git
synced 2026-10-06 06:52:20 +02:00
Léo
ab5a08a6f9
The email library was 11,375 lines in one file, the second-largest JS module in the repo. `static/js/emailLibrary/` already held four extracted helpers, so the package existed; the bulk of the code just was not in it. The implementation moves to `emailLibrary/index.js` and the old path becomes a re-export wrapper. Five call sites import that path, four of them dynamically with a `?v=` string, and `sw.js` caches URLs verbatim, so a wrapper is what makes the move need no coordinated edit to any of them. The test side is the part worth reviewing. 58 tests read `static/js/emailLibrary.js` as text. Pointing them at `emailLibrary/index.js` would buy one move and break again on the next one, which is exactly what happened to the stylesheet tests (they now go through `tests/helpers/stylesheets.py`). So the same shape: `tests/helpers/js_modules.py` reads the whole package, and assertions stop caring which module a function sits in. `tests/test_email_library_module_graph_js.py` is new. This frontend has no module-graph validation, and a package fails in ways a single file cannot: a wrapper that drops an export is `undefined` at call time rather than an error at load time, and a module that reads a `const` across an import cycle throws only when that module is entered first. It pins the wrapper's surface against the entry module's, evaluates every module on its own in a browser, and requires both import paths to hand out one instance. It also caught a live gap while being written: `emailLibrary/replyRecipients.js` is imported by `emailInbox.js`, an app shell module, and was never in the `sw.js` precache.
27 lines
1.2 KiB
Python
27 lines
1.2 KiB
Python
from pathlib import Path
|
|
from tests.helpers.js_modules import email_library_source
|
|
|
|
|
|
ROOT = Path(__file__).resolve().parents[1]
|
|
|
|
|
|
def test_card_delete_waits_for_durable_success_and_uses_email_identity():
|
|
source = email_library_source()
|
|
assert "function _emailMutationQuery(em" in source
|
|
assert "em?.folder || fallbackFolder" in source
|
|
assert "em?.account_id || state._libAccountId" in source
|
|
assert "data?.success !== true" in source
|
|
assert source.count("await _requireSuccessfulEmailMutation(response, 'Failed to delete email');") >= 3
|
|
|
|
|
|
def test_finished_send_does_not_close_whichever_library_opened_later():
|
|
source = (ROOT / "static/js/document.js").read_text()
|
|
start = source.index("async function _sendEmail()")
|
|
end = source.index("async function _saveDraft()", start)
|
|
send = source[start:end]
|
|
# Closing the initiating composer when SMTP starts is valid. Completion
|
|
# must not close a different document/email opened while SMTP was pending.
|
|
assert send.count("if (isLibraryOpen()) closeLibrary();") == 1
|
|
success_cleanup = send.index("// Delete the compose document after successful send.")
|
|
assert "closeLibrary()" not in send[success_cleanup:]
|