mirror of
https://github.com/pewdiepie-archdaemon/odysseus.git
synced 2026-10-31 18:22:22 +01:00
112 lines
4.1 KiB
Python
112 lines
4.1 KiB
Python
"""Check-in calendar digest must be scoped to the task owner.
|
|
|
|
The digest query selected CalendarEvent with no owner scope, so a scheduled
|
|
check-in for one user pulled EVERY user's calendar events (summaries,
|
|
locations) into their digest — a cross-tenant leak. Ownership lives on
|
|
CalendarCal.owner; the query must join it, like routes/calendar_routes.
|
|
"""
|
|
import uuid
|
|
import sys
|
|
from datetime import datetime, timedelta
|
|
|
|
import pytest
|
|
from tests.helpers.database import disposable_database
|
|
|
|
from core.database import CalendarEvent, CalendarCal
|
|
from src.task_scheduler import _checkin_calendar_events, _digest_windows
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _digest_database(tmp_path):
|
|
with disposable_database(tmp_path) as factory:
|
|
with pytest.MonkeyPatch.context() as patcher:
|
|
patcher.setattr(sys.modules[__name__], "_TS", factory, raising=False)
|
|
yield
|
|
|
|
|
|
def _seed():
|
|
db = _TS()
|
|
try:
|
|
db.query(CalendarEvent).delete(); db.query(CalendarCal).delete()
|
|
db.add(CalendarCal(id="calA", owner="alice", name="A"))
|
|
db.add(CalendarCal(id="calB", owner="bob", name="B"))
|
|
db.add(CalendarEvent(uid="a1", calendar_id="calA", summary="Alice mtg",
|
|
dtstart=datetime(2026, 6, 10, 9, 0),
|
|
dtend=datetime(2026, 6, 10, 10, 0), status="confirmed"))
|
|
db.add(CalendarEvent(uid="b1", calendar_id="calB", summary="Bob secret",
|
|
dtstart=datetime(2026, 6, 10, 10, 0),
|
|
dtend=datetime(2026, 6, 10, 11, 0), status="confirmed"))
|
|
db.commit()
|
|
finally:
|
|
db.close()
|
|
|
|
|
|
def test_digest_only_returns_owner_events():
|
|
_seed()
|
|
db = _TS()
|
|
try:
|
|
s, e = datetime(2026, 6, 1), datetime(2026, 6, 30)
|
|
alice = _checkin_calendar_events(db, "alice", s, e)
|
|
assert [ev.summary for ev in alice] == ["Alice mtg"] # not Bob's
|
|
bob = _checkin_calendar_events(db, "bob", s, e)
|
|
assert [ev.summary for ev in bob] == ["Bob secret"]
|
|
finally:
|
|
db.close()
|
|
|
|
|
|
def test_cancelled_excluded_and_window_respected():
|
|
_seed()
|
|
db = _TS()
|
|
try:
|
|
db2 = _TS()
|
|
db2.add(CalendarEvent(uid="a2", calendar_id="calA", summary="cancelled",
|
|
dtstart=datetime(2026, 6, 11),
|
|
dtend=datetime(2026, 6, 11, 1, 0), status="cancelled"))
|
|
db2.commit(); db2.close()
|
|
s, e = datetime(2026, 6, 1), datetime(2026, 6, 30)
|
|
out = _checkin_calendar_events(db, "alice", s, e)
|
|
assert "cancelled" not in [ev.summary for ev in out]
|
|
finally:
|
|
db.close()
|
|
|
|
|
|
@pytest.mark.parametrize("days, expected_label", [(2, "this_week"), (7, "next_30_days")])
|
|
def test_boundary_event_appears_in_only_one_digest_window(days, expected_label):
|
|
now = datetime(2026, 6, 1, 9)
|
|
boundary = now + timedelta(days=days)
|
|
with _TS() as db:
|
|
db.add(CalendarCal(id="boundary-cal", owner="alice", name="Boundary"))
|
|
db.add(CalendarEvent(
|
|
uid="boundary-event", calendar_id="boundary-cal", summary="Boundary meeting",
|
|
dtstart=boundary, dtend=boundary + timedelta(hours=1), status="confirmed",
|
|
))
|
|
db.commit()
|
|
|
|
buckets = [
|
|
label for label, start, end in _digest_windows(now)
|
|
if _checkin_calendar_events(db, "alice", start, end)
|
|
]
|
|
assert buckets == [expected_label]
|
|
|
|
|
|
def test_digest_includes_start_and_excludes_end():
|
|
start = datetime(2026, 6, 1, 9)
|
|
end = start + timedelta(days=2)
|
|
with _TS() as db:
|
|
db.add(CalendarCal(id="bounds-cal", owner="alice", name="Bounds"))
|
|
for uid, when in [
|
|
("before", start - timedelta(seconds=1)),
|
|
("start", start),
|
|
("inside", end - timedelta(seconds=1)),
|
|
("end", end),
|
|
]:
|
|
db.add(CalendarEvent(
|
|
uid=uid, calendar_id="bounds-cal", summary=uid, dtstart=when,
|
|
dtend=when + timedelta(hours=1), status="confirmed",
|
|
))
|
|
db.commit()
|
|
|
|
assert [ev.uid for ev in _checkin_calendar_events(db, "alice", start, end)] == [
|
|
"start", "inside",
|
|
]
|