Files
odysseus/tests/test_document_edit_reference_js.py
T
Léo 1323fab0bd refactor(tests): read the whole cascade instead of style.css alone
static/style.css no longer holds every rule. 79 rules for the document,
gallery and editor panels now live in static/css/, yet 27 browser tests still
built their synthetic page with a single <link> to style.css, and 51 more read
that one file as though it were the whole cascade. Those tests kept passing
while covering less: a rule that moved became invisible to the assertion that
was meant to pin it.

Python readers now call tests.helpers.stylesheets.app_css(), and synthetic
pages are built from stylesheet_link_tags() so they load exactly what
index.html loads, in the same order. The helper already existed; this moves
the remaining callers onto it.

test_portal_dropdown_z_js parametrised over a file list including style.css to
assert an absence. Checking a negative against one file of a split stylesheet
is how a moved rule escapes, so the CSS case now checks the concatenation.

Two guards keep it from coming back: one fails on any test reading
static/style.css directly, the other on any synthetic page linking it alone.
Both name the helper to use.

No production code changes. Suite is unchanged at 6 pre-existing failures.
2026-09-29 17:05:29 +02:00

54 lines
2.1 KiB
Python
Raw Blame History

This file contains ambiguous Unicode characters
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
"""Regression guards for document-selection references in chat bubbles."""
from pathlib import Path
from tests.helpers.stylesheets import app_css
ROOT = Path(__file__).resolve().parents[1]
RENDERER = (ROOT / "static/js/chatRenderer.js").read_text(encoding="utf-8")
DOCUMENT = (ROOT / "static/js/document.js").read_text(encoding="utf-8")
STYLE = app_css()
INDEX = (ROOT / "static/index.html").read_text(encoding="utf-8")
APP = (ROOT / "static/app.js").read_text(encoding="utf-8")
def test_live_compact_document_reference_is_rendered_as_an_interactive_tag():
assert r"(?:L|lines?)\s*[\d–\-]+" in RENDERER
assert '<button type="button" class="doc-edit-tag"' in RENDERER
assert "data-doc-edit-ref" in RENDERER
def test_clicking_document_reference_restores_the_editor_selection():
assert "querySelectorAll('[data-doc-edit-ref]')" in RENDERER
assert "restoreSelectionReference" in RENDERER
assert "export async function restoreSelectionReference" in DOCUMENT
assert "restoreSelectionReference," in DOCUMENT
def test_document_reference_looks_clickable_and_has_keyboard_focus_feedback():
rule = STYLE.split(".doc-edit-tag {", 1)[1].split("}", 1)[0]
assert "cursor: pointer" in rule
assert "border:" in rule
assert "display: inline-flex" in rule
assert "border-radius: 999px" in rule
assert "line-height: 1" in rule
assert "font-size: 0.68em" in rule
assert "padding: 1px 5px" in rule
assert ".doc-edit-tag:hover" in STYLE
assert ".doc-edit-tag:focus-visible" in STYLE
def test_document_module_has_one_browser_identity_for_restore_and_chat_send():
"""Different query strings create separate JS module selection stores."""
assert "/static/js/document.js?v=20260916docctx2" in INDEX
assert "./js/document.js?v=20260916docctx2" in APP
assert "document.js?v=20260913dirtysaveicon1" not in INDEX
def test_clearing_a_rich_selection_also_resets_native_selection_stats():
clear_body = DOCUMENT.split("function clearSelection() {", 1)[1].split("\n }", 1)[0]
assert "browserSelection.removeAllRanges()" in clear_body
assert "_scheduleDocumentStats()" in clear_body