Files
odysseus/tests/test_tts_speed_malformed.py
T

32 lines
1.5 KiB
Python

"""Regression: a malformed tts_speed must not crash TTS.
services/tts/tts_service.py read `float(settings.get("tts_speed", "1"))` with no
guard in both synthesize() and get_stats(). The manage_settings agent tool maps
"speech speed"/"voice speed" to tts_speed and (because the default is a string)
writes the value through unvalidated, so an agent or a hand-edited settings.json
could store "fast"/"" and then GET /api/tts/stats and POST /api/tts/synthesize
both 500 with ValueError until the JSON is fixed by hand. The settings layer
tolerates corrupt config; this consumer now does too.
"""
from services.tts.tts_service import TTSService
_BAD_SETTINGS = {
"tts_enabled": True, "tts_provider": "browser",
"tts_model": "tts-1", "tts_voice": "alloy", "tts_speed": "fast",
}
def test_get_stats_does_not_crash_on_malformed_speed(monkeypatch, tmp_path):
service = TTSService(cache_dir=str(tmp_path))
monkeypatch.setattr(service, "_load_settings", lambda: dict(_BAD_SETTINGS))
stats = service.get_stats() # raised ValueError before the fix
assert stats["speed"] == 1.0
def test_synthesize_does_not_crash_on_malformed_speed(monkeypatch, tmp_path):
service = TTSService(cache_dir=str(tmp_path))
monkeypatch.setattr(service, "_load_settings", lambda: dict(_BAD_SETTINGS))
# 'browser' provider returns None after the (now guarded) speed parse;
# the point is that the malformed speed no longer raises ValueError first.
assert service.synthesize("hello", use_cache=False) is None