Files
odysseus/tests/test_document_rich_checklist_enter.py
T
Léo 9b2185f1cc test(harness): bind the static test server to an ephemeral port
The session-scoped autouse fixture bound 127.0.0.1:7011 and raised when the
port was taken. Because it is autouse, that raise errored every collected
test rather than the browser ones: a second worktree running its own suite
produced 10,612 errors, none of them about the code under test. 7011 is also
the application's own default port, so the suite could not run while a local
instance was up.

Bind port 0 instead and publish the resulting origin as
ODYSSEUS_TEST_STATIC_ORIGIN. The browser tests shell out to node, which
inherits the environment, so the snippets read process.env rather than
hardcoding a port. ODYSSEUS_TEST_STATIC_PORT still pins one when something
outside pytest has to reach the server; that is the only path that can now
fail to bind, and it fails with a message that says so.

Two concurrent full runs from one checkout now both pass. Only the docx export
snippet is an rf-string, so it is the only one whose JS braces needed doubling.
2026-09-25 10:45:58 +02:00

106 lines
4.9 KiB
Python

"""Browser coverage for Enter behavior inside Rich Text checklists."""
import json
import subprocess
from pathlib import Path
ROOT = Path(__file__).resolve().parents[1]
DOC_JS = (ROOT / "static/js/document.js").read_text(encoding="utf-8")
def test_checklist_enter_uses_native_edit_commands_and_resets_state():
section = DOC_JS.split("function _handleRichChecklistEnter", 1)[1].split(
"let _richInlineCodeTypingArmed", 1
)[0]
assert "document.execCommand('insertParagraph')" in section
assert "nextItem.dataset.checked = 'false'" in section
assert "document.execCommand('outdent')" in section
assert "document.execCommand('removeFormat')" in section
assert "document.execCommand('formatBlock', false, 'p')" in section
def test_enter_creates_unchecked_task_and_empty_enter_exits_cleanly():
script = r"""
import { chromium } from 'playwright';
const browser = await chromium.launch({ headless: true });
const page = await browser.newPage({ viewport: { width: 390, height: 844 } });
await page.goto(`${process.env.ODYSSEUS_TEST_STATIC_ORIGIN}/static/js/documentOutline.js`);
await page.setContent('<link rel="stylesheet" href="/static/style.css?v=20260831richtexttools91"><div id="toast"></div><div id="chat-container"></div><div id="sidebar"></div>');
await page.evaluate(async () => {
const mod = await import('/static/js/document.js?v=20260831richtexttools91&checklist-enter-test=1');
mod.init('/api');
mod.injectFreshDoc({
id: 'checklist-enter-doc',
title: 'Checklist Enter',
language: 'richtext',
current_content: '<h2>Release</h2><ul class="rich-checklist"><li data-checked="true" aria-checked="true">Finished item</li></ul>',
version_count: 1,
});
await new Promise(resolve => setTimeout(resolve, 450));
const item = document.querySelector('#doc-email-richbody li');
const range = document.createRange();
range.selectNodeContents(item);
range.collapse(false);
const selection = getSelection();
selection.removeAllRanges();
selection.addRange(range);
item.closest('[contenteditable]').focus();
});
await page.keyboard.press('Enter');
const afterFirstEnter = await page.locator('#doc-email-richbody ul.rich-checklist li').evaluateAll(items =>
items.map(item => ({ text: item.textContent, checked: item.dataset.checked }))
);
await page.keyboard.type('Next item');
await page.keyboard.press('Enter');
await page.keyboard.press('Enter');
await page.keyboard.type('Outside the checklist');
const data = await page.locator('#doc-email-richbody').evaluate(el => {
const items = Array.from(el.querySelectorAll('ul.rich-checklist > li'));
const outside = Array.from(el.querySelectorAll('p')).at(-1);
const persisted = document.createElement('template');
persisted.innerHTML = document.querySelector('#doc-editor-textarea').value;
const persistedItems = Array.from(persisted.content.querySelectorAll('ul.rich-checklist > li'));
return {
items: items.map(item => ({ text: item.textContent, checked: item.dataset.checked })),
outsideText: outside?.textContent,
outsideHasFormatting: !!outside?.querySelector('font, strike, s, del'),
selectionOutsideChecklist: !getSelection().anchorNode?.parentElement?.closest('ul.rich-checklist'),
persistedItems: persistedItems.map(item => ({ text: item.textContent, checked: item.dataset.checked })),
persistedOutside: Array.from(persisted.content.querySelectorAll('p')).at(-1)?.textContent,
persistedOutsideHasFormatting: !!Array.from(persisted.content.querySelectorAll('p')).at(-1)?.querySelector('font, strike, s, del'),
scrollWidth: document.body.scrollWidth,
viewportWidth: innerWidth,
};
});
console.log(JSON.stringify({ afterFirstEnter, ...data }));
await browser.close();
"""
result = subprocess.run(
["node", "--input-type=module", "-e", script],
cwd=ROOT,
check=False,
capture_output=True,
text=True,
)
assert result.returncode == 0, result.stderr
data = json.loads(result.stdout)
assert data["afterFirstEnter"] == [
{"text": "Finished item", "checked": "true"},
{"text": "", "checked": "false"},
]
expected_items = [
{"text": "Finished item", "checked": "true"},
{"text": "Next item", "checked": "false"},
]
assert data["items"] == expected_items
assert data["persistedItems"] == expected_items
assert data["outsideText"] == "Outside the checklist"
assert data["persistedOutside"] == "Outside the checklist"
assert data["outsideHasFormatting"] is False
assert data["persistedOutsideHasFormatting"] is False
assert data["selectionOutsideChecklist"] is True
assert data["scrollWidth"] == data["viewportWidth"]