mirror of
https://github.com/pewdiepie-archdaemon/odysseus.git
synced 2026-10-06 23:12:22 +02:00
Léo
1323fab0bd
static/style.css no longer holds every rule. 79 rules for the document, gallery and editor panels now live in static/css/, yet 27 browser tests still built their synthetic page with a single <link> to style.css, and 51 more read that one file as though it were the whole cascade. Those tests kept passing while covering less: a rule that moved became invisible to the assertion that was meant to pin it. Python readers now call tests.helpers.stylesheets.app_css(), and synthetic pages are built from stylesheet_link_tags() so they load exactly what index.html loads, in the same order. The helper already existed; this moves the remaining callers onto it. test_portal_dropdown_z_js parametrised over a file list including style.css to assert an absence. Checking a negative against one file of a split stylesheet is how a moved rule escapes, so the CSS case now checks the concatenation. Two guards keep it from coming back: one fails on any test reading static/style.css directly, the other on any synthetic page linking it alone. Both name the helper to use. No production code changes. Suite is unchanged at 6 pre-existing failures.
47 lines
1.9 KiB
Python
47 lines
1.9 KiB
Python
"""Regression guards for exact inline document-suggestion highlighting."""
|
|
|
|
from pathlib import Path
|
|
from tests.helpers.stylesheets import app_css
|
|
|
|
|
|
ROOT = Path(__file__).resolve().parents[1]
|
|
DOC_JS = (ROOT / "static/js/document.js").read_text(encoding="utf-8")
|
|
STYLE_CSS = app_css()
|
|
|
|
|
|
def test_suggestion_highlight_measures_exact_referenced_range():
|
|
assert "const startPos = _measurePos(mirror, text, idx);" in DOC_JS
|
|
assert "const endPos = _measurePos(mirror, text, idx + findText.length);" in DOC_JS
|
|
assert "endPos.x - startPos.x" in DOC_JS
|
|
assert "querySelectorAll('.doc-suggestion-highlight')" in DOC_JS
|
|
|
|
|
|
def test_suggestion_selects_exact_text_inside_textarea():
|
|
assert "textarea.setSelectionRange(start, end, 'forward');" in DOC_JS
|
|
assert "_selectSuggestionText(textarea, idx, idx + sugg.find.length);" in DOC_JS
|
|
assert "textarea.focus({ preventScroll: true });" in DOC_JS
|
|
|
|
|
|
def test_suggestion_highlight_sits_above_editor_text_layer():
|
|
rule_start = STYLE_CSS.index(".doc-suggestion-highlight {")
|
|
rule_end = STYLE_CSS.index("\n}", rule_start)
|
|
rule = STYLE_CSS[rule_start:rule_end]
|
|
|
|
assert "z-index: 3;" in rule
|
|
assert "box-shadow:" in rule
|
|
|
|
|
|
def test_suggestions_load_their_document_before_rendering():
|
|
assert "export async function handleDocSuggestions(data)" in DOC_JS
|
|
assert "if (!docs.has(data.doc_id)) await loadDocument(data.doc_id);" in DOC_JS
|
|
assert "if (data.doc_id && activeDocId !== data.doc_id)" in DOC_JS
|
|
|
|
|
|
def test_suggestions_do_not_replace_the_editor_render_layer():
|
|
handler_start = DOC_JS.index("export async function handleDocSuggestions(data)")
|
|
handler_end = DOC_JS.index("/** Render the current suggestion card", handler_start)
|
|
show_start = DOC_JS.index("function _showCurrentSuggestion()", handler_end)
|
|
show_end = DOC_JS.index("// Build the card", show_start)
|
|
|
|
assert "_showInlineDiff(" not in DOC_JS[show_start:show_end]
|