Files
odysseus/tests/test_document_rich_checklist_enter.py
T
Léo 345ce0a9ec test(document): read the editor through a module-set helper before it is split
static/js/document.js is 17,579 lines and is about to be decomposed behind a
re-export wrapper. 51 test files read it off disk and grep it as text, and 28
of those slice it with `src.split("function a", 1)[1].split("function b", 1)[0]`
-- "the region between a and b", which only means what the test intends while a
and b are neighbours in one file. Several also hard-code the file's two-space
indentation, which no extracted module reproduces. Left alone, the first
extraction makes those assertions cover the wrong region, and an `x in region`
check passes while covering more than it was written for.

tests/helpers/document_source is the one place that names the file now:

  - document_source() is the entry plus everything under static/js/document/,
    so a membership assertion keeps finding its subject wherever it lands;
  - function_body()/declaration() locate a construct by name in whichever
    module defines it and end at its real closing brace, so neither moving it
    nor moving its neighbour changes the region.

The rewrite only collapses a slice when the old terminator sat at the
construct's end. 28 slices deliberately span a whole family of functions --
everything from _docxHexColor to exportAsDocx -- and collapsing one to its
first member drops what the assertions look for, so those stay as they are and
are listed in KNOWN_ADJACENCY_SLICES, to be converted as each family becomes a
module. That list may only shrink.

Two guards come with it:

  - test_document_source_test_hygiene fails on a direct read of the entry file
    and on any new adjacency slice;
  - test_frontend_module_graph resolves every relative import under static/
    (718 of them, none broken today) and requires the document module set to
    stay in the sw.js precache, since the worker fetches the URLs it lists and
    not what they import.

test_document_module_api pins the 38 default-export keys and 29 named exports
by loading the module in a browser and reading what it actually exports, rather
than grepping for the literal object -- after extraction that object may be
assembled from imports, and a source-shape check would pass while the export
was broken.

No JavaScript moves here. static/ is untouched.
2026-09-30 09:39:05 +02:00

107 lines
4.9 KiB
Python

"""Browser coverage for Enter behavior inside Rich Text checklists."""
import json
import subprocess
from pathlib import Path
from tests.helpers.document_source import document_source
ROOT = Path(__file__).resolve().parents[1]
DOC_JS = document_source()
def test_checklist_enter_uses_native_edit_commands_and_resets_state():
section = DOC_JS.split("function _handleRichChecklistEnter", 1)[1].split(
"let _richInlineCodeTypingArmed", 1
)[0]
assert "document.execCommand('insertParagraph')" in section
assert "nextItem.dataset.checked = 'false'" in section
assert "document.execCommand('outdent')" in section
assert "document.execCommand('removeFormat')" in section
assert "document.execCommand('formatBlock', false, 'p')" in section
def test_enter_creates_unchecked_task_and_empty_enter_exits_cleanly():
script = r"""
import { chromium } from 'playwright';
const browser = await chromium.launch({ headless: true });
const page = await browser.newPage({ viewport: { width: 390, height: 844 } });
await page.goto(`${process.env.ODYSSEUS_TEST_STATIC_ORIGIN}/static/js/documentOutline.js`);
await page.setContent('<link rel="stylesheet" href="/static/style.css?v=20260831richtexttools91"><div id="toast"></div><div id="chat-container"></div><div id="sidebar"></div>');
await page.evaluate(async () => {
const mod = await import('/static/js/document.js?v=20260831richtexttools91&checklist-enter-test=1');
mod.init('/api');
mod.injectFreshDoc({
id: 'checklist-enter-doc',
title: 'Checklist Enter',
language: 'richtext',
current_content: '<h2>Release</h2><ul class="rich-checklist"><li data-checked="true" aria-checked="true">Finished item</li></ul>',
version_count: 1,
});
await new Promise(resolve => setTimeout(resolve, 450));
const item = document.querySelector('#doc-email-richbody li');
const range = document.createRange();
range.selectNodeContents(item);
range.collapse(false);
const selection = getSelection();
selection.removeAllRanges();
selection.addRange(range);
item.closest('[contenteditable]').focus();
});
await page.keyboard.press('Enter');
const afterFirstEnter = await page.locator('#doc-email-richbody ul.rich-checklist li').evaluateAll(items =>
items.map(item => ({ text: item.textContent, checked: item.dataset.checked }))
);
await page.keyboard.type('Next item');
await page.keyboard.press('Enter');
await page.keyboard.press('Enter');
await page.keyboard.type('Outside the checklist');
const data = await page.locator('#doc-email-richbody').evaluate(el => {
const items = Array.from(el.querySelectorAll('ul.rich-checklist > li'));
const outside = Array.from(el.querySelectorAll('p')).at(-1);
const persisted = document.createElement('template');
persisted.innerHTML = document.querySelector('#doc-editor-textarea').value;
const persistedItems = Array.from(persisted.content.querySelectorAll('ul.rich-checklist > li'));
return {
items: items.map(item => ({ text: item.textContent, checked: item.dataset.checked })),
outsideText: outside?.textContent,
outsideHasFormatting: !!outside?.querySelector('font, strike, s, del'),
selectionOutsideChecklist: !getSelection().anchorNode?.parentElement?.closest('ul.rich-checklist'),
persistedItems: persistedItems.map(item => ({ text: item.textContent, checked: item.dataset.checked })),
persistedOutside: Array.from(persisted.content.querySelectorAll('p')).at(-1)?.textContent,
persistedOutsideHasFormatting: !!Array.from(persisted.content.querySelectorAll('p')).at(-1)?.querySelector('font, strike, s, del'),
scrollWidth: document.body.scrollWidth,
viewportWidth: innerWidth,
};
});
console.log(JSON.stringify({ afterFirstEnter, ...data }));
await browser.close();
"""
result = subprocess.run(
["node", "--input-type=module", "-e", script],
cwd=ROOT,
check=False,
capture_output=True,
text=True,
)
assert result.returncode == 0, result.stderr
data = json.loads(result.stdout)
assert data["afterFirstEnter"] == [
{"text": "Finished item", "checked": "true"},
{"text": "", "checked": "false"},
]
expected_items = [
{"text": "Finished item", "checked": "true"},
{"text": "Next item", "checked": "false"},
]
assert data["items"] == expected_items
assert data["persistedItems"] == expected_items
assert data["outsideText"] == "Outside the checklist"
assert data["persistedOutside"] == "Outside the checklist"
assert data["outsideHasFormatting"] is False
assert data["persistedOutsideHasFormatting"] is False
assert data["selectionOutsideChecklist"] is True
assert data["scrollWidth"] == data["viewportWidth"]