mirror of
https://github.com/pewdiepie-archdaemon/odysseus.git
synced 2026-10-06 06:52:20 +02:00
Léo
345ce0a9ec
static/js/document.js is 17,579 lines and is about to be decomposed behind a
re-export wrapper. 51 test files read it off disk and grep it as text, and 28
of those slice it with `src.split("function a", 1)[1].split("function b", 1)[0]`
-- "the region between a and b", which only means what the test intends while a
and b are neighbours in one file. Several also hard-code the file's two-space
indentation, which no extracted module reproduces. Left alone, the first
extraction makes those assertions cover the wrong region, and an `x in region`
check passes while covering more than it was written for.
tests/helpers/document_source is the one place that names the file now:
- document_source() is the entry plus everything under static/js/document/,
so a membership assertion keeps finding its subject wherever it lands;
- function_body()/declaration() locate a construct by name in whichever
module defines it and end at its real closing brace, so neither moving it
nor moving its neighbour changes the region.
The rewrite only collapses a slice when the old terminator sat at the
construct's end. 28 slices deliberately span a whole family of functions --
everything from _docxHexColor to exportAsDocx -- and collapsing one to its
first member drops what the assertions look for, so those stay as they are and
are listed in KNOWN_ADJACENCY_SLICES, to be converted as each family becomes a
module. That list may only shrink.
Two guards come with it:
- test_document_source_test_hygiene fails on a direct read of the entry file
and on any new adjacency slice;
- test_frontend_module_graph resolves every relative import under static/
(718 of them, none broken today) and requires the document module set to
stay in the sw.js precache, since the worker fetches the URLs it lists and
not what they import.
test_document_module_api pins the 38 default-export keys and 29 named exports
by loading the module in a browser and reading what it actually exports, rather
than grepping for the literal object -- after extraction that object may be
assembled from imports, and a source-shape check would pass while the export
was broken.
No JavaScript moves here. static/ is untouched.
40 lines
1.6 KiB
Python
40 lines
1.6 KiB
Python
"""Regression guards for markdown raw-HTML sanitizer helpers."""
|
|
|
|
from pathlib import Path
|
|
from tests.helpers.document_source import document_source
|
|
|
|
|
|
_REPO = Path(__file__).resolve().parent.parent
|
|
|
|
|
|
def test_markdown_raw_html_sanitizer_checks_url_attr_edge_cases():
|
|
src = (_REPO / "static" / "js" / "markdown.js").read_text(encoding="utf-8")
|
|
|
|
assert "function _compactUrlSchemeValue(value)" in src
|
|
assert "function _isDangerousUrl(value)" in src
|
|
assert "function _isDangerousSrcset(value)" in src
|
|
assert "'srcset'" in src
|
|
assert "candidate => _isDangerousUrl(candidate)" in src
|
|
assert "name === 'srcset' ? _isDangerousSrcset(attr.value) : _isDangerousUrl(attr.value)" in src
|
|
|
|
|
|
def test_markdown_raw_html_sanitizer_strips_scriptable_css():
|
|
src = (_REPO / "static" / "js" / "markdown.js").read_text(encoding="utf-8")
|
|
|
|
assert "if (name === 'style')" in src
|
|
assert r"javascript:|vbscript:|data:|expression\(" in src
|
|
assert "el.removeAttribute(attr.name);" in src
|
|
|
|
|
|
def test_email_rich_body_render_path_reuses_raw_html_sanitizer():
|
|
markdown_src = (_REPO / "static" / "js" / "markdown.js").read_text(encoding="utf-8")
|
|
document_src = document_source()
|
|
email_body_helper = document_src.split("function _emailBodyToHtml(text)", 1)[1].split(
|
|
" // Mirror the rich body's plain text", 1
|
|
)[0]
|
|
|
|
assert "export function sanitizeAllowedHtml(html)" in markdown_src
|
|
assert "sanitizeAllowedHtml," in markdown_src
|
|
assert "markdownModule.sanitizeAllowedHtml(t)" in email_body_helper
|
|
assert "return t;" not in email_body_helper
|