mirror of
https://github.com/pewdiepie-archdaemon/odysseus.git
synced 2026-10-06 15:02:20 +02:00
Léo
ab5a08a6f9
The email library was 11,375 lines in one file, the second-largest JS module in the repo. `static/js/emailLibrary/` already held four extracted helpers, so the package existed; the bulk of the code just was not in it. The implementation moves to `emailLibrary/index.js` and the old path becomes a re-export wrapper. Five call sites import that path, four of them dynamically with a `?v=` string, and `sw.js` caches URLs verbatim, so a wrapper is what makes the move need no coordinated edit to any of them. The test side is the part worth reviewing. 58 tests read `static/js/emailLibrary.js` as text. Pointing them at `emailLibrary/index.js` would buy one move and break again on the next one, which is exactly what happened to the stylesheet tests (they now go through `tests/helpers/stylesheets.py`). So the same shape: `tests/helpers/js_modules.py` reads the whole package, and assertions stop caring which module a function sits in. `tests/test_email_library_module_graph_js.py` is new. This frontend has no module-graph validation, and a package fails in ways a single file cannot: a wrapper that drops an export is `undefined` at call time rather than an error at load time, and a module that reads a `const` across an import cycle throws only when that module is entered first. It pins the wrapper's surface against the entry module's, evaluates every module on its own in a browser, and requires both import paths to hand out one instance. It also caught a live gap while being written: `emailLibrary/replyRecipients.js` is imported by `emailInbox.js`, an app shell module, and was never in the `sw.js` precache.
22 lines
1.0 KiB
Python
22 lines
1.0 KiB
Python
from pathlib import Path
|
|
import re
|
|
from tests.helpers.js_modules import email_library_source
|
|
|
|
|
|
ROOT = Path(__file__).resolve().parent.parent
|
|
|
|
|
|
def test_email_folder_and_filter_pickers_are_exclusive_and_escape_safe():
|
|
source = email_library_source()
|
|
|
|
assert source.count("const filterMenu = document.getElementById('email-filter-menu');") == 1
|
|
assert source.count("const folderMenu = document.getElementById('email-folder-menu');") == 1
|
|
assert source.count("e.stopImmediatePropagation?.();") >= 2
|
|
assert "filterMenu?._dismiss?.();" in source
|
|
assert "folderMenu?._dismiss?.();" in source
|
|
escape_handler = source[source.index("state._libInnerEscHandler = (e) => {"):source.index("window.addEventListener('keydown', state._libInnerEscHandler, true)")]
|
|
assert "if (dismissTopMenu()) {" in escape_handler
|
|
assert "window.addEventListener('keydown', state._libInnerEscHandler, true)" in source
|
|
inbox = (ROOT / "static/js/emailInbox.js").read_text(encoding="utf-8")
|
|
assert re.search(r"from './emailLibrary\.js\?v=[A-Za-z0-9_-]+'", inbox)
|