Files
odysseus/tests/test_editor_quick_edit_static.py
T
Léo 1323fab0bd refactor(tests): read the whole cascade instead of style.css alone
static/style.css no longer holds every rule. 79 rules for the document,
gallery and editor panels now live in static/css/, yet 27 browser tests still
built their synthetic page with a single <link> to style.css, and 51 more read
that one file as though it were the whole cascade. Those tests kept passing
while covering less: a rule that moved became invisible to the assertion that
was meant to pin it.

Python readers now call tests.helpers.stylesheets.app_css(), and synthetic
pages are built from stylesheet_link_tags() so they load exactly what
index.html loads, in the same order. The helper already existed; this moves
the remaining callers onto it.

test_portal_dropdown_z_js parametrised over a file list including style.css to
assert an absence. Checking a negative against one file of a split stylesheet
is how a moved rule escapes, so the CSS case now checks the concatenation.

Two guards keep it from coming back: one fails on any test reading
static/style.css directly, the other on any synthetic page linking it alone.
Both name the helper to use.

No production code changes. Suite is unchanged at 6 pre-existing failures.
2026-09-29 17:05:29 +02:00

50 lines
2.0 KiB
Python

from pathlib import Path
from tests.helpers.stylesheets import app_css
ROOT = Path(__file__).resolve().parents[1]
EDITOR = (ROOT / "static/js/galleryEditor.js").read_text(encoding="utf-8")
STYLE = app_css()
def test_quick_edit_has_persistent_expanded_identity_and_labeled_input():
assert 'class="ge-ai-command-head"' in EDITOR
assert 'class="ge-ai-command-title">Quick Edit</span>' in EDITOR
assert 'aria-label="Describe the image edit"' in EDITOR
assert 'placeholder="Describe an edit, or choose an action"' in EDITOR
assert ".ge-ai-command-head" in STYLE
def test_quick_edit_exposes_initial_actions_without_running_them_on_click():
assert "if (!q) return [];" in EDITOR
assert ".slice(0, 3)" in EDITOR
click_handler = EDITOR[
EDITOR.index("suggestions?.addEventListener('click'") :
EDITOR.index("const setOpen", EDITOR.index("suggestions?.addEventListener('click'"))
]
assert "pickSuggestion(Number(btn.dataset.aiCommandSuggestion), false);" in click_handler
def test_quick_edit_has_clear_busy_and_action_type_states():
assert 'id="ge-ai-command-clear"' in EDITOR
assert "let busy = false;" in EDITOR
assert "if (busy) return;" in EDITOR
assert "_waitForExistingButton" in EDITOR
assert "class=\"ge-ai-command-suggestion-kind\"" in EDITOR
assert ".ge-ai-command-clear" in STYLE
assert ".ge-ai-command-busy" in STYLE
def test_quick_edit_owns_escape_without_closing_the_editor():
assert "ge-ai-command-close" in EDITOR
assert "quickEdit.dispatchEvent(new CustomEvent('ge-ai-command-close'))" in EDITOR
assert "top: -2px;" in STYLE[STYLE.index(".ge-ai-command-clear"):STYLE.index(".ge-ai-command-run")]
def test_quick_edit_transforms_do_not_add_a_second_undo_snapshot():
start = EDITOR.index("if (/\\brotate\\b.*\\b180\\b")
end = EDITOR.index("if (/\\b(remove|erase", start)
transform_block = EDITOR[start:end]
assert "_saveState('Rotate" not in transform_block
assert "_saveState('Flip" not in transform_block