Files
odysseus/specs/settings-admin.md
T

20 KiB
Raw Blame History

Settings And Admin Surfaces

Last updated: dev@c74f475 | 2026-10-15

Scope

This spec covers settings and admin surfaces in:

  • app.py auth-exempt and route-registration wiring;
  • routes/auth_routes.py for setup, login/status, users, features, settings, and integration settings routes;
  • core/auth.py and core/middleware.py admin/privilege behavior;
  • src/settings.py and src/settings_scrub.py;
  • routes/prefs_routes.py;
  • src/preset_manager.py and routes/preset_routes.py;
  • routes/backup_routes.py and scripts/odysseus-backup;
  • routes/diagnostics_routes.py;
  • canonical routes/admin_wipe/admin_wipe_routes.py, routes/cleanup/cleanup_routes.py, and routes/vault/vault_routes.py plus their top-level compatibility shims;
  • src/cleanup_service.py and vault-related tool implementations;
  • routes/font_routes.py;
  • routes/model_routes.py for /api/tools and settings-bound model endpoint references;
  • src/agent_tools/admin_tools.py, src/tool_implementations.py, src/tool_execution.py, src/tool_schemas.py, and src/tool_index.py for manage_settings;
  • src/agent_loop.py for stale agent prompt references to settings APIs;
  • frontend modules static/js/appConfig.js, static/js/settings.js, static/js/settings/{registry,navigation,lifecycle,search,dom,sidebar,shell,peek,oauthReturn,agent,api,imageModels,speech,writingStyle}.js, static/js/admin.js, static/js/presets.js, static/js/theme.js, and static/js/storage.js;
  • CLI helpers scripts/odysseus-preset and scripts/odysseus-theme.

Generic API integrations are cross-referenced in integrations.md. Model endpoint CRUD and endpoint cleanup are covered in llm-models.md. Email/contact/calendar legacy setting fallbacks stay with their domain specs.

Data Stores

src.settings owns data/settings.json and data/features.json. Settings and features are merged over defaults and cached briefly. Missing, corrupt, unreadable, or non-object stores fall back to defaults.

default_model_fallbacks is a retired setting key. src.settings.without_retired_settings() removes it from loaded/API-visible settings, writes ignore it, and no migration treats it as consent for the owner-scoped foreground_fallback_enabled plus ordered foreground_model_fallbacks contract.

routes.prefs_routes owns data/user_prefs.json. It supports:

  • _users multi-user storage;
  • legacy flat prefs;
  • auth-disabled first-user compatibility without clobbering the rest of _users.

src.settings.get_user_setting() overlays only a whitelist of per-user prefs over global settings. That whitelist is mostly model/media endpoint choices.

Other active stores include:

  • data/presets.json;
  • data/vault.json;
  • static/fonts/custom;
  • DB-backed domain tables used by admin wipe and cleanup;
  • browser localStorage/sessionStorage for theme, preset, privacy, and transient UI state.

Bootstrap, Auth, And Settings Routes

routes.auth_routes owns first-run setup, login/logout/status, password/TOTP flows, signup controls, user CRUD, admin promote/demote, privilege edits, feature flags, and app settings. app.py exposes setup/status/features/settings routes before cookie auth so first-run and frontend bootstrap can work.

Settings runtime:

  • GET /api/auth/features is public feature visibility metadata;
  • POST /api/auth/features requires admin unless auth is explicitly disabled;
  • GET /api/auth/settings returns full settings to admins and the disabled-auth operator;
  • with auth enabled, non-admin or unauthenticated GET /api/auth/settings returns scrub_settings() output;
  • POST /api/auth/settings requires admin unless auth is explicitly disabled and only writes keys present in DEFAULT_SETTINGS.

src.settings_scrub owns deep secret-key scrubbing for non-admin settings reads, including snake_case and camelCase secret-like key names. It preserves structure while blanking secret-shaped string values.

Admin gates inherit the auth contracts in auth-security.md: normal deployments require an admin user, while AUTH_ENABLED=false, first-run/setup mode, validated internal-tool loopback, and direct localhost bypass have explicit behavior in auth middleware/helpers.

Preferences And Frontend State

routes.prefs_routes owns per-user key/value preferences. Theme and custom-theme code uses localStorage first, syncs selected prefs through /api/prefs/*, and falls back from server prefs when local theme state is absent.

static/js/theme.js owns:

  • theme and custom-theme persistence;
  • old theme-name migrations;
  • custom font selection and /api/fonts/custom discovery;
  • bundled accessibility font selection such as OpenDyslexic and text-size variable application;
  • CSS variable application.

static/js/settings.js coordinates compatibility exports and delegates Agent, image-model, speech and writing-style panel initialization to their named leaf modules; while static/js/settings/registry.js is the canonical group/panel metadata inventory. navigation.js activates panels and lazy admin content, search.js implements the registry-backed finder while filtering admin-only entries, lifecycle.js owns modal open/close/Escape/drag/docking behavior, sidebar.js owns persisted collapse/resize state, and dom.js holds shared DOM helpers. shell.js owns the coordination above those primitives — per-panel activation side effects, the admin-controller handoff, .admin-only visibility, and the public open()/close() entry points — holding no panel state of its own and taking what it needs from settings.js as injected callbacks. peek.js owns the Appearance window-fade chrome and clearing it when the user leaves that panel, and oauthReturn.js owns the once-per-load return path from the Google OAuth redirect into the Integrations panel. Registry/DOM consistency is a tested contract; new panels must update both the registry metadata and actual DOM. static/js/appConfig.js shares one promise cache for settings and tool reads across frontend modules, consumes a login-page settings prefetch once, drops rejected promises for retry, and requires settings/tool writers to invalidate the matching cache; /api/tools writes invalidate both entries because disabled tools live in settings state.

Settings panels cover provider/model/search/research/reminder/email/CalDAV/CardDAV/vault, accessibility/font/text-size, scoped tokens, and unified integrations. The hidden legacy fallback editor was removed; no current Settings panel exposes the new foreground fallback keys, so opt-in exists only through owner-scoped preferences/internal callers until a deliberate UI is added. Email OAuth connect preserves the selected SMTP security mode and returns to the Settings surface after callback. static/js/admin.js owns user/admin panels, model endpoints, builtin tool toggles, MCP forms, feature toggles, token/webhook panels, diagnostics, backup/import, and danger-zone wipes.

Logout/user-switch flows clear local/session storage to avoid stale cross-account UI state.

Presets

src.preset_manager.PresetManager owns preset persistence, atomic writes, default preset healing, corrupt-store fallback, and legacy custom-preset migration. routes.preset_routes owns HTTP behavior.

Runtime behavior:

  • preset list/templates/groups/expand routes are read or utility surfaces;
  • custom preset/template/group mutations are admin-gated;
  • preset expansion can call the configured model;
  • frontend activation combines persisted custom.enabled with local selected-preset UI state;
  • presets, user templates, and group presets are currently shared stores, not owner-scoped stores.

scripts/odysseus-preset is a local CLI for preset store maintenance and backup of presets.json.

Custom presets now carry optional persona continuity notes, a general/health memory schema, thinking_mode (on, off, or provider default), and show_persona_name. PresetManager.update_persona_memory() updates matching active and saved personas; these remain shared preset data. The default custom output limit is 32,768 tokens.

Writing Style And Admin Controls

document_writing_style and email_writing_style are separate global settings. POST /api/auth/settings/document-style/extract requires an admin unless auth is explicitly disabled. It reads a bounded document upload, extracts prose, and calls the owner-resolved Utility model (Default Chat if unavailable) with at most 30,000 sample characters. Its prompt treats the sample as untrusted data; the response is a proposed style string, and the temporary file is removed in finally. static/js/settings/writingStyle.js owns the UI. This is a model inference path rather than a deterministic style parser.

auto_compact_threshold_percent defaults to 85 and settings writes clamp it to 50–95. utility_reasoning_effort is an allowed per-user override; utility fallback entries can specify their own effort. Admin PUT /api/auth/users/{username}/password delegates to AuthManager.reset_user_password, accepts only existing non-admin targets, revokes their sessions after reset, and validates minimum length and the 72-byte UTF-8 limit.

Tools Settings

routes.model_routes owns /api/tools, which writes settings.json:disabled_tools for global builtin tool toggles.

src.agent_tools.admin_tools.do_manage_settings() owns the model-facing settings tool and is re-exported through src.tool_implementations. It is admin-only through tool execution/security policy, writes real global settings, refuses secret-shaped setting writes, refuses structured clobbers, resolves model aliases to endpoints, and can enable/disable tools.

The stale app_api prompt text that mentions /api/settings is not the canonical settings surface; the live HTTP route is /api/auth/settings, and manage_settings is the intended agent settings tool. The manage_settings schema also still describes free-form preferences even though implementation only accepts keys in DEFAULT_SETTINGS.

Backup And Import

routes.backup_routes owns admin JSON export/import for selected app state:

  • owner-filtered memories;
  • shared presets;
  • owner-filtered skills;
  • raw global settings;
  • feature flags;
  • per-user preferences.

HTTP export is secret-bearing because it includes raw settings. Treat exported files as sensitive admin artifacts.

HTTP import is best-effort and section-based. It rejects invalid top-level JSON, ignores unrecognized or wrongly typed sections, merges recognized sections, and may partially write earlier sections before a later failure. Memory dedup is scoped to the importing user; imported memories/skills without owners are stamped to the caller, while explicit owner fields are preserved. Skill import writes through the disk-backed SkillsManager.add_skill() API, not the removed JSON-era save() shape.

scripts/odysseus-backup is a separate local data/ snapshot/restore tool, with some large/runtime subtrees behind flags. It uses SQLite backup where applicable, rejects archives written inside data/, validates restore members, refuses links/special files, and skips entries that disappear or become unstatable while a backup directory listing is assembled.

Diagnostics, Cleanup, And Wipe

routes.diagnostics_routes owns admin diagnostics for DB, RAG, YouTube, research status, aggregate optional service health, and application log tails. The service-health endpoint checks ChromaDB, SearXNG, email accounts, ntfy, and model provider endpoints with bounded probes and redacted output. URL-bearing diagnostics should use log-safety redaction helpers so credentials/query strings do not leak. /api/diagnostics/logs reads a bounded tail from DATA_DIR/logs/app.log, with missing logs returning an empty result. Diagnostics are operational and must avoid growing into broad secret/environment dumps.

routes.cleanup_routes is owner-scoped, not admin-only. It previews and applies session cleanup for the current user through src.cleanup_service; when auth is disabled, cleanup can operate as a single-user unscoped flow.

routes.admin_wipe_routes owns global per-domain destructive wipe actions. Current kinds include chats, memory, skills, notes, tasks, documents, gallery, and calendar. Server enforcement is admin gate plus kind allowlist. Frontend double confirmation in static/js/admin.js is user-interface protection, not server authorization.

Vault

routes.vault_routes owns Vaultwarden/Bitwarden CLI config, login, unlock, lock, logout, and bw_installed checks.

Runtime behavior:

  • GET /api/vault/config returns no session value;
  • data/vault.json stores config and BW_SESSION;
  • POSIX saves attempt 0600 permissions;
  • master passwords are passed to bw on stdin, not argv;
  • missing bw degrades to route error/status responses;
  • corrupt or non-object vault config loads as empty config;
  • lock/logout clear the saved session.

Vault tool paths duplicate some route behavior and can return vault item secrets to an admin tool result after a reason check and audit log. They are admin/local trust-boundary surfaces.

Fonts

routes.font_routes lists user-supplied font files under static/fonts/custom. It is a support/discovery route, not an admin operation. static/js/theme.js owns consuming this list for theme font selection.

Security And Provenance

  • With auth enabled, non-admin and unauthenticated settings reads are scrubbed; explicit disabled-auth operator reads return full settings.
  • Full settings responses, admin edit forms, vault flows, backup files, and local CLI artifacts can contain secrets and need their applicable access and storage protections.
  • Backup artifacts are sensitive because settings may include API keys, passwords, tokens, and endpoint credentials.
  • Diagnostics and logs should avoid adding secret-bearing values.
  • Admin wipe is global per kind and crosses owners.
  • Cleanup is owner-scoped in normal auth mode.
  • manage_settings blocks secret-shaped setting writes and structured setting clobbers.
  • Vault master passwords must not appear in process argv.
  • Client-side confirmations are not server authorization controls.

Degraded And Compatibility Behavior

  • Settings/features fall back to defaults on missing/corrupt/unreadable/non-object stores.
  • is_setting_overridden() has a narrower error contract than load_settings().
  • Prefs support legacy flat files and auth-disabled first-user writes.
  • Presets heal missing built-ins and legacy custom state without clobbering user edits.
  • /api/import is non-atomic section merge.
  • Vault route and vault tool degraded behavior are not identical.
  • Theme/preset frontend helpers tolerate malformed localStorage values.
  • CLI helpers are local maintenance surfaces and may bypass HTTP route policy.

App Configuration Gates And Cleanup

routes/auth_routes.py uses _require_admin_user() for settings writes, feature writes, document-style extraction and integration management. Explicit AUTH_ENABLED=false admits the operator without a session identity, and settings GET returns unscrubbed values in that mode; auth-enabled callers need an admin for writes and get scrubbed reads unless admin. User-store administration still requires a real admin identity. static/js/settings.js reports shortcut save failure with a toast; settings writes use the existing response-status-checking API helper.

src/cleanup_service.py previews and deletes using durable ChatMessage row counts rather than Session.message_count; it selects only the configured most-recent IDs for protection. The DELETE rechecks owner, archive state, age, importance and actual message threshold. Supported databases use DELETE RETURNING to attribute deleted rows and estimated space; legacy SQLite has a rowcount/survivor fallback with bounded estimate attribution. Cache eviction follows commit and includes observed externally removed candidates; estimates are not a measurement of reclaimed database bytes.

Testing Notes

Current targeted coverage includes settings store fallback/error paths, settings scrub, shared frontend config caching/invalidation/prefetch behavior, prefs no-clobber behavior, atomic preset store/migration/CLI/localStorage helpers, backup import cross-user dedup, backup CLI restore/list-race safety, cleanup owner scope, diagnostics admin-gate/source/service-health/log-tail checks, admin promote/demote, admin wipe gallery, font family derivation, theme helper behavior, vault password-not-in-argv checks, setup/auth regressions, reserved usernames, Google email OAuth route/helper behavior, and a token-budget manage_settings path.

Panel Save And Vault Identity Details

static/js/settings/api.js centralizes settings POSTs, rejects non-OK/403 responses and invalidates the shared cache in finally even on failure. Older per-panel unchecked-response behavior is superseded by this final helper; individual UI completion is not model/provider acceptance. Image model selectors retain the final mixed eligibility filter rather than an image-only historical rule. Sidebar build information fetches public version/build/source-commit metadata, hides failed/unknown responses and abbreviates hexadecimal commits for display; arbitrary overrides are not byte attestation.

Vault tool bindings require an explicit matching configuration owner and pin backend/config/session incarnations plus exact observed item identities. routes/vault/vault_routes.py checks configuration ownership on save and clears session/unlock time when adopting ownerless legacy state. Same-owner configuration edits retain saved session/unlock fields while invalidating bindings whose configuration incarnation changes. Configuration reads and login/unlock/lock/logout use common require_admin() without that owner-binding check. Observed catalog names or selectors cannot renew a revoked tool backend; search observations can update selected entries without proving every remote account/session is fresh.

Current Gaps

  • Settings/features route tests cover disabled-auth operation, auth-enabled read scrubbing, admin/non-admin writes, numeric validation and ignoring unknown keys; real auth-middleware integration and broader store-failure combinations still need coverage.
  • Add /api/tools and manage_settings tests for secret write refusal, enum/integer coercion failures, structured-setting refusal, reset/default behavior, endpoint/model resolution, and tool enable/disable aliases.
  • Add backup tests for secret-bearing export policy, owner-scoped exported sections, invalid import handling, skills dedup, settings/features merge, and admin gates.
  • Add diagnostics tests for broader error redaction and sensitive output limits.
  • Add admin wipe tests for every wipe kind, unknown-kind 400, rollback behavior, and admin gating.
  • Add vault route tests for session omission, permission setting, login/unlock failures, lock/logout clearing, corrupt config, and admin gates.
  • Add broader frontend behavior coverage for Settings/Admin panel save/load flows, vault password clearing, diagnostics buttons, cleanup/wipe confirmations, custom font/theme wiring, and tab state; registry/navigation/finder/lifecycle contracts now have focused source/JS tests, and the real-ESM coordinator smoke in tests/helpers/test_settings_shell_coordinator.mjs additionally covers the shell's admin-only visibility, admin-controller handoff and Peek fade/clear behavior.
  • Decide whether user_templates and group_presets should remain shared despite user-facing names.
  • Decide whether backup/import should preserve explicit owner fields or force imported owner ownership.
  • Settings panel code now has additional domain modules, but static/js/settings.js and static/js/admin.js remain substantial coordinators; future extraction must preserve registry and lifecycle ownership.