Files
odysseus/tests/test_document_save_shortcut.py
T
Léo 9b2185f1cc test(harness): bind the static test server to an ephemeral port
The session-scoped autouse fixture bound 127.0.0.1:7011 and raised when the
port was taken. Because it is autouse, that raise errored every collected
test rather than the browser ones: a second worktree running its own suite
produced 10,612 errors, none of them about the code under test. 7011 is also
the application's own default port, so the suite could not run while a local
instance was up.

Bind port 0 instead and publish the resulting origin as
ODYSSEUS_TEST_STATIC_ORIGIN. The browser tests shell out to node, which
inherits the environment, so the snippets read process.env rather than
hardcoding a port. ODYSSEUS_TEST_STATIC_PORT still pins one when something
outside pytest has to reach the server; that is the only path that can now
fail to bind, and it fails with a message that says so.

Two concurrent full runs from one checkout now both pass. Only the docx export
snippet is an rf-string, so it is the only one whose JS braces needed doubling.
2026-09-25 10:45:58 +02:00

90 lines
3.7 KiB
Python

"""Browser coverage for explicit Ctrl/Cmd+S document saves."""
import json
import subprocess
from pathlib import Path
ROOT = Path(__file__).resolve().parents[1]
DOC_JS = (ROOT / "static/js/document.js").read_text(encoding="utf-8")
def test_save_shortcut_uses_manual_version_path_and_cancels_autosave():
section = DOC_JS.split("pane.addEventListener('keydown'", 1)[1].split(
"// Delete (or Backspace)", 1
)[0]
assert "mod && key === 's'" in section
assert "e.preventDefault()" in section
assert "clearTimeout(_autoSaveDebounce)" in section
assert "clearTimeout(_emailRichbodySaveDebounce)" in section
assert "forceVersion: doc?.language !== 'email'" in section
assert "status.title = `${meta.title} (Ctrl+S)`" in DOC_JS
assert 'class="doc-save-button-label">Saved</span>' in DOC_JS
def test_ctrl_s_saves_rich_text_immediately_once_and_updates_status():
script = r"""
import { chromium } from 'playwright';
const browser = await chromium.launch({ headless: true });
const page = await browser.newPage({ viewport: { width: 900, height: 700 } });
const requests = [];
await page.route('**/api/document/save-shortcut-doc', async route => {
requests.push(route.request().postDataJSON());
await new Promise(resolve => setTimeout(resolve, 40));
await route.fulfill({
status: 200,
contentType: 'application/json',
body: JSON.stringify({ version_count: 2 }),
});
});
await page.goto(`${process.env.ODYSSEUS_TEST_STATIC_ORIGIN}/static/js/documentStats.js`);
await page.setContent('<link rel="stylesheet" href="/static/style.css?v=20260831richtexttools91"><div id="toast"></div><div id="chat-container"></div><div id="sidebar"></div>');
await page.evaluate(async () => {
const mod = await import('/static/js/document.js?v=20260831richtexttools91&save-shortcut-test=1');
mod.init('/api');
mod.injectFreshDoc({
id: 'save-shortcut-doc',
title: 'Save shortcut',
language: 'richtext',
current_content: '<p>Draft</p>',
version_count: 1,
});
await new Promise(resolve => setTimeout(resolve, 450));
const paragraph = document.querySelector('#doc-email-richbody p');
const range = document.createRange();
range.selectNodeContents(paragraph);
range.collapse(false);
const selection = getSelection();
selection.removeAllRanges();
selection.addRange(range);
paragraph.closest('[contenteditable]').focus();
});
await page.keyboard.type(' updated');
const dirty = await page.locator('#doc-footer-copy-btn').getAttribute('data-save-state');
await page.keyboard.press('Control+s');
await page.waitForTimeout(100);
const saved = await page.locator('#doc-footer-copy-btn').getAttribute('data-save-state');
const badge = await page.locator('.doc-tab[data-doc-id="save-shortcut-doc"] .doc-tab-version').textContent();
await page.waitForTimeout(2700);
console.log(JSON.stringify({ dirty, saved, badge, requests }));
await browser.close();
"""
result = subprocess.run(
["node", "--input-type=module", "-e", script],
cwd=ROOT,
check=False,
capture_output=True,
text=True,
)
assert result.returncode == 0, result.stderr
data = json.loads(result.stdout)
assert data["dirty"] == "dirty"
assert data["saved"] == "saved"
assert data["badge"] == "v2"
assert len(data["requests"]) == 1
assert data["requests"][0]["force_version"] is True
assert data["requests"][0]["summary"] == "Saved version"
assert "<p>Draft updated</p>" in data["requests"][0]["content"]