Files
odysseus/tests/test_document_rich_table_tab_history.py
T
Léo 1323fab0bd refactor(tests): read the whole cascade instead of style.css alone
static/style.css no longer holds every rule. 79 rules for the document,
gallery and editor panels now live in static/css/, yet 27 browser tests still
built their synthetic page with a single <link> to style.css, and 51 more read
that one file as though it were the whole cascade. Those tests kept passing
while covering less: a rule that moved became invisible to the assertion that
was meant to pin it.

Python readers now call tests.helpers.stylesheets.app_css(), and synthetic
pages are built from stylesheet_link_tags() so they load exactly what
index.html loads, in the same order. The helper already existed; this moves
the remaining callers onto it.

test_portal_dropdown_z_js parametrised over a file list including style.css to
assert an absence. Checking a negative against one file of a split stylesheet
is how a moved rule escapes, so the CSS case now checks the concatenation.

Two guards keep it from coming back: one fails on any test reading
static/style.css directly, the other on any synthetic page linking it alone.
Both name the helper to use.

No production code changes. Suite is unchanged at 6 pre-existing failures.
2026-09-29 17:05:29 +02:00

127 lines
5.5 KiB
Python

"""Regression coverage for undoable keyboard navigation in rich-text tables."""
import json
import subprocess
from pathlib import Path
from tests.helpers.stylesheets import stylesheet_link_tags
ROOT = Path(__file__).resolve().parents[1]
DOC_JS = (ROOT / "static/js/document.js").read_text(encoding="utf-8")
def test_last_cell_tab_uses_the_undoable_table_replacement_path():
helper = DOC_JS.split("function _appendRichTableRow", 1)[1].split(
"function _insertRichTable", 1
)[0]
key_handler = DOC_JS.split("if (e.key === 'Tab')", 1)[1].split(
"let inList = false", 1
)[0]
assert "const clone = original.cloneNode(true)" in helper
assert "clone.insertRow(-1)" in helper
assert "_replaceRichTable(rich, original, clone, clone.rows.length - 1, 0)" in helper
assert "_appendRichTableRow(rich, table)" in key_handler
assert "table.insertRow(-1)" not in key_handler
assert "_scheduleDocumentHistoryControls()" in key_handler
def test_mobile_table_tab_navigation_row_creation_and_history():
script = r"""
import { chromium } from 'playwright';
const browser = await chromium.launch({ headless: true });
const page = await browser.newPage({ viewport: { width: 390, height: 844 } });
await page.goto(`${process.env.ODYSSEUS_TEST_STATIC_ORIGIN}/static/js/documentStats.js`);
await page.setContent('__ODY_STYLESHEETS__<div id="toast"></div><div id="chat-container"></div><div id="sidebar"></div>');
await page.evaluate(async () => {
const mod = await import('/static/js/document.js?v=20260831richtexttools91&table-tab-history-test=1');
mod.init('/api');
mod.injectFreshDoc({
id: 'table-tab-history-doc',
title: 'Table keyboard history',
language: 'richtext',
current_content: '<table><tbody><tr><th>A</th><th>B</th></tr><tr><td>C</td><td>D</td></tr></tbody></table><p>After</p>',
version_count: 1,
});
await new Promise(resolve => setTimeout(resolve, 450));
});
async function focusCell(row, column, atEnd = false) {
await page.evaluate(({ row, column, atEnd }) => {
const cell = document.querySelector('#doc-email-richbody table').rows[row].cells[column];
const range = document.createRange();
range.selectNodeContents(cell);
range.collapse(!atEnd);
const selection = getSelection();
selection.removeAllRanges();
selection.addRange(range);
cell.closest('[contenteditable]').focus();
}, { row, column, atEnd });
}
async function state() {
return page.evaluate(() => {
const selection = getSelection();
const node = selection.anchorNode;
const element = node?.nodeType === Node.ELEMENT_NODE ? node : node?.parentElement;
const cell = element?.closest?.('td, th');
return {
rows: document.querySelectorAll('#doc-email-richbody tr').length,
row: cell?.parentElement?.rowIndex ?? null,
column: cell?.cellIndex ?? null,
values: Array.from(document.querySelectorAll('#doc-email-richbody th, #doc-email-richbody td')).map(item => item.textContent),
undoDisabled: document.querySelector('#doc-undo-btn').disabled,
redoDisabled: document.querySelector('#doc-redo-btn').disabled,
};
});
}
await focusCell(1, 0);
await page.keyboard.press('Tab');
const forward = await state();
await page.keyboard.press('Shift+Tab');
const backward = await state();
await focusCell(1, 1, true);
await page.keyboard.press('Tab');
await page.waitForTimeout(50);
const appended = await state();
await page.locator('#doc-undo-btn').click();
await page.waitForTimeout(50);
const undone = await state();
await page.locator('#doc-redo-btn').click();
await page.waitForTimeout(50);
const redone = await state();
const overflow = await page.evaluate(() => ({
scrollWidth: document.documentElement.scrollWidth,
clientWidth: document.documentElement.clientWidth,
}));
console.log(JSON.stringify({ forward, backward, appended, undone, redone, overflow }));
await browser.close();
"""
script = script.replace("__ODY_STYLESHEETS__", stylesheet_link_tags())
result = subprocess.run(
["node", "--input-type=module", "-e", script],
cwd=ROOT,
check=False,
capture_output=True,
text=True,
)
assert result.returncode == 0, result.stderr
data = json.loads(result.stdout)
assert (data["forward"]["rows"], data["forward"]["row"], data["forward"]["column"]) == (2, 1, 1)
assert (data["backward"]["rows"], data["backward"]["row"], data["backward"]["column"]) == (2, 1, 0)
assert (data["appended"]["rows"], data["appended"]["row"], data["appended"]["column"]) == (3, 2, 0)
assert data["appended"]["values"] == ["A", "B", "C", "D", "", ""]
assert data["appended"]["undoDisabled"] is False
assert data["appended"]["redoDisabled"] is True
assert data["undone"]["rows"] == 2
assert data["undone"]["values"] == ["A", "B", "C", "D"]
assert data["undone"]["undoDisabled"] is True
assert data["undone"]["redoDisabled"] is False
assert data["redone"]["rows"] == 3
assert data["redone"]["values"] == ["A", "B", "C", "D", "", ""]
assert data["redone"]["undoDisabled"] is False
assert data["redone"]["redoDisabled"] is True
assert data["overflow"]["scrollWidth"] == data["overflow"]["clientWidth"]