Files
odysseus/tests/test_teacher_audit_owner_scope.py
DocFuriousandAlexandre Teixeira 17ee856d1c fix(teacher): import _TEACHER_SYSTEM_PROMPT from its current module (#5756)
* fix(teacher): import teacher prompt from current module

* test(teacher): make prompt monkeypatch import-order independent

---------

Co-authored-by: Alexandre Teixeira <alexandremagteixeira@gmail.com>
2026-08-12 08:13:16 +01:00

73 lines
2.7 KiB
Python

"""Owner-scope tests for the remaining _resolve_model call sites.
Both the teacher-escalation path and the skill-audit teacher resolution map a
model spec to an endpoint (and its decrypted api_key). Like /presets/expand,
that lookup must be scoped to the calling user, otherwise it can resolve another
owner's ModelEndpoint in a multi-user deployment. See #2283.
"""
import asyncio
import src.teacher_escalation as teacher_escalation
import routes.skills_routes as skills_routes
def test_call_teacher_scopes_model_resolution_to_owner(monkeypatch):
seen = {}
def fake_resolve_model(spec, owner=None):
seen["spec"] = spec
seen["owner"] = owner
return ("http://endpoint.local/v1", "teacher-model", {})
async def fake_llm_call_async(url, model, messages, **kwargs):
seen["messages"] = messages
return "teacher reply"
from src.agent_tools import model_interaction_tools
monkeypatch.setattr("src.ai_interaction._resolve_model", fake_resolve_model)
monkeypatch.setattr(
model_interaction_tools,
"_TEACHER_SYSTEM_PROMPT",
"sys",
)
monkeypatch.setattr("src.llm_core.llm_call_async", fake_llm_call_async)
result = asyncio.run(
teacher_escalation._call_teacher("teacher-model", "prompt", owner="alice")
)
assert result == "teacher reply"
assert seen["owner"] == "alice"
assert seen["spec"] == "teacher-model"
assert seen["messages"][0] == {"role": "system", "content": "sys"}
def test_audit_teacher_resolution_scoped_to_owner(monkeypatch):
seen = {}
def fake_resolve_endpoint(role, owner=None):
return ("http://worker.local/v1", "worker-model", {})
def fake_get_setting(key, default=None):
return {"teacher_enabled": True, "teacher_model": "teacher-model"}.get(key, default)
def fake_resolve_model(spec, owner=None):
seen["spec"] = spec
seen["owner"] = owner
return ("http://endpoint.local/v1", "teacher-model", {})
monkeypatch.setattr("src.endpoint_resolver.resolve_endpoint", fake_resolve_endpoint)
monkeypatch.setattr("src.settings.get_setting", fake_get_setting)
monkeypatch.setattr("src.ai_interaction._resolve_model", fake_resolve_model)
# list_model_ids is best-effort; force it to no-op so the worker model passes through.
monkeypatch.setattr("src.llm_core.list_model_ids", lambda url, headers=None: [])
url, model, headers, teacher = skills_routes._resolve_audit_models(owner="alice")
assert (url, model) == ("http://worker.local/v1", "worker-model")
assert teacher == ("http://endpoint.local/v1", "teacher-model", {})
assert seen["owner"] == "alice"
assert seen["spec"] == "teacher-model"