refactor(notes): decompose Notes into feature-owned modules (#6713)

* refactor(notes): decompose Notes into feature-owned modules

* fix(notes): avoid HTML interpolation in reminder picker

* docs(notes): drop checkpoint archives, session logs and publication drafts

The N0-N6 tarballs and raw pytest/node logs are not read by any script or
test, and the logs carry absolute home-directory paths. Once squashed into
dev they would stay in history for good. notes-pr.md and notes-issue.md
were the drafts used to open #6712 and #6713, not documentation.

notes-validation.md keeps the counts, the checkpoint hashes and
implementation.sha256 as the record; local interpreter paths and the local
Docker image name are replaced with portable placeholders.

* fix(notes): keep the state store raw and stop masonry re-observing after close

- state: writes built from views (filter, spread, splice) stored nested
  read-only views in the store, so structuredClone on a stored note threw
  DataCloneError. Store writes now unwrap nested views.
- layout: a save that resolves after closePanel re-renders the leaving pane
  and re-created the masonry ResizeObserver that teardown had disposed.
  Skip creating it once Notes is closed.
- index.js: drop 30 imported or declared names that were never used and
  group the imports at the top. Import order is unchanged.
- Revert unrelated punctuation edits in .gitattributes and keep the header
  comment and docstring first in compare/vote.js and
  test_notes_dom_xss_helpers.py.

Both fixes have a node test that fails on the previous head.

* test(notes): make script rejection assertion case-insensitive

Address CodeQL js/bad-tag-filter alert #1150 in test-only assertion and refresh Notes evidence manifest checksum.

---------

Co-authored-by: Léo <leograndcontact@gmail.com>
This commit is contained in:
Alexandre Teixeira
2026-10-15 09:29:41 +01:00
committed by GitHub
co-authored by Léo
parent 9f8eae72fd
commit f1a47f3812
121 changed files with 15318 additions and 5544 deletions
+9 -7
View File
@@ -1,3 +1,4 @@
from tests.helpers.notes_source import notes_source
from pathlib import Path
from tests.helpers.stylesheets import app_css
@@ -17,31 +18,32 @@ def test_notes_sidebar_new_action_matches_library_structure_and_animation():
def test_notes_sidebar_new_action_opens_a_note_without_toggling_panel_closed():
app = (ROOT / "static/app.js").read_text(encoding="utf-8")
notes = (ROOT / "static/js/notes.js").read_text(encoding="utf-8")
notes = notes_source("ui/quickAdd", "ui/cardInteractions", "ui/reminderDisplay", "index")
assert "event.stopPropagation()" in app[app.index("const notesNewNoteBtn"):]
assert "notesModule?.newNote?.()" in app
assert "export function newNote()" in notes
assert "function newNote()" in notes
assert "requestAnimationFrame(() => _createNote('note'))" in notes
assert "openNote, newNote, openNotes" in notes
assert "newNote: quickAdd.newNote" in notes
assert "publicNewNote as newNote" in notes
def test_sidebar_new_note_focuses_note_body_instead_of_title():
notes = (ROOT / "static/js/notes.js").read_text(encoding="utf-8")
notes = notes_source("ui/quickAdd", "ui/cardInteractions", "ui/reminderDisplay", "index")
assert "form.querySelector('.note-form-content')" in notes
assert "initialField?.focus()" in notes
def test_notes_reminder_dot_stays_before_new_note_action():
notes = (ROOT / "static/js/notes.js").read_text(encoding="utf-8")
notes = notes_source("ui/quickAdd", "ui/cardInteractions", "ui/reminderDisplay", "index")
assert "sidebarBtn.querySelector('#notes-new-note-btn')" in notes
assert "sidebarBtn.insertBefore(dot, newNoteBtn || null)" in notes
def test_checklist_preview_starts_at_first_unfinished_item():
notes = (ROOT / "static/js/notes.js").read_text(encoding="utf-8")
notes = notes_source("ui/quickAdd", "ui/cardInteractions", "ui/reminderDisplay", "index")
start = notes.index("function _bindCardEvents(body)")
end = notes.index("const tapToEditOrSelect", start)
setup = notes[start:end]
@@ -51,7 +53,7 @@ def test_checklist_preview_starts_at_first_unfinished_item():
def test_checklist_preview_releases_scroll_at_its_boundaries():
notes = (ROOT / "static/js/notes.js").read_text(encoding="utf-8")
notes = notes_source("ui/quickAdd", "ui/cardInteractions", "ui/reminderDisplay", "index")
css = app_css()
assert "el.addEventListener('wheel'" in notes