refactor(notes): decompose Notes into feature-owned modules (#6713)

* refactor(notes): decompose Notes into feature-owned modules

* fix(notes): avoid HTML interpolation in reminder picker

* docs(notes): drop checkpoint archives, session logs and publication drafts

The N0-N6 tarballs and raw pytest/node logs are not read by any script or
test, and the logs carry absolute home-directory paths. Once squashed into
dev they would stay in history for good. notes-pr.md and notes-issue.md
were the drafts used to open #6712 and #6713, not documentation.

notes-validation.md keeps the counts, the checkpoint hashes and
implementation.sha256 as the record; local interpreter paths and the local
Docker image name are replaced with portable placeholders.

* fix(notes): keep the state store raw and stop masonry re-observing after close

- state: writes built from views (filter, spread, splice) stored nested
  read-only views in the store, so structuredClone on a stored note threw
  DataCloneError. Store writes now unwrap nested views.
- layout: a save that resolves after closePanel re-renders the leaving pane
  and re-created the masonry ResizeObserver that teardown had disposed.
  Skip creating it once Notes is closed.
- index.js: drop 30 imported or declared names that were never used and
  group the imports at the top. Import order is unchanged.
- Revert unrelated punctuation edits in .gitattributes and keep the header
  comment and docstring first in compare/vote.js and
  test_notes_dom_xss_helpers.py.

Both fixes have a node test that fails on the previous head.

* test(notes): make script rejection assertion case-insensitive

Address CodeQL js/bad-tag-filter alert #1150 in test-only assertion and refresh Notes evidence manifest checksum.

---------

Co-authored-by: Léo <leograndcontact@gmail.com>
This commit is contained in:
Alexandre Teixeira
2026-10-15 09:29:41 +01:00
committed by GitHub
co-authored by Léo
parent 9f8eae72fd
commit f1a47f3812
121 changed files with 15318 additions and 5544 deletions
@@ -1,3 +1,4 @@
from tests.helpers.notes_source import notes_source
from pathlib import Path
import re
@@ -10,23 +11,23 @@ ROOT = Path(__file__).resolve().parent.parent
def test_mobile_notes_checklist_rows_remain_tappable():
css = app_css()
notes = (ROOT / "static" / "js" / "notes.js").read_text(encoding="utf-8")
notes = notes_source("ui/cardChecklist", "ui/checklist", "ui/editor", "ui/mobileEditor", "ui/mobileReorder", "ui/selection", "ui/drawing")
assert "body.notes-mobile-mode .note-card .note-checkbox {" in css
assert "pointer-events: auto;" in css
assert "touch-action: manipulation;" in css
assert "body.notes-mobile-mode .note-card .note-checkbox,\nbody.notes-mobile-mode .note-card .note-checkbox-rm" not in css
assert "if (_selectMode) return; // let card-level handler take over\n e.preventDefault();" in notes
assert re.search(r"if \(state.selectMode\) return; // let card-level handler take over\n\s+e.preventDefault\(\);", notes)
def test_mobile_edit_checklist_toggle_marks_form_dirty():
notes = (ROOT / "static" / "js" / "notes.js").read_text(encoding="utf-8")
notes = notes_source("ui/cardChecklist", "ui/checklist", "ui/editor", "ui/mobileEditor", "ui/mobileReorder", "ui/selection", "ui/drawing")
assert "container.dispatchEvent(new Event('input', { bubbles: true }));" in notes
def test_completed_mobile_todo_uses_finish_action():
notes = (ROOT / "static" / "js" / "notes.js").read_text(encoding="utf-8")
notes = notes_source("ui/cardChecklist", "ui/checklist", "ui/editor", "ui/mobileEditor", "ui/mobileReorder", "ui/selection", "ui/drawing")
assert "const _isFinishedTodo = () =>" in notes
assert "const label = _isFinishedTodo() ? 'Finish' : 'Archive';" in notes
@@ -34,10 +35,10 @@ def test_completed_mobile_todo_uses_finish_action():
def test_mobile_long_press_enters_select_mode_for_that_note():
notes = (ROOT / "static" / "js" / "notes.js").read_text(encoding="utf-8")
notes = notes_source("ui/cardChecklist", "ui/checklist", "ui/editor", "ui/mobileEditor", "ui/mobileReorder", "ui/selection", "ui/drawing")
assert "function _enterSelectMode(initialId = null)" in notes
assert "_suppressNextNoteTapId = card.dataset.noteId;" in notes
assert "app.setSuppressNextNoteTapId(card.dataset.noteId);" in notes
assert "_enterSelectMode(card.dataset.noteId);" in notes
@@ -60,7 +61,7 @@ def test_notes_mobile_checklist_asset_versions_are_bumped():
def test_drawing_edits_mark_notes_dirty_and_keep_one_gallery_image():
notes = (ROOT / "static" / "js" / "notes.js").read_text(encoding="utf-8")
notes = notes_source("ui/cardChecklist", "ui/checklist", "ui/editor", "ui/mobileEditor", "ui/mobileReorder", "ui/selection", "ui/drawing")
upload = (ROOT / "routes" / "upload_routes.py").read_text(encoding="utf-8")
note_routes = (ROOT / "routes" / "note" / "note_routes.py").read_text(encoding="utf-8")