refactor(notes): decompose Notes into feature-owned modules (#6713)

* refactor(notes): decompose Notes into feature-owned modules

* fix(notes): avoid HTML interpolation in reminder picker

* docs(notes): drop checkpoint archives, session logs and publication drafts

The N0-N6 tarballs and raw pytest/node logs are not read by any script or
test, and the logs carry absolute home-directory paths. Once squashed into
dev they would stay in history for good. notes-pr.md and notes-issue.md
were the drafts used to open #6712 and #6713, not documentation.

notes-validation.md keeps the counts, the checkpoint hashes and
implementation.sha256 as the record; local interpreter paths and the local
Docker image name are replaced with portable placeholders.

* fix(notes): keep the state store raw and stop masonry re-observing after close

- state: writes built from views (filter, spread, splice) stored nested
  read-only views in the store, so structuredClone on a stored note threw
  DataCloneError. Store writes now unwrap nested views.
- layout: a save that resolves after closePanel re-renders the leaving pane
  and re-created the masonry ResizeObserver that teardown had disposed.
  Skip creating it once Notes is closed.
- index.js: drop 30 imported or declared names that were never used and
  group the imports at the top. Import order is unchanged.
- Revert unrelated punctuation edits in .gitattributes and keep the header
  comment and docstring first in compare/vote.js and
  test_notes_dom_xss_helpers.py.

Both fixes have a node test that fails on the previous head.

* test(notes): make script rejection assertion case-insensitive

Address CodeQL js/bad-tag-filter alert #1150 in test-only assertion and refresh Notes evidence manifest checksum.

---------

Co-authored-by: Léo <leograndcontact@gmail.com>
This commit is contained in:
Alexandre Teixeira
2026-10-15 09:29:41 +01:00
committed by GitHub
co-authored by Léo
parent 9f8eae72fd
commit f1a47f3812
121 changed files with 15318 additions and 5544 deletions
+52 -1
View File
@@ -7,7 +7,7 @@
// - Other static assets (images/fonts/libs): cache-first with bg refresh.
// - API / non-GET: never cached.
// Bump CACHE_NAME whenever the precache list or SW logic changes.
const CACHE_NAME = 'odysseus-v658-publication-assets-restore';
const CACHE_NAME = 'odysseus-v659-notes-reference';
// KaTeX resolves these from its own stylesheet, so caching the CSS without them
// gives offline math fallback glyphs instead of proper typesetting.
@@ -115,6 +115,57 @@ const PRECACHE = [
// emailInbox.js has always imported this one; it was never precached.
'/static/js/emailLibrary/replyRecipients.js',
'/static/js/notes.js?v=20260911notesselectioncancel1',
'/static/js/features/notes/domain/recurrence.js',
// Exact legacy URLs still reached by the Notes graph.
'/static/js/toolWindowZOrder.js',
'/static/js/color/hex.js',
'/static/js/windowDrag.js',
'/static/js/modalSnap.js',
'/static/js/windowResize.js',
'/static/js/modalManager.js',
'/static/js/escMenuStack.js',
'/static/js/tourHintDismiss.js',
'/static/js/shared/ui/confetti.js',
'/static/js/features/notes/application/selection.js',
'/static/js/features/notes/ui/toolbar.js',
'/static/js/features/notes/ui/windowLayout.js',
'/static/js/features/notes/application/cardOperations.js',
'/static/js/features/notes/application/checklistOperations.js',
'/static/js/features/notes/application/submission.js',
'/static/js/features/notes/application/drafts.js',
'/static/js/features/notes/ui/lifecycle.js',
'/static/js/features/notes/ui/text.js',
'/static/js/features/notes/ui/colors.js',
'/static/js/features/notes/ui/panel.js',
'/static/js/features/notes/ui/reminderDisplay.js',
'/static/js/features/notes/ui/selection.js',
'/static/js/features/notes/ui/filters.js',
'/static/js/features/notes/ui/cardRendering.js',
'/static/js/features/notes/ui/layout.js',
'/static/js/features/notes/ui/quickAdd.js',
'/static/js/features/notes/ui/cardInteractions.js',
'/static/js/features/notes/ui/cardChecklist.js',
'/static/js/features/notes/ui/cardReorder.js',
'/static/js/features/notes/ui/draftEditor.js',
'/static/js/features/notes/ui/editor.js',
'/static/js/features/notes/ui/reminderPicker.js',
'/static/js/features/notes/ui/checklist.js',
'/static/js/features/notes/ui/drawing.js',
'/static/js/features/notes/ui/clipboard.js',
'/static/js/features/notes/ui/mobileEditor.js',
'/static/js/features/notes/ui/mobileReorder.js',
'/static/js/features/notes/ui/checklistReorder.js',
'/static/js/features/notes/application/queries.js',
'/static/js/features/notes/application/agentActions.js',
'/static/js/features/notes/application/deletion.js',
'/static/js/features/notes/domain/noteRules.js',
'/static/js/features/notes/index.js',
'/static/js/features/notes/application/reminders.js',
'/static/js/features/notes/infrastructure/notifications.js',
'/static/js/features/notes/application/state.js',
'/static/js/features/notes/application/workflows.js',
'/static/js/features/notes/infrastructure/http.js',
'/static/js/features/notes/infrastructure/storage.js',
'/static/js/tasks.js?v=20260914taskmodel1',
'/static/js/calendar.js?v=20260914emailsource11',
'/static/js/calendar/utils.js',