refactor(notes): decompose Notes into feature-owned modules (#6713)

* refactor(notes): decompose Notes into feature-owned modules

* fix(notes): avoid HTML interpolation in reminder picker

* docs(notes): drop checkpoint archives, session logs and publication drafts

The N0-N6 tarballs and raw pytest/node logs are not read by any script or
test, and the logs carry absolute home-directory paths. Once squashed into
dev they would stay in history for good. notes-pr.md and notes-issue.md
were the drafts used to open #6712 and #6713, not documentation.

notes-validation.md keeps the counts, the checkpoint hashes and
implementation.sha256 as the record; local interpreter paths and the local
Docker image name are replaced with portable placeholders.

* fix(notes): keep the state store raw and stop masonry re-observing after close

- state: writes built from views (filter, spread, splice) stored nested
  read-only views in the store, so structuredClone on a stored note threw
  DataCloneError. Store writes now unwrap nested views.
- layout: a save that resolves after closePanel re-renders the leaving pane
  and re-created the masonry ResizeObserver that teardown had disposed.
  Skip creating it once Notes is closed.
- index.js: drop 30 imported or declared names that were never used and
  group the imports at the top. Import order is unchanged.
- Revert unrelated punctuation edits in .gitattributes and keep the header
  comment and docstring first in compare/vote.js and
  test_notes_dom_xss_helpers.py.

Both fixes have a node test that fails on the previous head.

* test(notes): make script rejection assertion case-insensitive

Address CodeQL js/bad-tag-filter alert #1150 in test-only assertion and refresh Notes evidence manifest checksum.

---------

Co-authored-by: Léo <leograndcontact@gmail.com>
This commit is contained in:
Alexandre Teixeira
2026-10-15 09:29:41 +01:00
committed by GitHub
co-authored by Léo
parent 9f8eae72fd
commit f1a47f3812
121 changed files with 15318 additions and 5544 deletions
@@ -0,0 +1,51 @@
/** Confirmed deletion and past-reminder clearing workflows. */
export function createDeletion({
app,
_deleteNoteApi,
_fetchNotes,
_isPastReminder,
_renderNotes,
effects,
state
}) {
async function _deleteNote(id) {
const ok = effects.styledConfirm
? await effects.styledConfirm('Delete this note?', { confirmText: 'Delete', danger: true })
: effects.confirm('Delete this note?');
if (!ok) return;
try { await _deleteNoteApi(id); await _fetchNotes(); _renderNotes(); effects.showToast('Deleted'); }
catch (err) { effects.showError(err.message); }
}
async function _clearPastReminders() {
const targets = state.notes.filter(n => !n.archived && _isPastReminder(n));
if (!targets.length) {
effects.showToast?.('No past reminders to clear');
return;
}
const ok = effects.styledConfirm
? await effects.styledConfirm(`Delete ${targets.length} past reminder${targets.length === 1 ? '' : 's'}?`, { confirmText: 'Delete', danger: true })
: effects.confirm(`Delete ${targets.length} past reminder${targets.length === 1 ? '' : 's'}?`);
if (!ok) return;
await Promise.all(targets.map(n => _deleteNoteApi(n.id).catch(() => {})));
await _fetchNotes();
_renderNotes();
effects.showToast?.(`Cleared ${targets.length} past reminder${targets.length === 1 ? '' : 's'}`);
}
async function deleteFromEditor(id) {
const ok = effects.styledConfirm
? await effects.styledConfirm('Delete this note?', { confirmText: 'Delete', danger: true })
: effects.confirm('Delete this note?');
if (!ok) return;
const index = state.notes.findIndex(note => note.id === id);
if (index >= 0) app.removeNoteAt(index);
app.setEditingId(null);
_renderNotes();
_deleteNoteApi(id).then(() => effects.showToast('Deleted')).catch(() => {
effects.showError('Failed to delete');
_fetchNotes().then(() => _renderNotes());
});
}
return { _deleteNote, _clearPastReminders, deleteFromEditor };
}