ci: support maintainer lab pull requests

This commit is contained in:
Alexandre Teixeira
2026-09-22 12:39:14 +01:00
parent 822ceaaac4
commit dd13f53507
3 changed files with 91 additions and 13 deletions
+8 -4
View File
@@ -4,12 +4,16 @@
## Target branch
- [ ] This PR targets **`dev`**, not `main`. All PRs land in `dev`; `main` is curated by the maintainer at each release. If your PR is on `main` by accident, click "Edit" on this PR and change the base.
- [ ] This PR targets the correct integration branch: **`lab`** in the private maintainer-preview repository, or **`dev`** in the public repository. `main` remains release-curated.
## Linked Issue
<!-- Every PR should be linked to an issue.
Use one of: Fixes #NNN | Part of #NNN | Closes #NNN -->
<!-- Public-repository PRs must link an issue:
Fixes #NNN | Part of #NNN | Closes #NNN
Private maintainer-preview PRs may instead use:
N/A — maintainer integration work
-->
Fixes #
@@ -25,7 +29,7 @@ Fixes #
## Checklist
- [ ] I searched [open issues](https://github.com/odysseus-dev/odysseus/issues) and [open PRs](https://github.com/odysseus-dev/odysseus/pulls) — this is not a duplicate.
- [ ] This PR targets `dev`
- [ ] This PR targets the correct integration branch (`lab` in maintainer-preview; `dev` in the public repository)
- [ ] My changes are limited to the scope described above — no unrelated refactors or whitespace changes mixed in.
- [ ] I actually ran the app (`docker compose up` or `uvicorn app:app`) and verified the change works end-to-end. Type-checks and unit tests are not enough.
- [ ] I did not run the app/runtime validation and stated that gap in **How to Test**. Leave this unchecked when the app-run box above is checked.
+25 -5
View File
@@ -8,6 +8,9 @@ module.exports = async ({ github, context, core }) => {
const MARKER = '<!-- pr-description-check-bot -->';
const owner = context.repo.owner;
const repo = context.repo.repo;
const isMaintainerPreview =
owner === 'pewdiepie-archdaemon'
&& repo === 'odysseus-maintainer-preview';
// Strip HTML comments so placeholder text does not count as content.
function strip(text) {
@@ -28,13 +31,30 @@ module.exports = async ({ github, context, core }) => {
descriptionProblems.push('**Summary** is empty or too short — describe what changed and why.');
}
// 2. Linked Issue must reference a real issue. Accept a bare #NNN, a closing
// keyword + #NNN, or a full issue URL (e.g. .../issues/123) — the strict
// keyword-prefixed form previously false-flagged correctly-linked PRs.
// 2. Public contributor PRs must reference a real issue. The private
// maintainer-preview repository may explicitly opt out for fast maintainer
// integration work while still requiring the section to state that intent.
const linkedSection = section('Linked Issue');
const hasIssueRef = /#\d+\b/.test(linkedSection) || /\/issues\/\d+/.test(linkedSection);
if (!linkedSection || !hasIssueRef) {
descriptionProblems.push('**Linked Issue** — add a reference like `Fixes #NNN`, a bare `#NNN`, or a link to the issue.');
const hasMaintainerNA = /^N\/A\b/i.test(linkedSection);
if (!linkedSection) {
descriptionProblems.push(
'**Linked Issue** — fill this section. Public PRs require an issue reference; ' +
'maintainer-preview PRs may use `N/A — maintainer integration work`.'
);
} else if (isMaintainerPreview) {
if (!hasIssueRef && !hasMaintainerNA) {
descriptionProblems.push(
'**Linked Issue** — use an issue reference or `N/A — maintainer integration work` ' +
'in the private maintainer-preview repository.'
);
}
} else if (!hasIssueRef) {
descriptionProblems.push(
'**Linked Issue** — add a reference like `Fixes #NNN`, a bare `#NNN`, ' +
'or a link to the issue.'
);
}
// 3. At least one Type of Change box must be checked.