Squash Odysseus development history

2026-09-13 11:42:20 +02:00 · 2026-09-11 06:04:19 +00:00
parent e5c99a5eee
commit 6ee6502010
2050 changed files with 538359 additions and 57745 deletions
@@ -0,0 +1,115 @@
+import sys
+from unittest.mock import MagicMock
+
+# This module needs the real agent-tool stack; importing it pulls in heavy
+# DB/auth deps, so we stub those just long enough to import, then restore them.
+# We deliberately do NOT pop src.tool_execution: popping and re-importing it
+# rebinds the `src` package's `tool_execution` attribute, so a later
+# `import src.tool_execution as te` resolves to a different module object than
+# the one its functions live in - which silently breaks tests that monkeypatch
+# it (e.g. test_edit_file's admin gate).
+_ABSENT = object()
+_AGENT_MODULES = ["src.agent_tools", "src.tool_parsing", "src.tool_schemas"]
+_STUBBED = [
+    "sqlalchemy", "sqlalchemy.orm", "sqlalchemy.ext", "sqlalchemy.ext.declarative",
+    "sqlalchemy.ext.hybrid", "sqlalchemy.sql", "sqlalchemy.sql.expression",
+    "src.database", "core.models", "core.database", "core.auth",
+]
+_saved_stubs = {name: sys.modules.get(name, _ABSENT) for name in _STUBBED}
+
+for _mod in _AGENT_MODULES:
+    sys.modules.pop(_mod, None)
+for _mod in _STUBBED:
+    if _mod not in sys.modules:
+        sys.modules[_mod] = MagicMock()
+
+import pytest  # noqa: E402
+import src.agent_tools  # noqa: E402,F401
+from src.tool_schemas import function_call_to_tool_block  # noqa: E402
+
+# Drop the stubs we installed so they do not leak into later tests.
+for _name, _original in _saved_stubs.items():
+    if _original is _ABSENT:
+        sys.modules.pop(_name, None)
+    else:
+        sys.modules[_name] = _original
+
+
+@pytest.mark.parametrize("arguments", [
+    '["ls -la"]',   # JSON array
+    '"ls -la"',     # bare JSON string
+    '42',            # JSON number
+    'true',          # JSON bool
+    'null',          # JSON null
+])
+def test_non_object_arguments_do_not_crash(arguments):
+    """A native function call whose arguments are valid JSON but not an object
+    must not raise (it used to throw AttributeError: 'list' object has no
+    attribute 'get', aborting the entire agent stream)."""
+    block = function_call_to_tool_block("bash", arguments)
+    # Coerced to empty args -> empty bash command, but importantly NO crash.
+    assert block is not None
+    assert block.tool_type == "bash"
+    assert block.content == ""
+
+
+@pytest.mark.parametrize("tool_name", ["list_emails", "mcp__email__list_emails"])
+def test_email_mcp_non_object_arguments_are_rejected(tool_name):
+    block = function_call_to_tool_block(tool_name, '["INBOX"]')
+
+    assert block is None
+
+
+def test_write_file_recovers_legacy_command_path_content_shape():
+    block = function_call_to_tool_block(
+        "write_file",
+        '{"command":"/workspace/output.html\\n<html>ok</html>"}',
+    )
+
+    assert block is not None
+    assert block.tool_type == "write_file"
+    assert block.content == "/workspace/output.html\n<html>ok</html>"
+
+
+def test_write_file_rejects_one_line_command_alias():
+    block = function_call_to_tool_block(
+        "write_file",
+        '{"command":"not a path-plus-content payload"}',
+    )
+
+    assert block is None
+
+
+def test_edit_document_skips_non_object_edit_items():
+    block = function_call_to_tool_block(
+        "edit_document",
+        '{"edits": ["bad", 42, null, {"find": "old", "replace": "new"}]}',
+    )
+
+    assert block is not None
+    assert block.tool_type == "edit_document"
+    assert block.content == "<<<FIND>>>\nold\n<<<REPLACE>>>\nnew\n<<<END>>>"
+
+
+def test_suggest_document_skips_non_object_suggestion_items():
+    block = function_call_to_tool_block(
+        "suggest_document",
+        '{"suggestions": ["bad", 42, null, {"find": "old", "replace": "new", "reason": "clearer"}]}',
+    )
+
+    assert block is not None
+    assert block.tool_type == "suggest_document"
+    assert block.content == (
+        "<<<FIND>>>\nold\n<<<SUGGEST>>>\nnew\n<<<REASON>>>\nclearer\n<<<END>>>"
+    )
+
+
+def test_ui_control_open_email_reply_preserves_structured_body():
+    block = function_call_to_tool_block(
+        "ui_control",
+        '{"action":"open_email_reply","uid":"3228","folder":"INBOX","mode":"reply","body":"Hi Andy,\\n\\nNo thank you.\\n\\nBest,"}',
+    )
+
+    assert block is not None
+    assert block.tool_type == "ui_control"
+    assert block.content == "open_email_reply 3228 INBOX reply Hi Andy,\n\nNo thank you.\n\nBest,"