From 41cace1337b50164efd66f621c05d3e5b19c3076 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?L=C3=A9o?= Date: Wed, 7 Oct 2026 13:51:58 +0200 Subject: [PATCH] test(confinement): give user-content carve-out cases stable ids (#6555) test_allows_user_content_the_app_hands_to_the_model is parametrized on UPLOAD_DIR and friends, which sit under the per-worker data dir. pytest used those paths as test ids, so every xdist worker collected different names and `pytest -n 4` (documented in tests/README.md) aborted at collection. CI shards with --shard and never saw it. --- tests/test_agent_state_dir_confinement.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/test_agent_state_dir_confinement.py b/tests/test_agent_state_dir_confinement.py index d2487c298..ab05bab18 100644 --- a/tests/test_agent_state_dir_confinement.py +++ b/tests/test_agent_state_dir_confinement.py @@ -331,7 +331,9 @@ def test_allows_files_in_the_agent_workspace(): (PERSONAL_UPLOADS_DIR, "indexed into personal docs by routes/personal_routes.py, and listed as " "an absolute path by manage_rag"), -]) +# The directories live under a per-worker data dir, so they cannot be test ids: +# xdist requires every worker to collect the same names. +], ids=["uploads", "mail_attachments", "personal", "personal_uploads"]) def test_allows_user_content_the_app_hands_to_the_model(directory, why): """Carving these out is not convenience. The app gives the model these paths and tells it to read them, so denying them breaks the feature."""