Merge commit 'refs/phase3/pre-ajax/publication-tip' into integration/pre-ajax-release

# Conflicts:
#	routes/chat_routes.py
#	routes/session_routes.py
#	src/agent_loop.py
#	src/agent_tools/filesystem_tools.py
#	src/teacher_escalation.py
#	src/tool_capabilities.py
#	src/tool_execution.py
#	tests/test_mcp_add_server_args_validation.py
#	tests/test_token_cache_atomic_swap.py
This commit is contained in:
Alexandre Teixeira
2026-10-05 15:59:59 +01:00
1395 changed files with 360455 additions and 105938 deletions
+40 -1
View File
@@ -16,9 +16,48 @@ from __future__ import annotations
import json
import os
import uuid
import functools
import threading
from typing import Any, Optional
_STORE_LOCKS: dict[str, threading.RLock] = {}
_STORE_LOCKS_GUARD = threading.Lock()
def store_transaction(path_factory):
"""Serialize a JSON read/modify/write across runtime threads and processes."""
def decorate(function):
@functools.wraps(function)
def locked(*args, **kwargs):
path = os.path.abspath(str(path_factory())) + ".lock"
with _STORE_LOCKS_GUARD:
lock = _STORE_LOCKS.setdefault(path, threading.RLock())
with lock:
os.makedirs(os.path.dirname(path), exist_ok=True)
with open(path, "a+b") as handle:
if os.name == "nt":
import msvcrt
if os.fstat(handle.fileno()).st_size == 0:
handle.write(b"0")
handle.flush()
handle.seek(0)
msvcrt.locking(handle.fileno(), msvcrt.LK_LOCK, 1)
else:
import fcntl
fcntl.flock(handle, fcntl.LOCK_EX)
try:
return function(*args, **kwargs)
finally:
if os.name == "nt":
handle.seek(0)
msvcrt.locking(handle.fileno(), msvcrt.LK_UNLCK, 1)
else:
fcntl.flock(handle, fcntl.LOCK_UN)
return locked
return decorate
def atomic_write_json(path: str, data: Any, *, indent: Optional[int] = None) -> None:
"""Atomically persist `data` as JSON at `path`.
@@ -64,4 +103,4 @@ def atomic_write_text(path: str, text: str) -> None:
try:
os.unlink(tmp)
except OSError:
pass
pass
+13
View File
@@ -465,6 +465,19 @@ class AuthManager:
logger.info("Set is_admin=%s for '%s' (by '%s')", is_admin, username, requesting_user)
return SetAdminResult.OK
def reset_user_password(self, username: str, new_password: str, requesting_user: str) -> bool:
"""Allow an admin to reset a non-admin account and revoke its sessions."""
username = username.strip().lower()
with self._config_lock:
target = self.users.get(username)
if not self.is_admin(requesting_user) or not target or target.get("is_admin"):
return False
self._config["users"][username]["password_hash"] = _hash_password(new_password)
self._save()
self.revoke_user_sessions(username)
logger.info("Password reset for '%s' by '%s'", username, requesting_user)
return True
def change_password(self, username: str, current_password: str, new_password: str) -> bool:
username = username.strip().lower()
if username not in self.users:
+347 -12
View File
@@ -5,7 +5,7 @@ from datetime import datetime, timezone
from pathlib import Path
from typing import Optional
from urllib.parse import unquote, urlparse
from sqlalchemy import DDL, event, create_engine, Column, String, Text, Boolean, DateTime, Integer, ForeignKey, JSON, Index, func, inspect, text
from sqlalchemy import DDL, event, create_engine, Column, String, Text, Boolean, DateTime, Integer, Float, ForeignKey, JSON, Index, func, inspect, text
from sqlalchemy.engine import Engine, make_url
from sqlalchemy.types import TypeDecorator
from sqlalchemy.ext.declarative import declarative_base, declared_attr
@@ -75,7 +75,7 @@ DATABASE_URL = _normalize_sqlite_url(os.getenv("DATABASE_URL", _default_database
# Create engine
engine = create_engine(
DATABASE_URL,
connect_args={"check_same_thread": False} if "sqlite" in DATABASE_URL else {}
connect_args={"check_same_thread": False, "timeout": 30} if "sqlite" in DATABASE_URL else {}
)
@@ -144,6 +144,8 @@ def set_sqlite_pragma(dbapi_connection, connection_record):
if isinstance(dbapi_connection, sqlite3.Connection):
cursor = dbapi_connection.cursor()
cursor.execute("PRAGMA foreign_keys=ON")
cursor.execute("PRAGMA busy_timeout=30000")
cursor.execute("PRAGMA journal_mode=WAL")
cursor.close()
@@ -191,9 +193,22 @@ class Session(TimestampMixin, Base):
# Configuration flags
rag = Column(Boolean, default=False)
archived = Column(Boolean, default=False)
memory_extraction_enabled = Column(Boolean, default=True)
memory_injection_enabled = Column(Boolean, default=True)
skill_injection_enabled = Column(Boolean, default=True)
thinking_mode = Column(String, nullable=True, default="off")
temperature_override = Column(Float, nullable=True, default=None)
max_tokens_override = Column(Integer, nullable=True, default=None)
# Organization
folder = Column(String, nullable=True, default=None)
cwd = Column(String, nullable=True, default=None)
# Registered ModelEndpoint this session is bound to. endpoint_url alone
# cannot distinguish two endpoints that share a provider URL but use
# different credentials (e.g. two ChatGPT Subscription accounts), so the
# exact endpoint id is remembered here. NULL = legacy session; the first
# deterministic, owner-scoped resolution persists a binding.
endpoint_id = Column(String, nullable=True, index=True)
# Headers stored as JSON
headers = Column(JSON, default=dict)
@@ -219,6 +234,7 @@ class Session(TimestampMixin, Base):
message_count = Column(Integer, default=0)
total_input_tokens = Column(Integer, default=0)
total_output_tokens = Column(Integer, default=0)
total_cost_usd = Column(Float, default=0.0)
mode = Column(String, nullable=True) # 'agent', 'chat', or 'research'
crew_member_id = Column(String, nullable=True) # links to crew_members.id
@@ -239,6 +255,12 @@ class Session(TimestampMixin, Base):
'endpoint_url': self.endpoint_url,
'rag': self.rag,
'archived': self.archived,
'memory_extraction_enabled': self.memory_extraction_enabled is not False,
'memory_injection_enabled': self.memory_injection_enabled is not False,
'skill_injection_enabled': self.skill_injection_enabled is not False,
'thinking_mode': self.thinking_mode or '',
'temperature_override': self.temperature_override,
'max_tokens_override': self.max_tokens_override,
'created_at': self.created_at.isoformat() if self.created_at else None,
'updated_at': self.updated_at.isoformat() if self.updated_at else None,
'last_accessed': self.last_accessed.isoformat() if self.last_accessed else None,
@@ -248,6 +270,7 @@ class Session(TimestampMixin, Base):
'folder': self.folder,
'total_input_tokens': self.total_input_tokens or 0,
'total_output_tokens': self.total_output_tokens or 0,
'total_cost_usd': self.total_cost_usd or 0.0,
'crew_member_id': self.crew_member_id,
}
@@ -280,6 +303,22 @@ class ChatMessage(Base):
Index('ix_messages_session_time', 'session_id', 'timestamp'), # Composite for efficient message retrieval
)
class BackgroundToolJob(Base):
"""Durable origin and once-only chat delivery for background tool work."""
__tablename__ = "background_tool_jobs"
id = Column(String, primary_key=True)
session_id = Column(String, ForeignKey("sessions.id", ondelete="CASCADE"), nullable=False, index=True)
owner = Column(String, nullable=False, index=True)
tool = Column(String, nullable=False)
query = Column(Text, nullable=False)
rounds = Column(Integer, nullable=True)
status = Column(String, nullable=False, default="running", index=True)
payload = Column(Text, nullable=True)
summary = Column(Text, nullable=True)
message_id = Column(String, nullable=True)
created_at = Column(DateTime, default=utcnow_naive)
class Document(TimestampMixin, Base):
"""Living document that the AI can create and edit in-place."""
__tablename__ = "documents"
@@ -544,6 +583,9 @@ class ModelEndpoint(TimestampMixin, Base):
# can be toggled per-endpoint in the UI. NULL = unknown, falls
# back to the model-name keyword heuristic in agent_loop.py.
supports_tools = Column(Boolean, nullable=True, default=None)
# JSON object: model id -> native tool schema surface preference.
# Values: none, compact, full. Missing key = legacy automatic behavior.
model_tool_modes = Column(Text, nullable=True)
# Per-user ownership. NULL = legacy/shared (visible to every user) — this
# is the historical default. When non-null, the model picker only shows
# the endpoint to that user (admins always see everything).
@@ -735,6 +777,7 @@ class ScheduledTask(TimestampMixin, Base):
owner = Column(String, nullable=True, index=True)
name = Column(String, nullable=False, default="Untitled Task")
prompt = Column(Text, nullable=True) # LLM prompt (for task_type="llm")
request_authority_json = Column(Text, nullable=True) # server-only admitted request snapshot
task_type = Column(String, default="llm") # "llm" | "action"
action = Column(String, nullable=True) # builtin action name (for task_type="action")
schedule = Column(String, nullable=True) # "once", "daily", "weekly", "monthly"
@@ -830,6 +873,23 @@ class TaskRun(Base):
)
class NotificationLog(Base):
"""Persisted task notifications, including completion and error text."""
__tablename__ = "notification_logs"
id = Column(String, primary_key=True, index=True)
owner = Column(String, nullable=True, index=True)
task_name = Column(String, nullable=False)
task_id = Column(String, nullable=True, index=True)
status = Column(String, nullable=False, default="success")
body = Column(Text, nullable=True)
timestamp = Column(DateTime, nullable=False, default=utcnow_naive, index=True)
__table_args__ = (
Index('ix_notification_logs_owner_time', 'owner', 'timestamp'),
)
class Memory(Base):
"""
SQLAlchemy model for Memory table.
@@ -910,6 +970,96 @@ def _migrate_add_last_message_at_column():
except Exception:
pass
def _migrate_add_memory_extraction_enabled_column():
"""Add per-session auto memory extraction toggle."""
import sqlite3
db_path = DATABASE_URL.replace("sqlite:///", "")
if not os.path.exists(db_path):
return
conn = None
try:
conn = sqlite3.connect(db_path)
columns = [row[1] for row in conn.execute("PRAGMA table_info(sessions)").fetchall()]
if "memory_extraction_enabled" not in columns:
conn.execute("ALTER TABLE sessions ADD COLUMN memory_extraction_enabled BOOLEAN DEFAULT 1")
conn.commit()
logging.getLogger(__name__).info("Migrated: added memory_extraction_enabled to sessions")
except Exception as e:
logging.getLogger(__name__).warning(f"memory_extraction_enabled migration failed: {e}")
finally:
try:
conn.close()
except Exception:
pass
def _migrate_add_skill_injection_enabled_column():
"""Add per-session skill injection toggle."""
import sqlite3
db_path = DATABASE_URL.replace("sqlite:///", "")
if not os.path.exists(db_path):
return
conn = None
try:
conn = sqlite3.connect(db_path)
columns = [row[1] for row in conn.execute("PRAGMA table_info(sessions)").fetchall()]
if "skill_injection_enabled" not in columns:
conn.execute("ALTER TABLE sessions ADD COLUMN skill_injection_enabled BOOLEAN DEFAULT 1")
conn.commit()
logging.getLogger(__name__).info("Migrated: added skill_injection_enabled to sessions")
except Exception as e:
logging.getLogger(__name__).warning(f"skill_injection_enabled migration failed: {e}")
finally:
try:
conn.close()
except Exception:
pass
def _migrate_add_memory_injection_enabled_column():
"""Add per-session memory context injection toggle."""
import sqlite3
db_path = DATABASE_URL.replace("sqlite:///", "")
if not os.path.exists(db_path):
return
conn = None
try:
conn = sqlite3.connect(db_path)
columns = [row[1] for row in conn.execute("PRAGMA table_info(sessions)").fetchall()]
if "memory_injection_enabled" not in columns:
conn.execute("ALTER TABLE sessions ADD COLUMN memory_injection_enabled BOOLEAN DEFAULT 1")
conn.commit()
logging.getLogger(__name__).info("Migrated: added memory_injection_enabled to sessions")
except Exception as e:
logging.getLogger(__name__).warning(f"memory_injection_enabled migration failed: {e}")
finally:
try:
conn.close()
except Exception:
pass
def _migrate_add_session_generation_settings_columns():
"""Add per-chat model generation controls."""
db_path = DATABASE_URL.replace("sqlite:///", "")
if not os.path.exists(db_path):
return
conn = None
try:
conn = sqlite3.connect(db_path)
columns = {row[1] for row in conn.execute("PRAGMA table_info(sessions)").fetchall()}
additions = {
"thinking_mode": "VARCHAR DEFAULT 'off'",
"temperature_override": "FLOAT",
"max_tokens_override": "INTEGER",
}
for name, sql_type in additions.items():
if name not in columns:
conn.execute(f"ALTER TABLE sessions ADD COLUMN {name} {sql_type}")
conn.commit()
except Exception as e:
logging.getLogger(__name__).warning(f"session generation settings migration failed: {e}")
finally:
if conn is not None:
conn.close()
def _migrate_add_document_archived_column():
"""Add `archived` to documents (soft-archive flag). Guarded + idempotent."""
import sqlite3
@@ -1159,6 +1309,30 @@ def _migrate_add_supports_tools_column():
pass
def _migrate_add_model_tool_modes_column():
"""Add per-model tool-surface preferences to model_endpoints if missing."""
import sqlite3
db_path = DATABASE_URL.replace("sqlite:///", "")
if not os.path.exists(db_path):
return
conn = None
try:
conn = sqlite3.connect(db_path)
cursor = conn.execute("PRAGMA table_info(model_endpoints)")
columns = [row[1] for row in cursor.fetchall()]
if columns and "model_tool_modes" not in columns:
conn.execute("ALTER TABLE model_endpoints ADD COLUMN model_tool_modes TEXT")
conn.commit()
logging.getLogger(__name__).info("Migrated: added 'model_tool_modes' column to model_endpoints")
except Exception as e:
logging.getLogger(__name__).warning(f"model_tool_modes migration failed: {e}")
finally:
try:
conn.close()
except Exception:
pass
def _migrate_add_cached_models_column():
"""Add cached_models column to model_endpoints if it doesn't exist."""
import sqlite3
@@ -1282,6 +1456,42 @@ def _migrate_add_folder_column():
except Exception:
pass
def _migrate_add_session_cwd_column():
"""Add cwd column to sessions table if it doesn't exist."""
import sqlite3
db_path = DATABASE_URL.replace("sqlite:///", "")
if not os.path.exists(db_path):
return
conn = None
try:
conn = sqlite3.connect(db_path)
cursor = conn.execute("PRAGMA table_info(sessions)")
columns = [row[1] for row in cursor.fetchall()]
if "cwd" not in columns:
conn.execute("ALTER TABLE sessions ADD COLUMN cwd TEXT")
conn.commit()
logging.getLogger(__name__).info("Migrated: added 'cwd' column to sessions")
except Exception as e:
logging.getLogger(__name__).warning(f"Migration check for cwd failed: {e}")
finally:
try:
conn.close()
except Exception:
pass
def _migrate_add_session_endpoint_id_column():
"""Add the nullable binding and index without rewriting existing sessions."""
with engine.begin() as connection:
schema = inspect(connection)
if not schema.has_table("sessions"):
return
columns = {column["name"] for column in schema.get_columns("sessions")}
if "endpoint_id" not in columns:
connection.execute(text("ALTER TABLE sessions ADD COLUMN endpoint_id VARCHAR"))
index = next(index for index in Session.__table__.indexes if index.name == "ix_sessions_endpoint_id")
index.create(bind=connection, checkfirst=True)
def _migrate_add_token_columns():
"""Add cumulative token tracking columns to sessions table."""
import sqlite3
@@ -1306,6 +1516,29 @@ def _migrate_add_token_columns():
except Exception:
pass
def _migrate_add_total_cost_usd():
"""Add cumulative USD cost column to sessions table."""
import sqlite3
db_path = DATABASE_URL.replace("sqlite:///", "")
if not os.path.exists(db_path):
return
conn = None
try:
conn = sqlite3.connect(db_path)
cursor = conn.execute("PRAGMA table_info(sessions)")
columns = [row[1] for row in cursor.fetchall()]
if "total_cost_usd" not in columns:
conn.execute("ALTER TABLE sessions ADD COLUMN total_cost_usd REAL DEFAULT 0.0")
conn.commit()
logging.getLogger(__name__).info("Migrated: added total_cost_usd column to sessions")
except Exception as e:
logging.getLogger(__name__).warning(f"Migration check for total_cost_usd failed: {e}")
finally:
try:
conn.close()
except Exception:
pass
def _migrate_add_owner_to_table(table_name: str, index_name: str):
"""Generic helper: add owner TEXT column + index to a table if missing."""
import sqlite3
@@ -1581,6 +1814,29 @@ def _migrate_add_doc_source_email_cols():
except Exception as e:
logging.getLogger(__name__).warning(f"doc source-email migration: {e}")
def _migrate_add_calendar_source_email_cols():
"""Add provenance fields so email-created events can link back to the email."""
cols_to_add = {
"source_email_uid": "VARCHAR",
"source_email_folder": "VARCHAR",
"source_email_account_id": "VARCHAR",
"source_email_message_id": "VARCHAR",
}
try:
with engine.connect() as conn:
existing = {r[1] for r in conn.execute(text("PRAGMA table_info(calendar_events)"))}
for col, spec in cols_to_add.items():
if col not in existing:
conn.execute(text(f"ALTER TABLE calendar_events ADD COLUMN {col} {spec}"))
conn.execute(text(
"CREATE INDEX IF NOT EXISTS ix_calendar_events_source_email_message_id "
"ON calendar_events (source_email_message_id)"
))
conn.commit()
except Exception as e:
logging.getLogger(__name__).warning(f"calendar source-email migration: {e}")
def _migrate_add_task_automation_columns():
"""Add automation columns to scheduled_tasks table if missing."""
new_cols = {
@@ -1824,6 +2080,7 @@ class Note(TimestampMixin, Base):
session_id = Column(String, nullable=True)
sort_order = Column(Integer, default=0)
image_url = Column(String, nullable=True) # uploaded image URL (relative path)
gallery_id = Column(String, nullable=True, index=True) # stable Gallery image for drawings
repeat = Column(String, default="none") # none, daily, weekly, monthly, yearly
# Auto-AI fields — populated by /api/notes/{id}/classify. The classification
# JSON shape is { kind, solvable, confidence, task_prompt, tools, items?: [...] }.
@@ -1883,10 +2140,31 @@ class CalendarEvent(TimestampMixin, Base):
remote_href = Column(String, nullable=True) # CalDAV object URL for updates/deletes
remote_etag = Column(String, nullable=True) # Last seen CalDAV ETag, when available
caldav_sync_pending = Column(String, nullable=True) # create | update | delete retry marker
# Provenance for events extracted from email. UID/folder form the frontend
# deep link: #email=<folder>:<imap uid>.
source_email_uid = Column(String, nullable=True, index=True)
source_email_folder = Column(String, nullable=True)
source_email_account_id = Column(String, nullable=True, index=True)
source_email_message_id = Column(String, nullable=True, index=True)
calendar = relationship("CalendarCal", back_populates="events")
class EmailCalendarInvitation(TimestampMixin, Base):
"""Revision/tombstone state for one owner's email invitation source."""
__tablename__ = "email_calendar_invitations"
id = Column(String, primary_key=True)
owner = Column(String, nullable=False, index=True)
sender = Column(String, nullable=False)
source_uid = Column(String, nullable=False)
recurrence_id = Column(String, nullable=False, default="")
event_uid = Column(String, nullable=True)
sequence = Column(Integer, nullable=False, default=0)
stamp = Column(String, nullable=False, default="")
cancelled = Column(Boolean, nullable=False, default=False)
class CalendarDeletedEvent(TimestampMixin, Base):
"""Hidden CalDAV delete tombstone retained until remote delete succeeds."""
__tablename__ = "caldav_deleted_events"
@@ -2058,6 +2336,15 @@ def _migrate_seed_email_account():
# Any future migrations or schema changes that temporarily violate foreign-key
# constraints will fail. To perform such operations, foreign_keys must be
# temporarily disabled around the migration workflow.
def _migrate_add_task_authority_column():
"""Retain snapshots after legacy task-table rebuilds; support all DBs."""
from sqlalchemy import inspect
with engine.begin() as conn:
columns = {column["name"] for column in inspect(conn).get_columns("scheduled_tasks")}
if "request_authority_json" not in columns:
conn.execute(text("ALTER TABLE scheduled_tasks ADD COLUMN request_authority_json TEXT"))
def init_db():
"""
Initialize the database by creating all tables.
@@ -2109,12 +2396,20 @@ def init_db():
_migrate_add_model_endpoint_owner_column()
_migrate_add_provider_auth_id_column()
_migrate_add_supports_tools_column()
_migrate_add_model_tool_modes_column()
_migrate_add_task_run_model_column()
_migrate_add_owner_column()
_migrate_add_document_archived_column()
_migrate_add_last_message_at_column()
_migrate_add_memory_extraction_enabled_column()
_migrate_add_memory_injection_enabled_column()
_migrate_add_skill_injection_enabled_column()
_migrate_add_session_generation_settings_columns()
_migrate_add_folder_column()
_migrate_add_session_cwd_column()
_migrate_add_session_endpoint_id_column()
_migrate_add_token_columns()
_migrate_add_total_cost_usd()
_migrate_add_mode_column()
_migrate_add_multiuser_owner_columns()
_migrate_add_gallery_caption_column()
@@ -2123,9 +2418,11 @@ def init_db():
_migrate_assign_legacy_owner()
_migrate_add_tidy_verdict()
_migrate_add_doc_source_email_cols()
_migrate_add_calendar_source_email_cols()
_migrate_add_oauth_config()
_migrate_add_email_oauth_columns()
_migrate_add_task_automation_columns()
_migrate_add_task_authority_column()
_migrate_add_disabled_tools()
_migrate_add_mcp_oauth_tokens_column()
_migrate_add_task_v2_columns()
@@ -2142,6 +2439,7 @@ def init_db():
_migrate_add_calendar_account_id()
_migrate_add_caldav_sync_columns()
_migrate_add_calendar_recurrence_exdates()
_migrate_add_note_gallery_id()
_migrate_chat_messages_fts()
_migrate_encrypt_email_passwords()
_migrate_encrypt_signatures()
@@ -2239,17 +2537,33 @@ def _migrate_chat_messages_fts():
END;
"""
)
conn.execute(
f"""
INSERT INTO chat_messages_fts(content, message_id, session_id, role)
SELECT {fts_content_expr_cm}, cm.id, cm.session_id, cm.role
FROM chat_messages cm
WHERE NOT EXISTS (
SELECT 1 FROM chat_messages_fts fts
WHERE fts.message_id = cm.id
# message_id is deliberately UNINDEXED in the FTS table. A correlated
# NOT EXISTS against it therefore becomes quadratic once the transcript
# grows large, even when there is nothing left to backfill. Build a
# temporary indexed set only when the row counts show that reconciliation
# is needed. Normal inserts/updates/deletes stay synchronized by the
# triggers above.
chat_count = conn.execute("SELECT COUNT(*) FROM chat_messages").fetchone()[0]
fts_count = conn.execute("SELECT COUNT(*) FROM chat_messages_fts").fetchone()[0]
if chat_count != fts_count:
conn.execute(
"CREATE TEMP TABLE IF NOT EXISTS _odysseus_fts_message_ids "
"(message_id TEXT PRIMARY KEY) WITHOUT ROWID"
)
conn.execute("DELETE FROM temp._odysseus_fts_message_ids")
conn.execute(
"INSERT OR IGNORE INTO temp._odysseus_fts_message_ids(message_id) "
"SELECT message_id FROM chat_messages_fts"
)
conn.execute(
f"""
INSERT INTO chat_messages_fts(content, message_id, session_id, role)
SELECT {fts_content_expr_cm}, cm.id, cm.session_id, cm.role
FROM chat_messages cm
LEFT JOIN temp._odysseus_fts_message_ids known ON known.message_id = cm.id
WHERE known.message_id IS NULL
"""
)
"""
)
_scrub_legacy_chat_message_fts_media(conn)
conn.commit()
except Exception as e:
@@ -2565,6 +2879,27 @@ def _migrate_add_calendar_recurrence_exdates():
except Exception:
pass
def _migrate_add_note_gallery_id():
"""Keep a drawn note linked to one Gallery image across edits."""
import sqlite3
db_path = DATABASE_URL.replace("sqlite:///", "")
if not os.path.exists(db_path):
return
conn = None
try:
conn = sqlite3.connect(db_path)
columns = [row[1] for row in conn.execute("PRAGMA table_info(notes)").fetchall()]
if columns and "gallery_id" not in columns:
conn.execute("ALTER TABLE notes ADD COLUMN gallery_id VARCHAR")
conn.execute("CREATE INDEX IF NOT EXISTS ix_notes_gallery_id ON notes(gallery_id)")
conn.commit()
except Exception as e:
logging.getLogger(__name__).warning(f"notes gallery_id migration failed: {e}")
finally:
if conn is not None:
conn.close()
def get_db():
"""
Dependency to get a database session.
+29
View File
@@ -118,6 +118,17 @@ class Session:
owner: Optional[str] = None
is_important: bool = False
message_count: int = 0
memory_extraction_enabled: bool = True
memory_injection_enabled: bool = True
skill_injection_enabled: bool = True
thinking_mode: str = "off"
temperature_override: Optional[float] = None
max_tokens_override: Optional[int] = None
cwd: Optional[str] = None
# Registered ModelEndpoint id this session is bound to (None = legacy /
# URL-matched). Lets two endpoints that share a provider URL but not
# credentials stay distinguishable.
endpoint_id: Optional[str] = None
def __post_init__(self):
if self.headers is None:
@@ -165,6 +176,24 @@ class Session:
for msg in self.history
if (msg.metadata or {}).get("source") != "slash"
]
from src.background_tool_jobs import background_result_context
messages = [part for message in messages for part in (
*background_result_context(message.get('metadata')), message,
)]
# Resume an interrupted thinking-only response from its actual model
# reasoning channel. Restrict this to the latest assistant message so
# old traces do not accumulate in context or cause reasoning loops.
for index in range(len(messages) - 1, -1, -1):
message = messages[index]
if message.get("role") != "assistant":
continue
metadata = message.get("metadata") or {}
thinking = str(metadata.get("thinking") or "").strip()
if metadata.get("stopped") and thinking:
resumed = dict(message)
resumed["reasoning_content"] = thinking
messages[index] = resumed
break
if not _history_grants_chat_session_approval(self.history, self.id):
return messages
+36 -34
View File
@@ -36,6 +36,19 @@ IS_APPLE_SILICON = (
)
# ── procfs ──────────────────────────────────────────────────────────────────
# Linux exposes one directory per pid under /proc; macOS and Windows have no
# procfs at all. Any code that walks it must skip the walk rather than raise.
# Kept as a module attribute so both branches stay testable on either kind of
# host.
PROC_ROOT = Path("/proc")
def has_procfs() -> bool:
"""True when the host exposes a procfs pid tree that can be scanned."""
return PROC_ROOT.is_dir()
# ── File permissions ────────────────────────────────────────────────────────
def safe_chmod(path, mode: int) -> bool:
"""``os.chmod`` that is a harmless no-op on Windows.
@@ -81,7 +94,13 @@ def pid_alive(pid: Optional[int]) -> bool:
the process it is checking. We instead open the process and read its exit
code via the Win32 API.
"""
if not pid:
if pid is None:
return False
try:
pid_int = int(pid)
except (TypeError, ValueError):
return False
if pid_int <= 0:
return False
if IS_WINDOWS:
import ctypes
@@ -91,54 +110,37 @@ def pid_alive(pid: Optional[int]) -> bool:
STILL_ACTIVE = 259
kernel32 = ctypes.windll.kernel32
handle = kernel32.OpenProcess(
PROCESS_QUERY_LIMITED_INFORMATION, False, int(pid)
PROCESS_QUERY_LIMITED_INFORMATION, False, pid_int
)
if not handle:
return False
return kernel32.GetLastError() != 87 # ERROR_INVALID_PARAMETER: PID absent
try:
code = wintypes.DWORD()
if kernel32.GetExitCodeProcess(handle, ctypes.byref(code)):
return code.value == STILL_ACTIVE
return False
return True # A failed probe does not establish death.
finally:
kernel32.CloseHandle(handle)
try:
os.kill(pid, 0)
os.kill(pid_int, 0)
return True
except (OSError, ProcessLookupError):
except ProcessLookupError:
return False
except OSError:
return True # EPERM and other inspection failures are not ESRCH.
def kill_process_tree(pid: Optional[int]) -> None:
"""Terminate ``pid`` and all of its descendants.
def kill_process_tree(pid: Optional[int], *, start_token=None, pgid=None, require_identity=False):
"""Use the runtime's shared escalating teardown and return verified death.
POSIX: signal the whole process group (``killpg``), falling back to a plain
``kill`` if the pid isn't a group leader.
Windows: ``taskkill /T /F`` walks and kills the child tree (there is no
process-group signalling).
Callers retaining durable PIDs must pass their recorded ``start_token``
with ``require_identity=True``. Native grants retain identity at spawn and
use containment.release directly; this entry point owns no grant record.
"""
if not pid:
return
if IS_WINDOWS:
try:
subprocess.run(
["taskkill", "/F", "/T", "/PID", str(pid)],
stdout=subprocess.DEVNULL,
stderr=subprocess.DEVNULL,
creationflags=getattr(subprocess, "CREATE_NO_WINDOW", 0),
)
except Exception:
pass
return
import signal
try:
os.killpg(os.getpgid(pid), signal.SIGTERM)
except Exception:
try:
os.kill(pid, signal.SIGTERM)
except Exception:
pass
from src import process_lifecycle
return process_lifecycle.terminate_tree(
pid, pgid=pgid, start_token=start_token, require_identity=require_identity,
)
# ── Shell / executable resolution ───────────────────────────────────────────
+37 -6
View File
@@ -150,6 +150,14 @@ class SessionManager:
history=[],
owner=getattr(db_session, "owner", None),
is_important=getattr(db_session, "is_important", False) or False,
memory_extraction_enabled=getattr(db_session, "memory_extraction_enabled", True) is not False,
memory_injection_enabled=getattr(db_session, "memory_injection_enabled", True) is not False,
skill_injection_enabled=getattr(db_session, "skill_injection_enabled", True) is not False,
thinking_mode=getattr(db_session, "thinking_mode", "") or "off",
temperature_override=getattr(db_session, "temperature_override", None),
max_tokens_override=getattr(db_session, "max_tokens_override", None),
cwd=getattr(db_session, "cwd", None) or None,
endpoint_id=getattr(db_session, "endpoint_id", None) or None,
)
session.message_count = getattr(db_session, "message_count", 0) or 0
return session
@@ -208,6 +216,14 @@ class SessionManager:
history=history,
owner=getattr(db_session, 'owner', None),
is_important=getattr(db_session, 'is_important', False) or False,
memory_extraction_enabled=getattr(db_session, 'memory_extraction_enabled', True) is not False,
memory_injection_enabled=getattr(db_session, 'memory_injection_enabled', True) is not False,
skill_injection_enabled=getattr(db_session, 'skill_injection_enabled', True) is not False,
thinking_mode=getattr(db_session, "thinking_mode", "") or "off",
temperature_override=getattr(db_session, "temperature_override", None),
max_tokens_override=getattr(db_session, "max_tokens_override", None),
cwd=getattr(db_session, "cwd", None) or None,
endpoint_id=getattr(db_session, "endpoint_id", None) or None,
)
# The rows just loaded are the whole transcript, so they — not the
@@ -479,12 +495,14 @@ class SessionManager:
headers = {}
session.name = db_session.name
session.endpoint_url = db_session.endpoint_url or ""
session.endpoint_id = getattr(db_session, "endpoint_id", None) or None
session.model = db_session.model or ""
session.headers = headers or {}
session.rag = db_session.rag
session.archived = db_session.archived
session.owner = getattr(db_session, "owner", None)
session.is_important = getattr(db_session, "is_important", False) or False
session.cwd = getattr(db_session, "cwd", None) or None
session.message_count = (
db.query(DbChatMessage)
.filter(DbChatMessage.session_id == session_id)
@@ -545,9 +563,15 @@ class SessionManager:
endpoint_url: str,
model: str,
rag: bool = False,
owner: str = None
owner: str = None,
cwd: str = None,
headers: Optional[Dict[str, str]] = None,
endpoint_id: Optional[str] = None,
) -> Session:
"""Create a new session and save to database."""
from src.chatgpt_subscription import is_chatgpt_subscription_base
session_headers = {} if is_chatgpt_subscription_base(endpoint_url) else dict(headers or {})
endpoint_id = (endpoint_id or "").strip() or None
db = SessionLocal()
try:
db_session = DbSession(
@@ -556,8 +580,10 @@ class SessionManager:
endpoint_url=endpoint_url,
model=model,
rag=rag,
headers={},
headers=session_headers,
owner=owner,
cwd=cwd or None,
endpoint_id=endpoint_id,
created_at=datetime.now(timezone.utc),
updated_at=datetime.now(timezone.utc)
)
@@ -570,8 +596,10 @@ class SessionManager:
endpoint_url=endpoint_url,
model=model,
rag=rag,
headers={},
headers=session_headers,
owner=owner,
cwd=cwd or None,
endpoint_id=endpoint_id,
)
self.sessions[session_id] = session
@@ -584,13 +612,16 @@ class SessionManager:
finally:
db.close()
def delete_session(self, session_id: str) -> bool:
def delete_session(self, session_id: str, *, delete_images: bool = False) -> bool:
"""Permanently delete a session and all its messages."""
db = SessionLocal()
try:
try:
from src.session_image_cleanup import cleanup_session_images
cleanup_session_images(session_id, db=db)
from src.session_image_cleanup import cleanup_session_images, preserve_session_images
if delete_images:
cleanup_session_images(session_id, db=db)
else:
preserve_session_images(session_id, db=db)
except Exception as e:
logger.warning(f"Image cleanup failed while deleting session {session_id}: {e}")