============================================================ MISTBORN: THE FINAL EMPIRE - CK3 MOD REVIEW REPORT ============================================================ Reviewed: 2026-02-08 (updated) Reviewer: Claude Code review against CK3 modding reference ============================================================ RESOLVED ISSUES (from previous review) ============================================================ [RESOLVED] CRITICAL-01/02: Trait name mismatches in triggers/effects Triggers and effects now correctly use trait_misting_* naming. [RESOLVED] CRITICAL-03: Undefined traits referenced in triggers Triggers no longer reference non-existent Era 2 metals or undefined role traits. Only defined traits are used. [RESOLVED] CRITICAL-04: Missing event namespaces All events referenced by decisions now exist: mistborn_hemalurgy.0001, mistborn_atium.0001/.0002, mistborn_skaa.0001/.0010, mistborn_skaa_allomancer.0001/.0002, mistborn_ball.0001, mistborn_snapping.0010. Note: hire_kandra_decision triggers mistborn_misc.0001 (not mistborn_kandra.0001 as previously reported). [RESOLVED] CRITICAL-06: Missing trait_noble_scadrian in decision host_a_ball_decision now uses culture = culture:noble_scadrian instead of a non-existent trait. [RESOLVED] WARNING-01: Kandra event flag mismatch hire_kandra_decision now sets hired_kandra flag in addition to kandra_contract_active and recently_hired_kandra. [RESOLVED] WARNING-02: on_action naming inconsistency All files now use consistent trait_misting_* naming. [RESOLVED] WARNING-05: Snapping decision targets wrong event subject_heir_to_snapping_decision now correctly triggers mistborn_snapping.0010 and saves scope:snapping_target. [RESOLVED] NOTE-03: descriptor.mod path field Confirmed correct: inner descriptor omits path, outer has it. ============================================================ CRITICAL ISSUES (Game-breaking, will cause errors/crashes) ============================================================ [RESOLVED] CRITICAL-01: MISSING MODIFIER DEFINITIONS All 7 modifiers now defined in common/modifiers/00_mistborn_modifiers.txt: lord_ruler_attention_1/2/3, ruin_influence, steel_inquisitor_power, great_house_status, atium_supply. [RESOLVED] CRITICAL-02: NO PROVINCE HISTORY FILES Province history created: history/provinces/00_mistborn_provinces.txt All 105 provinces have culture, religion, and holding assignments. [RESOLVED] CRITICAL-03: NO BOOKMARK DEFINITIONS Bookmark created: common/bookmarks/00_mistborn_bookmarks.txt "The End of an Empire" bookmark at 1020.1.1 with 4 recommended characters (Venture, Hasting, Elariel, Lekal). Localization added in localization/english/mistborn_bookmarks_l_english.yml. [RESOLVED] CRITICAL-04: @# COMMENT SYNTAX Fixed in 00_scadrial_religions.txt and 00_holy_sites.txt. Replaced @# with # for proper CK3 comments. ============================================================ WARNING ISSUES (Will not crash but may cause incorrect behavior) ============================================================ [RESOLVED] WARNING-01: EMPTY CULTURE PILLAR DEFINITIONS File: common/culture/pillars/00_scadrial_pillars.txt --- Fixed. Pillars now have required color property and head_determination field. All three cultures load correctly. WARNING-02: VANILLA DEPENDENCY - ETHOSES File: common/culture/cultures/00_scadrial_cultures.txt --- Cultures reference vanilla ethoses: ethos_courtly, ethos_communal, ethos_spiritual. If this becomes a full total conversion that replaces vanilla content, these won't exist. Either keep vanilla ethoses available or define custom replacements. WARNING-03: VANILLA DEPENDENCY - TRAITS File: history/characters/00_mistborn_characters.txt --- Characters use vanilla personality and education traits (ambitious, brave, callous, education_martial_2, etc.) and the create_steel_ inquisitor_effect uses vanilla trait "disfigured". These depend on vanilla trait files remaining loaded. WARNING-04: VANILLA DEPENDENCY - GFX Files: cultures, decisions --- Cultures reference vanilla gfx sets (western_coa_gfx, etc.). Decisions reference vanilla illustration paths (decision_feast.dds, etc.). These break if vanilla assets are replaced. [RESOLVED] WARNING-05: DUAL LORD RULER ATTENTION SYSTEMS Files: scripted_effects, on_action --- Unified. Variable-based system (0-100) drives automatic tiered modifiers (attention_1/2/3). Scripted effects handle increment/ decrement and threshold transitions. Single coherent approach. [RESOLVED] WARNING-06: is_feruchemist_trigger INCLUDES DORMANT POTENTIAL File: common/scripted_triggers/mistborn_triggers.txt --- Fixed. Triggers now correctly distinguish active vs dormant: - is_feruchemist_trigger: only active Feruchemists - is_full_feruchemist_trigger: same (active only) - has_feruchemical_potential: dormant potential check [RESOLVED] WARNING-07: has_allomantic_potential_trigger IS OVER-INCLUSIVE File: common/scripted_triggers/mistborn_triggers.txt --- Fixed. Triggers correctly distinguish: - is_allomancer_trigger: active Allomancers only - has_allomantic_potential_trigger: dormant potential only [RESOLVED] WARNING-08: RELIGION FAMILY DEFINITION File: common/religion/religion_families/00_scadrial_families.txt --- Fixed. Explicit religion family definition file created for rf_scadrial. No longer relying on auto-creation. ============================================================ NOTE ISSUES (Style, completeness, lore accuracy) ============================================================ [RESOLVED] NOTE-01: MISSING CUSTOM NAME LISTS File: common/culture/cultures/00_scadrial_cultures.txt --- Resolved. All three name lists populated with lore-accurate names: noble (~30 names + 6 dynasty names with founder_named_dynasties), skaa (lore names: Mennis, Lestibournes, Lessie, etc.), terris (canon -ed/-wyl/-ek endings: Sazed, Tindwyl, Rashek, etc.). NOTE-02: NO MAP DATA Directory: map_data/ (missing) --- Province IDs remapped to vanilla Swiss region (2030-3107). No custom map exists. The mod reuses vanilla provinces, which do not match Final Empire geography. Custom map planned for M8. [RESOLVED] NOTE-03: e_final_empire HAS NO HOLDER File: history/titles/00_mistborn_titles.txt --- Resolved. Lord Ruler character (900100) created and assigned as holder of e_final_empire at game start (1020.1.1). Character is immortal (health 10 + compounder_modifier), has trait_mistborn, trait_feruchemist, and is_lord_ruler_trigger defined for scripted checks. [RESOLVED] NOTE-04: TERRIS DYNASTY ASSIGNMENTS (LORE) File: history/characters/00_mistborn_characters.txt --- Resolved. dynasty_terris_stewards created. All Terris characters (Telden, Vedren, Vedzan) reassigned from noble house dynasties to dynasty_terris_stewards. Localization added. [RESOLVED] NOTE-05: CANONICAL NAME REUSE File: history/characters/00_mistborn_characters.txt --- Resolved. "Kwaan" (900081) renamed to "Vedren" to avoid confusion with the canonical historical Terris Worldbringer. NOTE-06: LOCALIZATION COVERAGE --- All defined game content has matching localization keys. Localization files are correctly encoded as UTF-8 with BOM. File naming follows the _l_english.yml convention. ============================================================ LORE ACCURACY (unchanged from previous review) ============================================================ Metal/Misting assignments: All correct for Final Empire era. Political structure: Dominances, locations all correct. Base 8 + Gold + Atium trait set is lore-accurate for this era. ============================================================ SUMMARY (updated 2026-02-08) ============================================================ CRITICAL issues: 0 (all 4 resolved) WARNING issues: 3 open of 8 (WARNING-02/03/04: vanilla dependencies) 5 resolved (WARNING-01, 05, 06, 07, 08) NOTE issues: 1 open of 6 (NOTE-02: map data, planned for M8) 5 resolved/updated (NOTE-01, NOTE-03, NOTE-04, NOTE-05 resolved; NOTE-02 updated; NOTE-06 resolved) All critical issues and all M3-targeted notes resolved. Remaining warnings are intentional vanilla dependencies (ethoses, traits, GFX) that will be addressed in M4/M8. Only open note is NOTE-02 (custom map data, planned for M8).