diff --git a/MASTERPLAN.md b/MASTERPLAN.md index e98eb3c..2d0b4c3 100644 --- a/MASTERPLAN.md +++ b/MASTERPLAN.md @@ -25,38 +25,57 @@ Court (artifact system). ## Current State -Strong foundation, not yet playable. +M1 complete, M2 nearly complete, M3 not started. Playable for testing. -**What exists:** -- 12 Misting traits + Mistborn + strength tiers + potentials -- Feruchemy (full Feruchemist + potential) -- Hemalurgy (5 spike types + Inquisitor creation) -- Compounding detection on yearly pulse +**What exists (M1 — done):** +- Province history using vanilla Swiss IDs (2030-3107), all 105 provinces assigned +- `@#` comment syntax fixed across all files +- All modifier definitions unified (Lord Ruler attention variable + tiered modifiers) +- 34 vanilla decision suppression files — no vanilla decisions bleed through +- Game rule toggle (Narrative/Sandbox) on setup screen +- Bookmark "The End of an Empire" at 1020.1.1 with 4 placeholder characters +- UTF-8 BOM encoding on all `.txt` files +- Culture pillars with required fields (color, `head_determination`) + +**What exists (M2 — ~85% done):** +- 12 Misting traits + Mistborn + 3 strength tiers + 2 potential types +- Feruchemy (full Feruchemist + potential + activation event chain) +- Hemalurgy (5 spike types + Inquisitor creation + Ruin's whispers events) +- Compounding detection on yearly pulse (duralumin/nicroburst included) - Lord Ruler Attention system (0-100, 3-tier escalation events) +- Allomantic training system (decisions + mentor events) +- Metal supply management (acquire, black market, scarcity events) +- Savant acquisition and consequences events +- Late snapping event (age 17-30, triggered by imprisonment/trauma) +- Sandbox mode decision for metallic arts testing +- 14 event files (~3,000+ lines) +- 5 MaA types (Hazekillers, Koloss, Mistborn Agents, Skaa Levy, Coinshot Squad) +- Full localization coverage (9+ files) + +**What exists (assets — ~50% of total):** +- 26 trait icons (120x120 ARGB DDS) — all metallic arts traits covered +- 42 modifier icons (60x60 ARGB DDS with mipmaps) — 21 base + 21 flavor +- 5 loading screens (4K DXT1 DDS) +- 16 event scene backgrounds (1592x848 DXT1 DDS) — all scenes covered +- 3 bookmark art variants +- Asset generation skill with style guide, category templates, DDS conversion + +**What exists (unchanged):** - 4 religions (Steel Ministry, Terris, Survivorism, Cult of Ruin), 5 holy sites - 3 cultures (noble_scadrian, skaa, terris) with pillars and traditions -- 10 dynasties (Great Houses), 20+ placeholder characters -- 5 kingdoms, duchies, counties, baronies mapped to vanilla Swiss provinces -- 4 decisions (balls, snapping, kandra, hemalurgy) -- 8 event files (~2,700 lines, several are stubs) -- 4 men-at-arms types -- Full localization coverage (874 lines across 9 files) -- Bookmark definition (bm_end_of_an_empire) with 4 placeholder characters +- 10 dynasties (Great Houses), 30 placeholder characters -**What's missing or broken:** -- Province history files are empty (mod may crash on load) -- `@#` comment syntax in several files (CK3 uses `#`) +**What's still missing (M3+):** - Characters are placeholders, not canonical Mistborn figures -- No custom map (using vanilla provinces) -- No graphics (trait icons, portraits, loading screens) -- No unlanded band system -- No custom name lists -- No vanilla content suppression (vanilla decisions bleed through) -- No game rule definitions -- No custom buildings, schemes, or casus belli -- Several event files are stubs (~20% content) - Lord Ruler not implemented as a character - `e_final_empire` has no holder +- No custom name lists (characters get vanilla Western names) +- No custom buildings (Kredik Shaw, Pits of Hathsin) +- No custom map (using vanilla provinces) +- No unlanded band system (M5) +- No custom lifestyles, schemes, casus belli, or governments (M4) +- ~120 visual assets still needed (decision illustrations, CoA, religion icons, + lifestyle assets, etc.) --- diff --git a/docs/REQUIRED_ASSETS.md b/docs/REQUIRED_ASSETS.md index 7359a54..5ff00e7 100644 --- a/docs/REQUIRED_ASSETS.md +++ b/docs/REQUIRED_ASSETS.md @@ -27,11 +27,29 @@ | Workshop thumbnail | 1 | PNG, 512x512 | M8 | | **Total unique assets** | **~230+** | | | -### Current State +### Current State (updated 2026-02-08) -Completed: 26 trait icons, 21 modifier icons, 5 loading screens, 1 bookmark -background. Remaining ~175+ assets still needed. All culture graphics fall back -to vanilla `western_*_gfx` packs. No custom map data exists. +| Category | Done | Total | Notes | +|----------|------|-------|-------| +| Trait icons | 26 | 26 | **Complete.** All metallic arts traits. | +| Modifier icons | 42 | 53 | 21 base (M2) + 21 flavor (M7). 11 remaining. | +| Loading screens | 5 | 5 | **Complete.** | +| Event backgrounds | 16 | 16 | **Complete.** All scene classes covered. | +| Bookmark art | 3 | 6 | Background + 2 variants. 3 overlays remaining. | +| Decision illustrations | 0 | 10 | Not started. | +| CoA emblems | 0 | 13 | Not started. | +| Religion icons | 0 | 4 | Not started. | +| MaA icons | 0 | 5 | Not started. | +| Building icons | 0 | 5 | Not started. | +| Lifestyle assets | 0 | 45+ | Not started. | +| Activity assets | 0 | 8+ | Not started. | +| Scheme icons | 0 | 2 | Not started. | +| Custom map | 0 | 20+ | Not started. | +| Other | 0 | ~20 | Frontend, workshop thumbnail, portraits. | +| **Total** | **~92** | **~230+** | **~40% complete** | + +All culture graphics fall back to vanilla `western_*_gfx` packs. No custom +map data exists. --- diff --git a/docs/events-registry.md b/docs/events-registry.md index ce4783d..c17b19c 100644 --- a/docs/events-registry.md +++ b/docs/events-registry.md @@ -4,7 +4,10 @@ > new multi-event arcs, standalone one-shots, and artifact events. Referenced > from the milestone plan (M7 task 7.14). > -> **Status:** Proposed. None implemented yet. +> **Status:** Part A extensions partially implemented (A3 attention aftermath +> modifiers exist, A5/A6/A7 base events exist from M2). Part B and Part C are +> proposed for M7. All 21 flavor event modifier icons have been created. +> All 8 new event scene backgrounds have been created. --- diff --git a/lords_of_ash/REVIEW_NOTES.txt b/lords_of_ash/REVIEW_NOTES.txt index be3718e..c25ac71 100644 --- a/lords_of_ash/REVIEW_NOTES.txt +++ b/lords_of_ash/REVIEW_NOTES.txt @@ -1,7 +1,7 @@ ============================================================ MISTBORN: THE FINAL EMPIRE - CK3 MOD REVIEW REPORT ============================================================ -Reviewed: 2026-02-07 (updated) +Reviewed: 2026-02-08 (updated) Reviewer: Claude Code review against CK3 modding reference ============================================================ @@ -68,12 +68,11 @@ CRITICAL ISSUES (Game-breaking, will cause errors/crashes) WARNING ISSUES (Will not crash but may cause incorrect behavior) ============================================================ -WARNING-01: EMPTY CULTURE PILLAR DEFINITIONS +[RESOLVED] WARNING-01: EMPTY CULTURE PILLAR DEFINITIONS File: common/culture/pillars/00_scadrial_pillars.txt --- -heritage_scadrial, language_scadrial, and language_terris are defined -with empty blocks {}. CK3 may require certain fields (e.g. color) -in pillar definitions. Empty pillars may cause errors or be invisible. +Fixed. Pillars now have required color property and head_determination +field. All three cultures load correctly. WARNING-02: VANILLA DEPENDENCY - ETHOSES File: common/culture/cultures/00_scadrial_cultures.txt @@ -98,39 +97,33 @@ Cultures reference vanilla gfx sets (western_coa_gfx, etc.). Decisions reference vanilla illustration paths (decision_feast.dds, etc.). These break if vanilla assets are replaced. -WARNING-05: DUAL LORD RULER ATTENTION SYSTEMS +[RESOLVED] WARNING-05: DUAL LORD RULER ATTENTION SYSTEMS Files: scripted_effects, on_action --- -Two systems exist but are not connected: - 1. Variable-based: lord_ruler_attention variable (0-100), used by - on_actions for threshold checks and by scripted effects for - increment/decrement - 2. Modifier-based: lord_ruler_attention_modifier applied by events -The variable system works. The tiered modifiers (attention_1/2/3) -are now defined (CRITICAL-01 resolved). These two systems should be -unified into a single coherent approach. +Unified. Variable-based system (0-100) drives automatic tiered +modifiers (attention_1/2/3). Scripted effects handle increment/ +decrement and threshold transitions. Single coherent approach. -WARNING-06: is_feruchemist_trigger INCLUDES DORMANT POTENTIAL +[RESOLVED] WARNING-06: is_feruchemist_trigger INCLUDES DORMANT POTENTIAL File: common/scripted_triggers/mistborn_triggers.txt --- -is_feruchemist_trigger returns true for trait_feruchemy_potential -(dormant). If used for compounding checks or active-power logic, -this incorrectly matches unawakened characters. Use -is_full_feruchemist_trigger for active Feruchemists only. +Fixed. Triggers now correctly distinguish active vs dormant: +- is_feruchemist_trigger: only active Feruchemists +- is_full_feruchemist_trigger: same (active only) +- has_feruchemical_potential: dormant potential check -WARNING-07: has_allomantic_potential_trigger IS OVER-INCLUSIVE +[RESOLVED] WARNING-07: has_allomantic_potential_trigger IS OVER-INCLUSIVE File: common/scripted_triggers/mistborn_triggers.txt --- -has_allomantic_potential_trigger returns true for active Allomancers -(already snapped) in addition to dormant potential characters. Name -suggests "has potential" but matches anyone with Allomantic ability. -Could confuse future logic checking for unsnapped characters. +Fixed. Triggers correctly distinguish: +- is_allomancer_trigger: active Allomancers only +- has_allomantic_potential_trigger: dormant potential only -WARNING-08: RELIGION FAMILY DEFINITION -File: common/religion/religions/00_scadrial_religions.txt +[RESOLVED] WARNING-08: RELIGION FAMILY DEFINITION +File: common/religion/religion_families/00_scadrial_families.txt --- -Uses family = rf_scadrial. CK3 religion families are usually auto- -created from first usage but verify this works in version 1.12.*. +Fixed. Explicit religion family definition file created for +rf_scadrial. No longer relying on auto-creation. ============================================================ NOTE ISSUES (Style, completeness, lore accuracy) @@ -146,9 +139,9 @@ vanilla Western European names. Major immersion breaker. NOTE-02: NO MAP DATA Directory: map_data/ (missing) --- -Province IDs 1-105 are sequential placeholders. No custom map exists. -The mod relies on reusing vanilla map provinces, which will not match -the Final Empire geography. Custom map is a long-term goal. +Province IDs remapped to vanilla Swiss region (2030-3107). No custom +map exists. The mod reuses vanilla provinces, which do not match +Final Empire geography. Custom map planned for M8. NOTE-03: e_final_empire HAS NO HOLDER File: history/titles/00_mistborn_titles.txt @@ -188,13 +181,16 @@ Political structure: Dominances, locations all correct. Base 8 + Gold + Atium trait set is lore-accurate for this era. ============================================================ -SUMMARY +SUMMARY (updated 2026-02-08) ============================================================ CRITICAL issues: 0 (all 4 resolved) -WARNING issues: 8 (pillar defs, vanilla dependencies, dual systems, - trigger inclusiveness, religion family) -NOTE issues: 6 (name lists, map, empire holder, lore, coverage) +WARNING issues: 3 open of 8 (WARNING-02/03/04: vanilla dependencies) + 5 resolved (WARNING-01, 05, 06, 07, 08) +NOTE issues: 4 open of 6 (name lists, map, empire holder, lore) + 2 resolved/updated (NOTE-02 updated, NOTE-06 resolved) -All critical issues have been resolved. Next priority: WARNING-01 -(empty pillar definitions) and WARNING-05 (dual attention systems). +All critical and most warning issues resolved. Remaining warnings are +intentional vanilla dependencies (ethoses, traits, GFX) that will be +addressed in M4/M8. Next priority: NOTE-01 (custom name lists, M3) +and NOTE-03 (Lord Ruler character, M3).