From 0426174ed9a277a4ed7587c22232a39558ab71bd Mon Sep 17 00:00:00 2001 From: Jeroen Schweitzer Date: Sun, 8 Feb 2026 13:21:44 +0100 Subject: [PATCH] fix(loc): fix data function errors and opinion modifier collision - Removed invalid [ROOT.GetName] from ReligiousHeadTitleName keys across all 4 faiths plus fallback (ck3-tiger: Custom/GetName cannot follow a Scope promote) - Renamed disappointed_opinion to disappointed_by_snapping_opinion to avoid collision with vanilla opinion modifier of same name - Added loc keys for the renamed opinion modifier and guilty_about_snapping_opinion Co-Authored-By: Claude Opus 4.6 --- .../00_mistborn_opinion_modifiers.txt | 2 +- lords_of_ash/events/snapping_events.txt | 2 +- .../english/mistborn_decisions_l_english.yml | 2 ++ .../english/mistborn_religions_l_english.yml | 10 +++++----- 4 files changed, 9 insertions(+), 7 deletions(-) diff --git a/lords_of_ash/common/opinion_modifiers/00_mistborn_opinion_modifiers.txt b/lords_of_ash/common/opinion_modifiers/00_mistborn_opinion_modifiers.txt index 7e87763..506ae86 100644 --- a/lords_of_ash/common/opinion_modifiers/00_mistborn_opinion_modifiers.txt +++ b/lords_of_ash/common/opinion_modifiers/00_mistborn_opinion_modifiers.txt @@ -8,7 +8,7 @@ disapproves_skaa_mercy = { } # Father disappointed by snapping failure -disappointed_opinion = { +disappointed_by_snapping_opinion = { opinion = -15 } diff --git a/lords_of_ash/events/snapping_events.txt b/lords_of_ash/events/snapping_events.txt index 03d7134..3025d5f 100644 --- a/lords_of_ash/events/snapping_events.txt +++ b/lords_of_ash/events/snapping_events.txt @@ -458,7 +458,7 @@ mistborn_snapping.0030 = { root.father = { add_opinion = { target = root - modifier = disappointed_opinion + modifier = disappointed_by_snapping_opinion opinion = -15 } # If the child was injured during snapping, father feels guilt diff --git a/lords_of_ash/localization/english/mistborn_decisions_l_english.yml b/lords_of_ash/localization/english/mistborn_decisions_l_english.yml index 63c268a..5764be5 100644 --- a/lords_of_ash/localization/english/mistborn_decisions_l_english.yml +++ b/lords_of_ash/localization/english/mistborn_decisions_l_english.yml @@ -88,6 +88,8 @@ recruit_skaa_allomancer_safe_tt:0 "The recruitment goes unnoticed by the Steel Ministry." disapproves_skaa_mercy:0 "Disapproves of mercy toward skaa" + disappointed_by_snapping_opinion:0 "Disappointed by snapping failure" + guilty_about_snapping_opinion:0 "Feels guilty about snapping injury" acquire_metals_black_market_success_tt:0 "Metals acquired through the underground without drawing attention." acquire_metals_black_market_failure_tt:0 "The transaction was noticed — the Steel Ministry's attention increases." diff --git a/lords_of_ash/localization/english/mistborn_religions_l_english.yml b/lords_of_ash/localization/english/mistborn_religions_l_english.yml index 0d1804b..c8aa124 100644 --- a/lords_of_ash/localization/english/mistborn_religions_l_english.yml +++ b/lords_of_ash/localization/english/mistborn_religions_l_english.yml @@ -270,7 +270,7 @@ steel_ministry_GHWName:0 "Purge" steel_ministry_GHWNamePlural:0 "Purges" steel_ministry_ReligiousHeadName:0 "Lord Prelan" - steel_ministry_ReligiousHeadTitleName:0 "Lord Prelan [ROOT.Custom('GetName')]" + steel_ministry_ReligiousHeadTitleName:0 "Lord Prelan" steel_ministry_CreationMyth:0 "The Lord Ruler defeated the Deepness and remade the world" steel_ministry_DeathOpinionName:0 "Heresy against the Steel Ministry" steel_ministry_GoodAfterLife:0 "The Lord Ruler's Embrace" @@ -453,7 +453,7 @@ terris_worldbringers_ReligiousHead:0 "First Keeper" terris_worldbringers_ReligiousHeadName:0 "First Keeper" terris_worldbringers_ReligiousHeadTitle:0 "First Keeper" - terris_worldbringers_ReligiousHeadTitleName:0 "First Keeper [ROOT.Custom('GetName')]" + terris_worldbringers_ReligiousHeadTitleName:0 "First Keeper" terris_worldbringers_CreationMyth:0 "Preservation and Ruin shaped the world together" terris_worldbringers_DeathOpinionName:0 "Sacrilege against the Keepers" terris_worldbringers_GoodAfterLife:0 "Preservation's Embrace" @@ -630,7 +630,7 @@ survivorism_GHWName:0 "Great Uprising" survivorism_GHWNamePlural:0 "Great Uprisings" survivorism_ReligiousHeadName:0 "Voice of the Survivor" - survivorism_ReligiousHeadTitleName:0 "Voice of the Survivor [ROOT.Custom('GetName')]" + survivorism_ReligiousHeadTitleName:0 "Voice of the Survivor" survivorism_CreationMyth:0 "The Survivor escaped the Pits of Hathsin and showed the skaa that they could fight" survivorism_DeathOpinionName:0 "Betrayal of the Survivor's cause" survivorism_GoodAfterLife:0 "The Survivor's Rest" @@ -807,7 +807,7 @@ cult_of_ruin_GHWName:0 "Great Unmaking" cult_of_ruin_GHWNamePlural:0 "Great Unmakings" cult_of_ruin_ReligiousHeadName:0 "Herald of Ruin" - cult_of_ruin_ReligiousHeadTitleName:0 "Herald of Ruin [ROOT.Custom('GetName')]" + cult_of_ruin_ReligiousHeadTitleName:0 "Herald of Ruin" cult_of_ruin_CreationMyth:0 "Ruin shaped the world so that it might one day be destroyed" cult_of_ruin_DeathOpinionName:0 "Defiance of Ruin's will" cult_of_ruin_GoodAfterLife:0 "Ruin's Embrace" @@ -1050,4 +1050,4 @@ GHWName:0 "Purge" GHWNamePlural:0 "Purges" ReligiousHeadName:0 "Lord Prelan" - ReligiousHeadTitleName:0 "Lord Prelan [ROOT.Custom('GetName')]" + ReligiousHeadTitleName:0 "Lord Prelan"