============================================================
MISTBORN: THE FINAL EMPIRE - CK3 MOD REVIEW REPORT
============================================================
Reviewed: 2026-02-07 (updated)
Reviewer: Claude Code review against CK3 modding reference

============================================================
RESOLVED ISSUES (from previous review)
============================================================

[RESOLVED] CRITICAL-01/02: Trait name mismatches in triggers/effects
  Triggers and effects now correctly use trait_misting_* naming.

[RESOLVED] CRITICAL-03: Undefined traits referenced in triggers
  Triggers no longer reference non-existent Era 2 metals or
  undefined role traits. Only defined traits are used.

[RESOLVED] CRITICAL-04: Missing event namespaces
  All events referenced by decisions now exist:
  mistborn_hemalurgy.0001, mistborn_atium.0001/.0002,
  mistborn_skaa.0001/.0010, mistborn_skaa_allomancer.0001/.0002,
  mistborn_ball.0001, mistborn_snapping.0010.
  Note: hire_kandra_decision triggers mistborn_misc.0001 (not
  mistborn_kandra.0001 as previously reported).

[RESOLVED] CRITICAL-06: Missing trait_noble_scadrian in decision
  host_a_ball_decision now uses culture = culture:noble_scadrian
  instead of a non-existent trait.

[RESOLVED] WARNING-01: Kandra event flag mismatch
  hire_kandra_decision now sets hired_kandra flag in addition to
  kandra_contract_active and recently_hired_kandra.

[RESOLVED] WARNING-02: on_action naming inconsistency
  All files now use consistent trait_misting_* naming.

[RESOLVED] WARNING-05: Snapping decision targets wrong event
  subject_heir_to_snapping_decision now correctly triggers
  mistborn_snapping.0010 and saves scope:snapping_target.

[RESOLVED] NOTE-03: descriptor.mod path field
  Confirmed correct: inner descriptor omits path, outer has it.

============================================================
CRITICAL ISSUES (Game-breaking, will cause errors/crashes)
============================================================

[RESOLVED] CRITICAL-01: MISSING MODIFIER DEFINITIONS
  All 7 modifiers now defined in common/modifiers/00_mistborn_modifiers.txt:
  lord_ruler_attention_1/2/3, ruin_influence, steel_inquisitor_power,
  great_house_status, atium_supply.

[RESOLVED] CRITICAL-02: NO PROVINCE HISTORY FILES
  Province history created: history/provinces/00_mistborn_provinces.txt
  All 105 provinces have culture, religion, and holding assignments.

[RESOLVED] CRITICAL-03: NO BOOKMARK DEFINITIONS
  Bookmark created: common/bookmarks/00_mistborn_bookmarks.txt
  "The End of an Empire" bookmark at 1020.1.1 with 4 recommended
  characters (Venture, Hasting, Elariel, Lekal). Localization added
  in localization/english/mistborn_bookmarks_l_english.yml.

[RESOLVED] CRITICAL-04: @# COMMENT SYNTAX
  Fixed in 00_scadrial_religions.txt and 00_holy_sites.txt.
  Replaced @# with # for proper CK3 comments.

============================================================
WARNING ISSUES (Will not crash but may cause incorrect behavior)
============================================================

WARNING-01: EMPTY CULTURE PILLAR DEFINITIONS
File: common/culture/pillars/00_scadrial_pillars.txt
---
heritage_scadrial, language_scadrial, and language_terris are defined
with empty blocks {}. CK3 may require certain fields (e.g. color)
in pillar definitions. Empty pillars may cause errors or be invisible.

WARNING-02: VANILLA DEPENDENCY - ETHOSES
File: common/culture/cultures/00_scadrial_cultures.txt
---
Cultures reference vanilla ethoses: ethos_courtly, ethos_communal,
ethos_spiritual. If this becomes a full total conversion that
replaces vanilla content, these won't exist. Either keep vanilla
ethoses available or define custom replacements.

WARNING-03: VANILLA DEPENDENCY - TRAITS
File: history/characters/00_mistborn_characters.txt
---
Characters use vanilla personality and education traits (ambitious,
brave, callous, education_martial_2, etc.) and the create_steel_
inquisitor_effect uses vanilla trait "disfigured". These depend on
vanilla trait files remaining loaded.

WARNING-04: VANILLA DEPENDENCY - GFX
Files: cultures, decisions
---
Cultures reference vanilla gfx sets (western_coa_gfx, etc.).
Decisions reference vanilla illustration paths (decision_feast.dds,
etc.). These break if vanilla assets are replaced.

WARNING-05: DUAL LORD RULER ATTENTION SYSTEMS
Files: scripted_effects, on_action
---
Two systems exist but are not connected:
  1. Variable-based: lord_ruler_attention variable (0-100), used by
     on_actions for threshold checks and by scripted effects for
     increment/decrement
  2. Modifier-based: lord_ruler_attention_modifier applied by events
The variable system works. The tiered modifiers (attention_1/2/3)
are now defined (CRITICAL-01 resolved). These two systems should be
unified into a single coherent approach.

WARNING-06: is_feruchemist_trigger INCLUDES DORMANT POTENTIAL
File: common/scripted_triggers/mistborn_triggers.txt
---
is_feruchemist_trigger returns true for trait_feruchemy_potential
(dormant). If used for compounding checks or active-power logic,
this incorrectly matches unawakened characters. Use
is_full_feruchemist_trigger for active Feruchemists only.

WARNING-07: has_allomantic_potential_trigger IS OVER-INCLUSIVE
File: common/scripted_triggers/mistborn_triggers.txt
---
has_allomantic_potential_trigger returns true for active Allomancers
(already snapped) in addition to dormant potential characters. Name
suggests "has potential" but matches anyone with Allomantic ability.
Could confuse future logic checking for unsnapped characters.

WARNING-08: RELIGION FAMILY DEFINITION
File: common/religion/religions/00_scadrial_religions.txt
---
Uses family = rf_scadrial. CK3 religion families are usually auto-
created from first usage but verify this works in version 1.12.*.

============================================================
NOTE ISSUES (Style, completeness, lore accuracy)
============================================================

NOTE-01: MISSING CUSTOM NAME LISTS
File: common/culture/cultures/00_scadrial_cultures.txt
---
name_list_scadrial_noble, name_list_scadrial_skaa, and
name_list_terris are referenced but marked TODO. Characters will get
vanilla Western European names. Major immersion breaker.

NOTE-02: NO MAP DATA
Directory: map_data/ (missing)
---
Province IDs 1-105 are sequential placeholders. No custom map exists.
The mod relies on reusing vanilla map provinces, which will not match
the Final Empire geography. Custom map is a long-term goal.

NOTE-03: e_final_empire HAS NO HOLDER
File: history/titles/00_mistborn_titles.txt
---
The empire title is never assigned. The Lord Ruler is mentioned in
comments but not defined as a character. The empire is vacant at
game start. Consider creating a Lord Ruler character (non-playable)
or assigning a regent.

NOTE-04: TERRIS DYNASTY ASSIGNMENTS (LORE)
File: history/characters/00_mistborn_characters.txt
---
Telden (900080) = dynasty_venture, Kwaan (900081) = dynasty_elariel,
Vedzan (900082) = dynasty_tekiel. Terris stewards served noble houses
but were not dynasty members. Consider a "Terris Stewards" dynasty
or removing dynasty assignment.

NOTE-05: CANONICAL NAME REUSE
File: history/characters/00_mistborn_characters.txt
---
"Kwaan" is a canonical Mistborn character (historical Terris
Worldbringer). Using canonical names for original characters may
confuse players familiar with the books. Consider renaming.

NOTE-06: LOCALIZATION COVERAGE
---
All defined game content has matching localization keys. Localization
files are correctly encoded as UTF-8 with BOM. File naming follows
the _l_english.yml convention.

============================================================
LORE ACCURACY (unchanged from previous review)
============================================================

Metal/Misting assignments: All correct for Final Empire era.
Political structure: Dominances, locations all correct.
Base 8 + Gold + Atium trait set is lore-accurate for this era.

============================================================
SUMMARY
============================================================

CRITICAL issues: 0 (all 4 resolved)
WARNING issues:  8 (pillar defs, vanilla dependencies, dual systems,
                     trigger inclusiveness, religion family)
NOTE issues:     6 (name lists, map, empire holder, lore, coverage)

All critical issues have been resolved. Next priority: WARNING-01
(empty pillar definitions) and WARNING-05 (dual attention systems).
