Files
clide/test/builtin/theme_picker/widget_test.dart
T
jpmschweitzerandClaude Opus 4.8 5fcc42bd8c tidy the theme switcher popover (T-237)
Per demo feedback on the T-234 status-bar popover: collapse the -hc
theme rows into a single 'High contrast' toggle at the top (applies the
chosen base theme's -hc sibling live, falling back to the base when none
exists); list base themes only, sorted by display name; widen 240->280
and ellipsize rows so 'Catppuccin Mocha' no longer wraps; swap the swatch
dot for the Phosphor palette icon; lowercase the bar label to match the
all-lowercase status bar (proper case kept in the a11y label).

New pure theme_families helpers (base/sibling/resolve), unit-tested.
Modal picker_view consistency + the status-bar right-alignment remain on
T-237.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-03 22:46:17 +02:00

202 lines
7.7 KiB
Dart

import 'package:clide/builtin/theme_picker/src/theme_status_item.dart';
import 'package:clide/builtin/theme_picker/theme_picker.dart';
import 'package:clide/extension/extension.dart';
import 'package:clide/kernel/kernel.dart';
import 'package:flutter/services.dart';
import 'package:flutter/widgets.dart';
import 'package:flutter_test/flutter_test.dart';
import '../../helpers/kernel_fixture.dart';
import '../../helpers/widget_harness.dart';
ThemeDefinition _def(String name) => ThemeDefinition(
name: name,
displayName: name,
dark: true,
palette: Palette(const {
'primary': Color(0xFF00A3D2),
'accent': Color(0xFFFA5F8B),
'background': Color(0xFF21262F),
'surface': Color(0xFF393E48),
'panel': Color(0xFF292E38),
'foreground': Color(0xFFE2E8F5),
'success': Color(0xFF00AB9A),
'warning': Color(0xFFD08447),
'error': Color(0xFFF06C6F),
}),
);
void main() {
group('ThemePickerExtension', () {
late KernelFixture f;
setUp(() async {
f = await KernelFixture.create(
bundledThemes: [_def('summer-night'), _def('forest')],
i18nCatalogs: {
'builtin.theme-picker': {
const Locale('en', 'US'): const {
'modal.title': {'translation': 'Select theme'},
'modal.cancel': {'translation': 'Cancel'},
'modal.cancel.hint': {'translation': 'Dismiss'},
'row.select.hint': {'translation': 'Activate this theme'},
},
},
},
);
});
tearDown(() async => f.dispose());
test('contributes a theme.pick command', () async {
f.services.extensions.register(ThemePickerExtension());
await f.services.extensions.activateAll();
expect(f.services.commands.get('theme.pick'), isNotNull);
});
test('default binding ctrl+k is registered', () async {
f.services.extensions.register(ThemePickerExtension());
await f.services.extensions.activateAll();
expect(
f.services.keybindings.commandFor(Keybinding.parse('ctrl+k')),
'theme.pick',
);
});
testWidgets('modal lists every bundled theme', (tester) async {
await tester.pumpWidget(
harness(
f,
ThemePickerView(
controller: f.services.theme,
onDismiss: ([_]) {},
),
),
);
// Each row renders both displayName and name; displayName==name in
// test fixtures so the label appears twice per row.
expect(find.text('summer-night'), findsNWidgets(2));
expect(find.text('forest'), findsNWidgets(2));
expect(find.text('Select theme'), findsOneWidget);
expect(find.text('Cancel'), findsOneWidget);
});
testWidgets('tapping a row calls controller.select + onDismiss', (tester) async {
String? dismissed;
await tester.pumpWidget(
harness(
f,
ThemePickerView(
controller: f.services.theme,
onDismiss: ([v]) => dismissed = v,
),
),
);
await tester.tap(find.bySemanticsLabel('forest'));
await tester.pumpAndSettle();
expect(f.services.theme.currentName, 'forest');
expect(dismissed, 'forest');
});
testWidgets('Cancel button dismisses without selecting', (tester) async {
String? dismissed = 'not-called';
await tester.pumpWidget(
harness(
f,
ThemePickerView(
controller: f.services.theme,
onDismiss: ([v]) => dismissed = v,
),
),
);
await tester.tap(find.bySemanticsLabel('Cancel'));
await tester.pumpAndSettle();
expect(dismissed, isNull);
});
testWidgets('status switcher shows the active theme and opens a popover (T-234)', (tester) async {
await tester.pumpWidget(harness(f, const ThemeSwitcherStatusItem()));
await tester.pump();
// Controller starts on the first bundled theme.
expect(f.services.theme.currentName, 'summer-night');
expect(find.text('summer-night'), findsOneWidget);
// Open the popover; it lists every theme (the other one appears).
await tester.tap(find.bySemanticsLabel('Theme: summer-night'));
await tester.pumpAndSettle();
expect(find.text('forest'), findsOneWidget);
});
testWidgets('selecting in the popover applies live and closes (T-234)', (tester) async {
await tester.pumpWidget(harness(f, const ThemeSwitcherStatusItem()));
await tester.pump();
await tester.tap(find.bySemanticsLabel('Theme: summer-night'));
await tester.pumpAndSettle();
await tester.tap(find.bySemanticsLabel('forest'));
await tester.pumpAndSettle();
expect(f.services.theme.currentName, 'forest'); // applied live
// Popover closed: the only 'forest' left is the trigger label.
expect(find.bySemanticsLabel('forest'), findsNothing);
});
testWidgets('popover hides -hc rows; the High contrast toggle applies the sibling (T-237)', (tester) async {
final f2 = await KernelFixture.create(bundledThemes: [_def('midnight'), _def('midnight-hc')]);
addTearDown(f2.dispose);
await tester.pumpWidget(harness(f2, const ThemeSwitcherStatusItem()));
await tester.pump();
await tester.tap(find.bySemanticsLabel('Theme: midnight'));
await tester.pumpAndSettle();
// Base shown, -hc row hidden, toggle present.
expect(find.text('midnight'), findsOneWidget);
expect(find.text('midnight-hc'), findsNothing);
expect(find.text('High contrast'), findsOneWidget);
// Toggling high contrast applies the -hc sibling live.
await tester.tap(find.bySemanticsLabel('High contrast'));
await tester.pumpAndSettle();
expect(f2.services.theme.currentName, 'midnight-hc');
});
testWidgets('Esc dismisses the popover without changing the theme (T-234)', (tester) async {
await tester.pumpWidget(harness(f, const ThemeSwitcherStatusItem()));
await tester.pump();
await tester.tap(find.bySemanticsLabel('Theme: summer-night'));
await tester.pumpAndSettle();
expect(find.text('forest'), findsOneWidget);
await tester.sendKeyEvent(LogicalKeyboardKey.escape);
await tester.pumpAndSettle();
expect(find.text('forest'), findsNothing); // popover gone
expect(f.services.theme.currentName, 'summer-night'); // unchanged
});
test('_pick before activate returns a not-activated error', () async {
// Reach the command's run callback without going through activate —
// _ctx is still null, so _pick hits the defensive error branch.
final ext = ThemePickerExtension();
final cmd = ext.contributions.whereType<CommandContribution>().single;
final resp = await cmd.run(const []);
expect(resp.ok, isFalse);
expect(resp.error?.message, contains('not activated'));
});
testWidgets('_pick (after activate) opens a dialog and resolves the user selection', (tester) async {
f.services.extensions.register(ThemePickerExtension());
await f.services.extensions.activateAll();
// Pump a tree so dialog has a parent BuildContext to render under.
await tester.pumpWidget(harness(f, const SizedBox()));
await tester.pump();
// Kick off the command. _pick awaits ctx.dialog.show; the future
// resolves once dialog is dismissed.
final responseFuture = f.services.commands.execute('theme.pick');
await tester.pump();
expect(f.services.dialog.isOpen, isTrue);
// Simulate user picking 'forest' and closing.
f.services.dialog.dismiss('forest');
final resp = await responseFuture;
expect(resp.ok, isTrue);
expect(resp.data['selected'], 'forest');
});
});
}