jpmschweitzerandClaude Opus 4.8
0eb7b0df2f
Two reveal-on-open bugs: Decisions opened only on the second click (T-196): the detail view subscribed in didChangeDependencies, which runs after the tab is revealed, so the broadcast 'selection' that triggered the reveal was already gone. Hoist the back/forward history out of per-view State into a retained per-reader ReaderNav (kernel ChangeNotifier in a ReaderNavRegistry, D-81). The nav records selections, emits 'load' (the single channel readers display from), and survives mount/unmount — the reader grabs nav.current on mount, so the first selection lands. Both the markdown and decisions readers move to this model; the per-view ReaderHistoryMixin and the markdown post-frame forward hack are gone. The editor pane never opened (T-197): EditorExtension contributed a workspace tab but nothing activated it on editor.open. Add an activate() that reveals the tab on editor.opened / editor.active-changed; the view's hydrate() pulls the active buffer on mount. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
76 lines
3.1 KiB
Dart
76 lines
3.1 KiB
Dart
/// T-197: EditorExtension reveals its workspace tab when a buffer opens.
|
|
///
|
|
/// `editor.open` opens the buffer daemon-side and emits `editor.opened`,
|
|
/// but nothing else brings the editor tab to front over the Claude
|
|
/// pane. The extension's activate() listens for the editor lifecycle
|
|
/// events and activates the workspace tab.
|
|
library;
|
|
|
|
import 'package:clide/builtin/editor/src/extension.dart';
|
|
import 'package:clide/extension/extension.dart' show TabContribution;
|
|
import 'package:clide/kernel/kernel.dart';
|
|
import 'package:flutter/widgets.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
|
|
import '../../helpers/kernel_fixture.dart';
|
|
|
|
void main() {
|
|
late KernelFixture f;
|
|
|
|
setUp(() async {
|
|
f = await KernelFixture.create();
|
|
f.services.panels.registerSlot(const SlotDefinition(id: Slots.workspace, position: SlotPosition.center));
|
|
// A pre-existing workspace tab so 'editor.active' is NOT the default
|
|
// active tab — the reveal must switch to it explicitly.
|
|
f.services.panels.contribute(TabContribution(
|
|
id: 'claude.primary',
|
|
slot: Slots.workspace,
|
|
title: 'Claude',
|
|
build: (_) => const SizedBox(),
|
|
));
|
|
f.services.extensions.register(EditorExtension());
|
|
await f.services.extensions.activate('builtin.editor');
|
|
});
|
|
tearDown(() => f.dispose());
|
|
|
|
void emitEditor(String kind, {String? id}) {
|
|
f.services.events.emit(DaemonEvent(subsystem: 'editor', kind: kind, data: {'id': id}, ts: DateTime.now().toUtc()));
|
|
}
|
|
|
|
test('contributes editor.active but leaves Claude active by default', () {
|
|
expect(f.services.panels.tabsFor(Slots.workspace).any((t) => t.id == 'editor.active'), isTrue);
|
|
expect(f.services.panels.activeTabIn(Slots.workspace), 'claude.primary');
|
|
});
|
|
|
|
test('editor.opened reveals (activates) the editor tab', () async {
|
|
emitEditor('editor.opened', id: 'b_1');
|
|
await Future<void>.delayed(Duration.zero);
|
|
expect(f.services.panels.activeTabIn(Slots.workspace), 'editor.active');
|
|
});
|
|
|
|
test('editor.active-changed also reveals the editor tab', () async {
|
|
emitEditor('editor.active-changed', id: 'b_2');
|
|
await Future<void>.delayed(Duration.zero);
|
|
expect(f.services.panels.activeTabIn(Slots.workspace), 'editor.active');
|
|
});
|
|
|
|
test('a non-editor event leaves the active tab unchanged', () async {
|
|
f.services.events.emit(DaemonEvent(subsystem: 'git', kind: 'changed', data: const {}, ts: DateTime.now().toUtc()));
|
|
await Future<void>.delayed(Duration.zero);
|
|
expect(f.services.panels.activeTabIn(Slots.workspace), 'claude.primary');
|
|
});
|
|
|
|
test('an unrelated editor event kind does not reveal', () async {
|
|
emitEditor('editor.saved', id: 'b_1');
|
|
await Future<void>.delayed(Duration.zero);
|
|
expect(f.services.panels.activeTabIn(Slots.workspace), 'claude.primary');
|
|
});
|
|
|
|
test('after deactivate, editor events no longer reveal', () async {
|
|
await f.services.extensions.deactivate('builtin.editor');
|
|
emitEditor('editor.opened', id: 'b_9');
|
|
await Future<void>.delayed(Duration.zero);
|
|
expect(f.services.panels.activeTabIn(Slots.workspace), isNot('editor.active'));
|
|
});
|
|
}
|