jpmschweitzerandClaude Opus 4.8
61b969d010
T-207, first foundation piece of the Vim layer (T-65 epic). A
VimModeService (ChangeNotifier) owns the normal/insert/visual mode and
mirrors it into the keymap as mutually-exclusive vim.normal/vim.insert/
vim.visual scope flags. Those flags are the public mode interface: the
editor (T-206) will read them to decide insert-vs-command, and vim.yaml
(T-65) guards bindings with `when: vim.*`. Nothing reaches across the
builtin boundary into the service object.
The layer is gated on the active preset — the builtin.vim extension
ties VimModeService.enabled to app.keymap.preset and re-checks on every
keymap reload, so i/v/Esc never hijack input under non-Vim presets. Mode
commands (vim.mode.{normal,insert,visual}) carry no default binding for
the same reason; only vim.yaml binds keys to them. A status-bar item
shows `-- NORMAL --` etc. while enabled.
Exposes KeymapService on the extension context so the layer can publish
scope flags.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
81 lines
2.6 KiB
Dart
81 lines
2.6 KiB
Dart
/// T-207: the Vim extension enables its layer only under the `vim` preset,
|
|
/// registers mode-transition commands (no global bindings), and drives the
|
|
/// mode through those commands.
|
|
library;
|
|
|
|
import 'package:clide/builtin/vim/vim.dart';
|
|
import 'package:clide/extension/extension.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
|
|
import '../../helpers/kernel_fixture.dart';
|
|
|
|
void main() {
|
|
late KernelFixture f;
|
|
late VimExtension ext;
|
|
|
|
setUp(() async {
|
|
f = await KernelFixture.create();
|
|
ext = VimExtension();
|
|
f.services.extensions.register(ext);
|
|
});
|
|
tearDown(() => f.dispose());
|
|
|
|
bool flag(String name) => f.services.keymap.scope[name] ?? false;
|
|
|
|
test('inert under the default preset', () async {
|
|
await f.services.extensions.activate('builtin.vim');
|
|
expect(ext.modeService!.enabled, isFalse);
|
|
expect(flag('vim.normal'), isFalse);
|
|
});
|
|
|
|
test('enables when the vim preset is active', () async {
|
|
await f.services.keymap.setPreset('vim');
|
|
await f.services.extensions.activate('builtin.vim');
|
|
expect(ext.modeService!.enabled, isTrue);
|
|
expect(flag('vim.normal'), isTrue);
|
|
});
|
|
|
|
test('follows a live preset switch', () async {
|
|
await f.services.extensions.activate('builtin.vim');
|
|
expect(ext.modeService!.enabled, isFalse);
|
|
|
|
await f.services.keymap.setPreset('vim');
|
|
expect(ext.modeService!.enabled, isTrue);
|
|
|
|
await f.services.keymap.setPreset('default');
|
|
expect(ext.modeService!.enabled, isFalse);
|
|
expect(flag('vim.normal'), isFalse);
|
|
});
|
|
|
|
test('mode commands drive the scope flags', () async {
|
|
await f.services.keymap.setPreset('vim');
|
|
await f.services.extensions.activate('builtin.vim');
|
|
|
|
await f.services.commands.execute('vim.mode.insert');
|
|
expect(flag('vim.insert'), isTrue);
|
|
expect(flag('vim.normal'), isFalse);
|
|
|
|
await f.services.commands.execute('vim.mode.normal');
|
|
expect(flag('vim.normal'), isTrue);
|
|
expect(flag('vim.insert'), isFalse);
|
|
});
|
|
|
|
test('mode commands carry no default binding', () {
|
|
final cmds = ext.contributions.whereType<CommandContribution>();
|
|
expect(cmds, isNotEmpty);
|
|
expect(cmds.every((c) => c.defaultBinding == null), isTrue);
|
|
});
|
|
|
|
test('deactivate clears flags and disables the layer', () async {
|
|
await f.services.keymap.setPreset('vim');
|
|
await f.services.extensions.activate('builtin.vim');
|
|
await f.services.commands.execute('vim.mode.insert');
|
|
expect(flag('vim.insert'), isTrue);
|
|
|
|
final svc = ext.modeService!;
|
|
await f.services.extensions.deactivate('builtin.vim');
|
|
expect(svc.enabled, isFalse);
|
|
expect(flag('vim.insert'), isFalse);
|
|
});
|
|
}
|