jpmschweitzerandClaude
7c2eae42f1
test / unit + widget + golden + a11y (push) Failing after 31s
test / integration_test (xvfb) (push) Has been skipped
test / bundle smoke (xvfb 5s) (push) Has been skipped
test / daemon subprocess + web WASM smoke (push) Has been skipped
test / dart doc (lib API) (push) Failing after 1m1s
The test was awaiting services.commands.execute('theme.pick') whose
Future doesn't complete until the dialog is dismissed — deadlock.
Fire-and-forget around pumpAndSettle, then tap Cancel, then await
the original future. Also tear the widget tree down before
services.dispose() so listening widgets unsubscribe first.
Pre-existing layout overflow in the welcome _StatusLine surfaced
when running the test at narrower viewports. Switched to a whole-
row FittedBox(scaleDown) — uniform shrink on narrow screens, no-op
at standard widths.
User flagged the hardcoded 'clide 2.0.0-dev' string. Replaced with
one generated lib/src/build_info.g.dart (gitignored, regenerated
by `make gen-build-info` from pubspec.yaml + git short SHA + UTC
clock). The same target re-syncs assets/licenses.yaml self.version
in place — no second source. Every make build/run/test depends on
it implicitly. Welcome status line now reads `clideVersion`. Stale
fontSize literals in welcome_view swept to typography constants;
clideFontMeta=13, clideFontDialogTitle=16, clideFontWelcomeBanner=52
added to fill gaps in the scale.
Co-Authored-By: Claude <noreply@anthropic.com>
88 lines
3.2 KiB
Dart
88 lines
3.2 KiB
Dart
/// Typography constants shared across widgets.
|
|
///
|
|
/// Two bundled families:
|
|
///
|
|
/// - [clideUiFamily] — Josefin Sans, the application-wide UI face.
|
|
/// Shipped as a variable font (weights 100-700) + italic companion;
|
|
/// default weight is [clideUiDefaultWeight] (Light / `w300`).
|
|
/// - [clideMonoFamily] — JetBrains Mono, for terminal panes, diff
|
|
/// views, code editors, and any other monospace surface.
|
|
///
|
|
/// Fallback chains exist for web builds + harnesses where the bundled
|
|
/// asset isn't picked up (rare, but possible during `flutter test` if
|
|
/// asset fonts aren't declared in the harness).
|
|
library;
|
|
|
|
import 'package:flutter/widgets.dart' show FontWeight;
|
|
|
|
// ---------------------------------------------------------------------------
|
|
// UI face — Josefin Sans
|
|
// ---------------------------------------------------------------------------
|
|
|
|
/// The bundled application UI family. Always resolved first.
|
|
const String clideUiFamily = 'JosefinSans';
|
|
|
|
/// Default weight for UI text. Josefin Sans reads well at Light; the
|
|
/// rest of the design adjusts contrast and size to stay legible.
|
|
const FontWeight clideUiDefaultWeight = FontWeight.w300;
|
|
|
|
/// System fallback chain for the UI face. Sans-serif humanist faces
|
|
/// that sit close to Josefin's proportions, ordered by platform.
|
|
const List<String> clideUiFamilyFallback = [
|
|
// User system install of Josefin, if any.
|
|
'Josefin Sans',
|
|
// Platform humanist sans defaults.
|
|
'Inter',
|
|
'Helvetica Neue',
|
|
'Helvetica',
|
|
'Arial',
|
|
'sans-serif',
|
|
];
|
|
|
|
// ---------------------------------------------------------------------------
|
|
// Monospace face — JetBrains Mono
|
|
// ---------------------------------------------------------------------------
|
|
|
|
/// The bundled monospace family. Always resolved first.
|
|
const String clideMonoFamily = 'JetBrainsMono';
|
|
|
|
// ---------------------------------------------------------------------------
|
|
// Type scale — semantic sizes. Widgets inherit from the ambient
|
|
// DefaultTextStyle (set at the app root). Only override when the
|
|
// semantic role genuinely differs from body text. Prefer these
|
|
// constants over bare numbers so the scale stays coherent.
|
|
// ---------------------------------------------------------------------------
|
|
|
|
const double clideFontBody = 15;
|
|
const double clideFontCaption = 14;
|
|
const double clideFontMono = 14;
|
|
const double clideFontMeta = 13;
|
|
const double clideFontSmall = 12;
|
|
const double clideFontBadge = 11;
|
|
// Larger semantic sizes that aren't body text. clideFontDialogTitle is
|
|
// the modal/dialog heading; clideFontWelcomeBanner is the oversized
|
|
// "clide" mark on the welcome screen — one-off but worth naming.
|
|
const double clideFontDialogTitle = 16;
|
|
const double clideFontWelcomeBanner = 52;
|
|
const double clideLineHeight = 1.25;
|
|
|
|
/// System fallback chain. Ordered by platform prevalence + quality of
|
|
/// programming-ligature / box-drawing coverage.
|
|
const List<String> clideMonoFamilyFallback = [
|
|
// macOS
|
|
'SF Mono',
|
|
'Menlo',
|
|
'Monaco',
|
|
// Linux — user system install under the canonical PostScript name
|
|
'JetBrains Mono',
|
|
'Fira Code',
|
|
'Hack',
|
|
'DejaVu Sans Mono',
|
|
'Liberation Mono',
|
|
// Windows
|
|
'Cascadia Code',
|
|
'Consolas',
|
|
// Last resort
|
|
'monospace',
|
|
];
|