jpmschweitzerandClaude Opus 4.8
e0fba4a3bc
A custom in-window menu bar in the hat (no native menu, D-7), built from the command registry so it stays in sync and satisfies D-6 parity. - Menu model + hybrid resolver (menu_model.dart): a curated File/View/Help tree where a MenuAutoFill node sweeps in unplaced view.* commands; titles + keybindings come from the registry/keymap; unregistered or enabledWhen-false items render disabled (greyed), never hidden. - Widgets: MenuBar row in the hat (chrome tokens), anchored MenuDropdown overlay (dropdown tokens), two-column MenuItemRow with inline keybinding. - Full keyboard: Alt+mnemonic opens (hook in _RootShell._onKey), arrows navigate, Enter activates, Esc closes, Left/Right switch menus. - Commands: file.openFolder / file.newWindow / file.closeWorkspace / help.about, registered by MenuBarExtension(services:). File logic lifted out of the project switcher into FileActions (one source of truth; the switcher now dispatches the commands). Ctrl+O / Ctrl+Shift+N are now real keybindings in default.yaml. - Help → About: version/commit/date/repo from build-info + the bundled dependency licenses parsed from assets/licenses.yaml. Edit/Selection menus are deferred to T-271/T-272 (need focused-surface command routing). Tests: resolver + controller + licenses parse (pure); menu-bar widget (open/close/execute/disabled/Esc/arrow/Enter/Left-Right); FileActions + Open dialog; app-level Alt+F, non-repo dialog, and closeWorkspace. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
93 lines
3.3 KiB
Dart
93 lines
3.3 KiB
Dart
import 'package:clide/clide.dart' show IpcResponse;
|
|
import 'package:clide/extension/extension.dart';
|
|
import 'package:clide/kernel/kernel.dart';
|
|
|
|
import 'about_dialog.dart';
|
|
import 'file_actions.dart';
|
|
import 'menu_model.dart';
|
|
|
|
/// Application-menu extension (T-48). Registers the File/Help commands the menu
|
|
/// bar invokes (View commands already exist elsewhere) and owns the curated
|
|
/// menu tree. Constructed with [KernelServices] — like `ViewExtension` — because
|
|
/// the File actions need window/project/panels/dialog, which the extension
|
|
/// context doesn't expose.
|
|
class MenuBarExtension extends ClideExtension {
|
|
MenuBarExtension({required this.services});
|
|
|
|
final KernelServices services;
|
|
late final FileActions _file = FileActions(services);
|
|
|
|
@override
|
|
String get id => 'builtin.menubar';
|
|
@override
|
|
String get title => 'Application Menu';
|
|
@override
|
|
String get version => '0.1.0';
|
|
|
|
@override
|
|
List<ContributionPoint> get contributions => [
|
|
CommandContribution(
|
|
id: 'file.openFolder',
|
|
command: 'file.openFolder',
|
|
title: 'File: Open Folder…',
|
|
run: (_) async {
|
|
await _file.openFolder();
|
|
return IpcResponse.ok(id: '', data: const {});
|
|
},
|
|
),
|
|
CommandContribution(
|
|
id: 'file.newWindow',
|
|
command: 'file.newWindow',
|
|
title: 'File: New Window',
|
|
run: (_) async {
|
|
_file.newWindow();
|
|
return IpcResponse.ok(id: '', data: const {});
|
|
},
|
|
),
|
|
CommandContribution(
|
|
id: 'file.closeWorkspace',
|
|
command: 'file.closeWorkspace',
|
|
title: 'File: Close Project',
|
|
run: (_) async {
|
|
_file.closeWorkspace();
|
|
return IpcResponse.ok(id: '', data: const {});
|
|
},
|
|
),
|
|
CommandContribution(
|
|
id: 'help.about',
|
|
command: 'help.about',
|
|
title: 'Help: About clide',
|
|
run: (_) async {
|
|
services.dialog.show<Object>((ctx, dismiss) => AboutDialog(onDismiss: () => dismiss()));
|
|
return IpcResponse.ok(id: '', data: const {});
|
|
},
|
|
),
|
|
];
|
|
}
|
|
|
|
/// The curated File / View / Help tree (T-48). View ends with a `view.*`
|
|
/// auto-fill so newly-registered view commands surface without edits here.
|
|
List<TopMenu> buildClideMenuTree() => [
|
|
TopMenu(title: 'File', mnemonic: 0, nodes: [
|
|
const MenuCommandItem('file.openFolder', fallbackTitle: 'Open Folder…'),
|
|
const MenuCommandItem('file.newWindow', fallbackTitle: 'New Window'),
|
|
const MenuSeparator(),
|
|
MenuCommandItem('file.closeWorkspace', fallbackTitle: 'Close Project', enabledWhen: (s) => s.project.isOpen),
|
|
]),
|
|
TopMenu(title: 'View', mnemonic: 0, nodes: const [
|
|
MenuCommandItem('view.zoomIn'),
|
|
MenuCommandItem('view.zoomOut'),
|
|
MenuCommandItem('view.zoomReset'),
|
|
MenuSeparator(),
|
|
MenuCommandItem('sidebar.collapse'),
|
|
MenuCommandItem('context.collapse'),
|
|
MenuCommandItem('dock.toggle'),
|
|
MenuCommandItem('panel.focusMode'),
|
|
MenuSeparator(),
|
|
MenuAutoFill('view.'),
|
|
]),
|
|
TopMenu(title: 'Help', mnemonic: 0, nodes: const [
|
|
MenuCommandItem('help.about', fallbackTitle: 'About clide'),
|
|
]),
|
|
];
|