Raise the declared minimums in pubspec.yaml to what our deps already require: Flutter >=3.35.0 / Dart >=3.9.0 (was 3.19.0 / 3.5.0). alchemist 0.12 needs Flutter 3.32; Dart 3.9 first ships in Flutter 3.35, so 3.35 is the binding floor. Pin the exact build toolchain in .fvmrc (Flutter 3.44.1). Moving to the Dart 3.9 language level switches `dart format` to the new "tall" style and enables two new lints. This commit is the resulting mechanical churn, isolated from any behaviour change: - whole-tree `dart format` reformat (tall style) - `dart fix` for unnecessary_underscores + use_null_aware_elements No runtime behaviour change; `make test` green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
167 lines
6.2 KiB
Dart
167 lines
6.2 KiB
Dart
/// Tests for ClideAnchoredOverlay (D-88): controller-driven insert/remove,
|
|
/// barrier + Escape dismissal, centered mode, and clean dispose.
|
|
library;
|
|
|
|
import 'package:clide/widgets/widgets.dart';
|
|
import 'package:flutter/services.dart';
|
|
import 'package:flutter/widgets.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
|
|
import '../../helpers/kernel_fixture.dart';
|
|
import '../../helpers/widget_harness.dart';
|
|
|
|
void main() {
|
|
group('ClideAnchoredOverlay', () {
|
|
late KernelFixture f;
|
|
setUp(() async => f = await KernelFixture.create());
|
|
tearDown(() async => f.dispose());
|
|
|
|
Widget host(ClideOverlayController c, ValueNotifier<bool> present, {bool barrier = true, bool centered = false}) {
|
|
return harness(
|
|
f,
|
|
ValueListenableBuilder<bool>(
|
|
valueListenable: present,
|
|
builder: (_, show, _) => show
|
|
? Align(
|
|
alignment: Alignment.center,
|
|
child: ClideAnchoredOverlay(
|
|
controller: c,
|
|
barrier: barrier,
|
|
centered: centered,
|
|
autoFlip: false,
|
|
anchor: const SizedBox(width: 60, height: 24, child: ClideText('anchor')),
|
|
overlayBuilder: (_, _) => const SizedBox(width: 120, height: 60, child: ClideText('panel')),
|
|
),
|
|
)
|
|
: const SizedBox.shrink(),
|
|
),
|
|
);
|
|
}
|
|
|
|
testWidgets('open inserts the panel; close removes it', (tester) async {
|
|
final c = ClideOverlayController();
|
|
addTearDown(c.dispose);
|
|
await tester.pumpWidget(host(c, ValueNotifier(true)));
|
|
expect(find.text('panel'), findsNothing);
|
|
c.open();
|
|
await tester.pump();
|
|
expect(find.text('panel'), findsOneWidget);
|
|
c.close();
|
|
await tester.pump();
|
|
expect(find.text('panel'), findsNothing);
|
|
});
|
|
|
|
testWidgets('barrier tap closes', (tester) async {
|
|
final c = ClideOverlayController();
|
|
addTearDown(c.dispose);
|
|
await tester.pumpWidget(host(c, ValueNotifier(true)));
|
|
c.open();
|
|
await tester.pump();
|
|
await tester.tapAt(const Offset(2, 2));
|
|
await tester.pump();
|
|
expect(c.isOpen, isFalse);
|
|
expect(find.text('panel'), findsNothing);
|
|
});
|
|
|
|
testWidgets('Escape closes', (tester) async {
|
|
final c = ClideOverlayController();
|
|
addTearDown(c.dispose);
|
|
await tester.pumpWidget(host(c, ValueNotifier(true)));
|
|
c.open();
|
|
await tester.pump();
|
|
await tester.sendKeyEvent(LogicalKeyboardKey.escape);
|
|
await tester.pump();
|
|
expect(c.isOpen, isFalse);
|
|
});
|
|
|
|
testWidgets('centered mode renders the panel', (tester) async {
|
|
final c = ClideOverlayController();
|
|
addTearDown(c.dispose);
|
|
await tester.pumpWidget(host(c, ValueNotifier(true), centered: true));
|
|
c.open();
|
|
await tester.pump();
|
|
expect(find.text('panel'), findsOneWidget);
|
|
});
|
|
|
|
testWidgets('unmounting the host while open removes the entry without crashing', (tester) async {
|
|
final c = ClideOverlayController();
|
|
addTearDown(c.dispose);
|
|
final present = ValueNotifier(true);
|
|
await tester.pumpWidget(host(c, present));
|
|
c.open();
|
|
await tester.pump();
|
|
expect(find.text('panel'), findsOneWidget);
|
|
present.value = false; // unmount ClideAnchoredOverlay -> dispose removes entry
|
|
await tester.pump(); // rebuild host (unmount + dispose)
|
|
await tester.pump(); // overlay rebuild reflects the removed entry
|
|
expect(find.text('panel'), findsNothing);
|
|
expect(tester.takeException(), isNull);
|
|
});
|
|
|
|
// A ClideAnchoredOverlay hosting a ClideMenu of A/B/C, for the focus +
|
|
// positioning tests below.
|
|
Widget anchoredMenu(
|
|
ClideOverlayController c,
|
|
void Function(String) onPick, {
|
|
ClideAnchorSide side = ClideAnchorSide.below,
|
|
ClideAnchorAlign align = ClideAnchorAlign.start,
|
|
bool autoFlip = false,
|
|
}) {
|
|
return ClideAnchoredOverlay(
|
|
controller: c,
|
|
side: side,
|
|
align: align,
|
|
autoFlip: autoFlip,
|
|
anchor: const SizedBox(width: 80, height: 24, child: ClideText('trigger')),
|
|
overlayBuilder: (ctx, ctrl) => ClideMenu(
|
|
onClose: ctrl.close,
|
|
entries: [
|
|
ClideMenuItem(label: 'A', onSelect: () => onPick('A')),
|
|
ClideMenuItem(label: 'B', onSelect: () => onPick('B')),
|
|
ClideMenuItem(label: 'C', onSelect: () => onPick('C')),
|
|
],
|
|
),
|
|
);
|
|
}
|
|
|
|
testWidgets('keyboard nav reaches a ClideMenu through the overlay', (tester) async {
|
|
final c = ClideOverlayController();
|
|
addTearDown(c.dispose);
|
|
var picked = '';
|
|
await tester.pumpWidget(anchoredHarness(f, anchoredMenu(c, (v) => picked = v)));
|
|
c.open();
|
|
await tester.pumpAndSettle();
|
|
await tester.sendKeyEvent(LogicalKeyboardKey.arrowDown); // A
|
|
await tester.sendKeyEvent(LogicalKeyboardKey.arrowDown); // B
|
|
await tester.sendKeyEvent(LogicalKeyboardKey.enter);
|
|
await tester.pumpAndSettle();
|
|
expect(picked, 'B');
|
|
});
|
|
|
|
testWidgets('an end-aligned menu item is mouse-tappable (no Align hit-offset)', (tester) async {
|
|
final c = ClideOverlayController();
|
|
addTearDown(c.dispose);
|
|
var picked = '';
|
|
// Right-edge trigger + end alignment — the menu extends left, on-screen.
|
|
await tester.pumpWidget(anchoredHarness(f, anchoredMenu(c, (v) => picked = v, align: ClideAnchorAlign.end), alignment: Alignment.topRight));
|
|
c.open();
|
|
await tester.pumpAndSettle();
|
|
await tester.tap(find.text('C'));
|
|
await tester.pumpAndSettle();
|
|
expect(picked, 'C');
|
|
});
|
|
|
|
testWidgets('autoFlip flips below to above when the anchor is near the bottom', (tester) async {
|
|
final c = ClideOverlayController();
|
|
addTearDown(c.dispose);
|
|
await tester.pumpWidget(anchoredHarness(f, anchoredMenu(c, (_) {}, side: ClideAnchorSide.below, autoFlip: true), alignment: Alignment.bottomLeft));
|
|
c.open();
|
|
await tester.pumpAndSettle();
|
|
// The panel (its first item) sits ABOVE the trigger, not below.
|
|
final triggerTop = tester.getRect(find.text('trigger')).top;
|
|
final panelBottom = tester.getRect(find.text('A')).bottom;
|
|
expect(panelBottom, lessThanOrEqualTo(triggerTop));
|
|
});
|
|
});
|
|
}
|