jpmschweitzerandClaude Opus 4.8
3833a41a9e
Replace the 49 hand-maintained named consts with one generated
label→codepoint map (phosphor_glyphs.g.dart, 1512 glyphs from the glyph
table via tool/gen_phosphor_glyphs.dart). Feature code now references
glyphs by their exact kebab-case name — PhosphorIcons.byName('folder') —
with no raw codepoints; this also lets a Lua extension name an icon
without crossing the FFI boundary with a codepoint.
byName is total: an unknown name degrades to the `placeholder` box so the
bug is visible (it's a real error), while phosphor_glyphs_test asserts
every byName('...') literal in lib/ resolves — recovering the typo check a
const gave. Migrated the 89 call sites. Adds EmptyIconPainter for an
intentional blank that still reserves the icon box; ClideFilterBox gains
showIcon to keep the slot aligned when blank.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
36 lines
1021 B
Dart
36 lines
1021 B
Dart
import 'package:clide/builtin/git/src/git_panel_view.dart';
|
|
import 'package:clide/builtin/git/src/git_status_item.dart';
|
|
import 'package:clide/extension/extension.dart';
|
|
import 'package:clide/kernel/kernel.dart';
|
|
import 'package:clide/widgets/widgets.dart';
|
|
|
|
class GitExtension extends ClideExtension {
|
|
@override
|
|
String get id => 'builtin.git';
|
|
@override
|
|
String get title => 'Git';
|
|
@override
|
|
String get version => '0.1.0';
|
|
@override
|
|
List<String> get dependsOn => const ['builtin.diff'];
|
|
|
|
@override
|
|
List<ContributionPoint> get contributions => [
|
|
TabContribution(
|
|
id: 'git.panel',
|
|
slot: Slots.sidebar,
|
|
title: 'Git',
|
|
icon: PhosphorIcons.byName('git-branch'),
|
|
titleKey: 'tab.title',
|
|
i18nNamespace: id,
|
|
priority: -80,
|
|
build: (_) => const GitPanelView(),
|
|
),
|
|
StatusItemContribution(
|
|
id: 'git.branch',
|
|
priority: 10,
|
|
build: (_) => const GitStatusItem(),
|
|
),
|
|
];
|
|
}
|