jpmschweitzerandClaude Opus 4.8
3833a41a9e
Replace the 49 hand-maintained named consts with one generated
label→codepoint map (phosphor_glyphs.g.dart, 1512 glyphs from the glyph
table via tool/gen_phosphor_glyphs.dart). Feature code now references
glyphs by their exact kebab-case name — PhosphorIcons.byName('folder') —
with no raw codepoints; this also lets a Lua extension name an icon
without crossing the FFI boundary with a codepoint.
byName is total: an unknown name degrades to the `placeholder` box so the
bug is visible (it's a real error), while phosphor_glyphs_test asserts
every byName('...') literal in lib/ resolves — recovering the typo check a
const gave. Migrated the 89 call sites. Adds EmptyIconPainter for an
intentional blank that still reserves the icon box; ClideFilterBox gains
showIcon to keep the slot aligned when blank.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
53 lines
1.7 KiB
Dart
53 lines
1.7 KiB
Dart
import 'package:clide/kernel/src/theme/controller.dart';
|
|
import 'package:clide/widgets/src/clide_icon.dart';
|
|
import 'package:clide/widgets/src/clide_tappable.dart';
|
|
import 'package:clide/widgets/src/clide_text.dart';
|
|
import 'package:clide/widgets/src/icons/phosphor.dart';
|
|
import 'package:clide/widgets/src/typography.dart';
|
|
import 'package:flutter/widgets.dart';
|
|
|
|
class ClideAccordion extends StatelessWidget {
|
|
const ClideAccordion({
|
|
super.key,
|
|
required this.label,
|
|
required this.count,
|
|
required this.expanded,
|
|
required this.onToggle,
|
|
required this.children,
|
|
this.leading,
|
|
});
|
|
|
|
final String label;
|
|
final int count;
|
|
final bool expanded;
|
|
final VoidCallback onToggle;
|
|
final List<Widget> children;
|
|
final Widget? leading;
|
|
|
|
@override
|
|
Widget build(BuildContext context) {
|
|
final tokens = ClideTheme.of(context).surface;
|
|
return Column(
|
|
crossAxisAlignment: CrossAxisAlignment.stretch,
|
|
children: [
|
|
ClideTappable(
|
|
onTap: onToggle,
|
|
builder: (ctx, hovered, _) => Padding(
|
|
padding: const EdgeInsets.only(left: 4, top: 10, bottom: 4),
|
|
child: Row(
|
|
children: [
|
|
ClideIcon(expanded ? PhosphorIcons.byName('caret-down') : PhosphorIcons.byName('caret-right'), size: 10, color: tokens.globalTextMuted),
|
|
const SizedBox(width: 6),
|
|
if (leading != null) ...[leading!, const SizedBox(width: 6)],
|
|
ClideText('$label · $count',
|
|
fontSize: clideFontSmall, color: hovered ? tokens.globalForeground : tokens.sidebarSectionHeader, fontFamily: clideMonoFamily),
|
|
],
|
|
),
|
|
),
|
|
),
|
|
if (expanded) ...children,
|
|
],
|
|
);
|
|
}
|
|
}
|