jpmschweitzerandClaude
6b7290dc42
test / unit + widget + golden + a11y (push) Failing after 28s
test / integration_test (xvfb) (push) Has been skipped
test / bundle smoke (xvfb 5s) (push) Has been skipped
test / daemon subprocess + web WASM smoke (push) Has been skipped
test / dart doc (lib API) (push) Failing after 59s
`TerminalView.onTapUp` was documented as "Callback for when the
user taps on the terminal" but was wired to a code path nothing
ever invoked:
- `TerminalView.build` passed it via `onTapUp:` to
`TerminalGestureHandler`,
- which forwarded via `onTapUp:` to `TerminalGestureDetector`,
- whose `onTapUp` field was declared and accepted but never called
by `_handleTapUp` (which only fires `onSingleTapUp`).
Net: every caller that registered an `onTapUp` callback on
`TerminalView` got silent failure. zero in-tree callers depended
on it (clide_pty_view.dart is the only TerminalView callsite and
doesn't pass any tap callback), but the public API said one thing
and did another.
Fix: wire `_onTapUp` (the cell-resolving state-method) through the
detector's working `onSingleTapUp` slot. The user-facing semantics
("fires on confirmed single tap with the resolved cell offset")
match the only sane interpretation of the docstring, and don't
overlap with the existing `onSecondaryTap*` (which were already
correctly wired through TapGestureRecognizer's secondary callbacks).
Also drops the dead surface that surfaced the bug:
- `TerminalGestureHandler.onTapUp` parameter + field — no caller
passes it after the fix; was only used to forward into the dead
detector field.
- `TerminalGestureDetector.onTapUp` parameter + field — never
invoked by `_handleTapUp`. Pure dead code.
Tests: extends `terminal_view_test.dart` with a primary-tap
regression case + paired tests for selection-clearing and
secondary-tap callback routing. The double-tap recognizer's
300 ms timer is flushed via `pump(const Duration(seconds: 1))`
(pumpAndSettle waits for animations, not arbitrary timers).
Coverage delta:
- terminal_view.dart: 151/188 → 180/188 (95.7%; remaining gaps
are IME `_onComposing`/`_onEditableRect`/`_onKeyboardShow`
body branches that need deeper IME mocking).
- gesture_handler.dart: 18/60 → 39/59.
- gesture_detector.dart: 30/50 → 42/50.
- Total project: 65.76% → 66.97%; coverage_floor 65 → 66.
Co-Authored-By: Claude <noreply@anthropic.com>
107 lines
2.8 KiB
YAML
107 lines
2.8 KiB
YAML
# clide — IDE for Claude Code CLI.
|
|
#
|
|
# Single source of truth for project metadata and dependencies.
|
|
# The Flutter app hosts everything in-process (D-056); tmux owns
|
|
# session persistence (D-041).
|
|
#
|
|
# Prefer-zero-deps; every third-party entry is exact-pinned and
|
|
# justified. No carets. See D-031.
|
|
|
|
name: clide
|
|
description: >-
|
|
IDE for Claude Code CLI. One Dart package covering the UI,
|
|
subsystem handlers (pane, files, editor, git, pql), and the
|
|
extension framework.
|
|
publish_to: none
|
|
version: 2.0.0
|
|
repository: https://github.com/postmeridiem/clide
|
|
|
|
# Pre-push line-coverage floor. Ratchets up only — see D-66.
|
|
# Reading: `awk -F: '/^coverage_floor:/ {gsub(/ /,"",$2); print $2}' pubspec.yaml`.
|
|
coverage_floor: 66
|
|
|
|
# Project metadata (was project.yaml, folded in per D-056).
|
|
# version: above is the single source of truth. The Makefile reads
|
|
# it for build stamping. Cutting a release bumps version + changelog
|
|
# in one commit.
|
|
#
|
|
# maintainers:
|
|
# Jeroen Schweitzer <jpmschweitzer@gmail.com>
|
|
# license: MIT
|
|
# status: pre-v2.0, interaction model + panel system landed
|
|
# flutter_channel: stable
|
|
|
|
environment:
|
|
sdk: ">=3.5.0 <4.0.0"
|
|
flutter: ">=3.19.0"
|
|
|
|
dependencies:
|
|
flutter:
|
|
sdk: flutter
|
|
|
|
yaml: 3.1.3
|
|
|
|
ffi: 2.1.3
|
|
|
|
jovial_svg: 1.1.26
|
|
|
|
markdown: 7.2.2
|
|
|
|
flutter_widget_from_html_core: 0.17.2
|
|
|
|
dev_dependencies:
|
|
flutter_test:
|
|
sdk: flutter
|
|
flutter_lints: 6.0.0
|
|
|
|
integration_test:
|
|
sdk: flutter
|
|
|
|
test: 1.30.0
|
|
mocktail: 1.0.4
|
|
alchemist: 0.12.1
|
|
|
|
flutter:
|
|
uses-material-design: false
|
|
|
|
assets:
|
|
- lib/kernel/src/theme/themes/
|
|
- lib/kernel/src/i18n/catalog/
|
|
- assets/licenses.yaml
|
|
- assets/LICENSE
|
|
- assets/fonts/jetbrains_mono/OFL.txt
|
|
- assets/fonts/josefin_sans/OFL.txt
|
|
- assets/fonts/phosphor/LICENSE
|
|
- assets/logo/logo.svg
|
|
- assets/logo/logo-192.png
|
|
- assets/logo/appicon.svg
|
|
- assets/logo/appicon-256.png
|
|
- assets/clide.tmux.conf
|
|
- assets/grammars/
|
|
- assets/queries/
|
|
|
|
fonts:
|
|
- family: JosefinSans
|
|
fonts:
|
|
- asset: assets/fonts/josefin_sans/JosefinSans-VariableFont.ttf
|
|
- asset: assets/fonts/josefin_sans/JosefinSans-Italic-VariableFont.ttf
|
|
style: italic
|
|
|
|
- family: Phosphor
|
|
fonts:
|
|
- asset: assets/fonts/phosphor/Phosphor.ttf
|
|
- asset: assets/fonts/phosphor/Phosphor-Bold.ttf
|
|
weight: 700
|
|
- asset: assets/fonts/phosphor/Phosphor-Fill.ttf
|
|
|
|
- family: JetBrainsMono
|
|
fonts:
|
|
- asset: assets/fonts/jetbrains_mono/JetBrainsMono-Regular.ttf
|
|
- asset: assets/fonts/jetbrains_mono/JetBrainsMono-Italic.ttf
|
|
style: italic
|
|
- asset: assets/fonts/jetbrains_mono/JetBrainsMono-Bold.ttf
|
|
weight: 700
|
|
- asset: assets/fonts/jetbrains_mono/JetBrainsMono-BoldItalic.ttf
|
|
weight: 700
|
|
style: italic
|