jpmschweitzerandClaude Opus 4.8
0231cb41e0
ci/test_core.sh ran 'dart test test/ipc test/pty ... test/pql' in the default parallel pool, so the real-PTY tests in test/pty competed for fds + CPU with the other suites and the reader isolate was starved — intermittently failing 'write sends keystrokes to child' under load. Split into a serial --tags pty pass and a parallel --exclude-tags pty pass, mirroring ci/test.sh. Same 571 tests; pty pass verified stable across repeated runs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
63 lines
2.3 KiB
Bash
Executable File
63 lines
2.3 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
# ci/test_core.sh — run the Flutter-free core Dart tests.
|
|
#
|
|
# Covers `test/` at the repo root (IPC, daemon, PTY). Wraps `dart test`
|
|
# in a hard timeout + process-group kill so a hanging test (typically
|
|
# one holding a native fd open) can't wedge CI or pre-push.
|
|
#
|
|
# Rationale: D-030 makes tests client-side only; a hang here is always
|
|
# local — either a real bug or a bad test. Either way we'd rather fail
|
|
# loudly at 120s than block a pre-push indefinitely.
|
|
|
|
set -euo pipefail
|
|
|
|
HERE="$(cd "$(dirname "$0")" && pwd)"
|
|
ROOT="$(cd "$HERE/.." && pwd)"
|
|
cd "$ROOT"
|
|
|
|
if ! command -v dart >/dev/null; then
|
|
echo "test-core: dart not on PATH; is Flutter installed?" >&2
|
|
exit 2
|
|
fi
|
|
|
|
# Hard timeout (seconds). The PTY tests should finish in <5s; IPC/daemon
|
|
# tests are faster still. 120s is generous for CI warmup, tiny for a
|
|
# hang.
|
|
TIMEOUT_SECONDS=${TIMEOUT_SECONDS:-120}
|
|
|
|
# failures-only: print failing tests + a final count, not one line per test.
|
|
# Override with TEST_REPORTER=expanded when debugging. (T-242)
|
|
REPORTER="${TEST_REPORTER:-failures-only}"
|
|
|
|
# Run dart test in its own process group so we can kill descendants on
|
|
# timeout. `setsid` starts a new session; `timeout --kill-after` SIGKILLs
|
|
# after SIGTERM if the test ignores it.
|
|
CORE_DIRS="test/ipc test/pty test/daemon test/git test/panes test/files test/editor test/pql"
|
|
|
|
# Run a `dart test` pass under the hard timeout + process-group kill.
|
|
run_pass() {
|
|
if ! timeout --kill-after=5s "${TIMEOUT_SECONDS}s" \
|
|
setsid --wait dart test -r "$REPORTER" "$@" ; then
|
|
rc=$?
|
|
if [[ $rc -eq 124 ]]; then
|
|
echo "test-core: TIMEOUT — killing descendants" >&2
|
|
pkill -9 -f "dart test" 2>/dev/null || true
|
|
exit 1
|
|
fi
|
|
exit $rc
|
|
fi
|
|
}
|
|
|
|
# PTY-tagged tests spawn real PTYs (posix_openpt + posix_spawn) and rely on a
|
|
# reader isolate; run in the default parallel pool they contend for fds + CPU
|
|
# with the other suites and the isolate is starved, flaking 'write sends
|
|
# keystrokes to child' (T-292). Serialize them in their own pass — matching
|
|
# ci/test.sh — then run everything else in parallel.
|
|
echo "test-core: dart test (pty-tagged; --concurrency=1) (timeout ${TIMEOUT_SECONDS}s)"
|
|
run_pass --concurrency=1 --tags pty $CORE_DIRS
|
|
|
|
echo "test-core: dart test (rest; parallel, excludes pty) (timeout ${TIMEOUT_SECONDS}s)"
|
|
run_pass --exclude-tags pty $CORE_DIRS
|
|
|
|
echo "test-core: ok"
|