jpmschweitzerandClaude Opus 4.8
0eb7b0df2f
Two reveal-on-open bugs: Decisions opened only on the second click (T-196): the detail view subscribed in didChangeDependencies, which runs after the tab is revealed, so the broadcast 'selection' that triggered the reveal was already gone. Hoist the back/forward history out of per-view State into a retained per-reader ReaderNav (kernel ChangeNotifier in a ReaderNavRegistry, D-81). The nav records selections, emits 'load' (the single channel readers display from), and survives mount/unmount — the reader grabs nav.current on mount, so the first selection lands. Both the markdown and decisions readers move to this model; the per-view ReaderHistoryMixin and the markdown post-frame forward hack are gone. The editor pane never opened (T-197): EditorExtension contributed a workspace tab but nothing activated it on editor.open. Add an activate() that reveals the tab on editor.opened / editor.active-changed; the view's hydrate() pulls the active buffer on mount. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
58 lines
1.8 KiB
Dart
58 lines
1.8 KiB
Dart
import 'dart:async';
|
|
|
|
import 'package:clide/builtin/decisions/src/decision_detail_view.dart';
|
|
import 'package:clide/builtin/decisions/src/decisions_view.dart';
|
|
import 'package:clide/extension/extension.dart';
|
|
import 'package:clide/kernel/kernel.dart';
|
|
import 'package:clide/widgets/widgets.dart';
|
|
|
|
class DecisionsExtension extends ClideExtension {
|
|
@override
|
|
String get id => 'builtin.decisions';
|
|
@override
|
|
String get title => 'Decisions';
|
|
@override
|
|
String get version => '0.6.0';
|
|
@override
|
|
List<String> get dependsOn => const [];
|
|
|
|
StreamSubscription<Message>? _sub;
|
|
|
|
@override
|
|
Future<void> activate(ClideExtensionContext ctx) async {
|
|
// Ensure the retained nav exists so it records selections + emits
|
|
// loads whether or not the reader is mounted (T-196). This handler
|
|
// only reveals the tab; the nav owns load + history.
|
|
ctx.readerNav.navFor(id, dataKey: 'id');
|
|
_sub = ctx.messages.subscribe(publisher: id, channel: 'selection').listen((msg) {
|
|
if (msg.data['id'] is! String) return;
|
|
ctx.arrangement.setVisible(Slots.contextPanel, true);
|
|
ctx.arrangement.setCollapsed(Slots.contextPanel, false);
|
|
ctx.panels.activateTab(Slots.contextPanel, 'decisions.detail');
|
|
});
|
|
}
|
|
|
|
@override
|
|
Future<void> deactivate() async => _sub?.cancel();
|
|
|
|
@override
|
|
List<ContributionPoint> get contributions => [
|
|
TabContribution(
|
|
id: 'decisions.panel',
|
|
slot: Slots.sidebar,
|
|
title: 'Decisions',
|
|
titleKey: 'tab.title',
|
|
i18nNamespace: id,
|
|
icon: PhosphorIcons.lightbulb,
|
|
build: (_) => const DecisionsView(),
|
|
),
|
|
TabContribution(
|
|
id: 'decisions.detail',
|
|
slot: Slots.contextPanel,
|
|
title: 'Decision',
|
|
icon: PhosphorIcons.lightbulb,
|
|
build: (_) => const DecisionDetailView(),
|
|
),
|
|
];
|
|
}
|