Jeroen SchweitzerandClaude Opus 4.6
a6eca2561b
Complete three overdue cleanups discovered during macOS health check: D-56 daemon dissolution: delete bin/clide.dart, DaemonServer, and orphaned tests (test/cli/, subprocess_test, in_process_test). Update stale "clide --daemon" references in i18n catalogs, error messages, editor_commands, CI scripts, and decision records. ptyc retirement: delete ptyc/ source tree, PtySession, scm_rights. Remove from Toolchain resolution, ToolCheck gate, backend serialization, testmode harness, Makefile, CI, and sandbox entitlements. PTY spawning uses NativePty (Dart FFI forkpty) since the terminal was absorbed in-tree. D-5 amended. Golden tests: wire the existing but never-applied clideGoldenConfig via flutter_test_config.dart. Disable CI goldens (Skia anti-aliasing differs between macOS/Linux even with Ahem). Keep platform-keyed goldens only — goldens/linux/ and goldens/macos/ each run on their own OS. Test suite: 826 pass, 0 fail on macOS (was 829 pass, 11 fail). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
46 lines
1.5 KiB
Bash
Executable File
46 lines
1.5 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
# ci/test_core.sh — run the Flutter-free core Dart tests.
|
|
#
|
|
# Covers `test/` at the repo root (IPC, daemon, PTY). Wraps `dart test`
|
|
# in a hard timeout + process-group kill so a hanging test (typically
|
|
# one holding a native fd open) can't wedge CI or pre-push.
|
|
#
|
|
# Rationale: D-030 makes tests client-side only; a hang here is always
|
|
# local — either a real bug or a bad test. Either way we'd rather fail
|
|
# loudly at 120s than block a pre-push indefinitely.
|
|
|
|
set -euo pipefail
|
|
|
|
HERE="$(cd "$(dirname "$0")" && pwd)"
|
|
ROOT="$(cd "$HERE/.." && pwd)"
|
|
cd "$ROOT"
|
|
|
|
if ! command -v dart >/dev/null; then
|
|
echo "test-core: dart not on PATH; is Flutter installed?" >&2
|
|
exit 2
|
|
fi
|
|
|
|
# Hard timeout (seconds). The PTY tests should finish in <5s; IPC/daemon
|
|
# tests are faster still. 120s is generous for CI warmup, tiny for a
|
|
# hang.
|
|
TIMEOUT_SECONDS=${TIMEOUT_SECONDS:-120}
|
|
|
|
# Run dart test in its own process group so we can kill descendants on
|
|
# timeout. `setsid` starts a new session; `timeout --kill-after` SIGKILLs
|
|
# after SIGTERM if the test ignores it.
|
|
CORE_DIRS="test/ipc test/pty test/daemon test/git test/panes test/files test/editor test/pql"
|
|
|
|
echo "test-core: dart test ${CORE_DIRS} (timeout ${TIMEOUT_SECONDS}s)"
|
|
if ! timeout --kill-after=5s "${TIMEOUT_SECONDS}s" \
|
|
setsid --wait dart test $CORE_DIRS ; then
|
|
rc=$?
|
|
if [[ $rc -eq 124 ]]; then
|
|
echo "test-core: TIMEOUT — killing descendants" >&2
|
|
pkill -9 -f "dart test test/" 2>/dev/null || true
|
|
exit 1
|
|
fi
|
|
exit $rc
|
|
fi
|
|
|
|
echo "test-core: ok"
|