clide/test/daemon/ui_command_test.dart

/// Tests for `ui.open` — the drive-half of D-6 parity (T-231). Verifies it
/// publishes the right MessageBus 'selection' per reader, validates input,
/// and fails honestly when there is no live UI.
library;

import 'package:clide/clide.dart';
import 'package:clide/src/daemon/ui_command.dart';
import 'package:test/test.dart';

void main() {
  // Records what would be published to the kernel MessageBus.
  late List<({String publisher, String channel, Map<String, Object?> data})> published;
  late DaemonDispatcher d;

  // Backing store for the ui.filter observe-half (the FilterStateCache in
  // production). Null getter ⇒ no live UI to observe.
  late Map<String, String> filterValues;

  void wire({bool liveUi = true}) {
    published = [];
    filterValues = {};
    d = DaemonDispatcher();
    registerUiCommands(
      d,
      () {
        if (!liveUi) return null;
        return (publisher, channel, data) => published.add((publisher: publisher, channel: channel, data: data));
      },
      filterValue: liveUi ? (address) => filterValues[address] : null,
    );
  }

  Future<IpcResponse> open(List<String> positional) => d.dispatch(
        IpcRequest(id: '1', cmd: 'ui.open', args: {'positional': positional}),
      );

  test('ui open tickets T-48 publishes a tickets selection', () async {
    wire();
    final r = await open(['tickets', 'T-48']);
    expect(r.ok, isTrue, reason: r.error?.message);
    expect(r.data['opened'], isTrue);
    expect(published, hasLength(1));
    expect(published.single.publisher, 'builtin.tickets');
    expect(published.single.channel, 'selection');
    expect(published.single.data, {'id': 'T-48'});
  });

  test('decisions keys on id; markdown keys on path', () async {
    wire();
    await open(['decisions', 'D-17']);
    await open(['markdown', 'docs/initial-plan.md']);
    expect(published[0].publisher, 'builtin.decisions');
    expect(published[0].data, {'id': 'D-17'});
    expect(published[1].publisher, 'builtin.markdown');
    expect(published[1].data, {'path': 'docs/initial-plan.md'});
  });

  test('diff keys on path and publishes a builtin.diff selection (T-233)', () async {
    wire();
    final r = await open(['diff', 'lib/main.dart']);
    expect(r.ok, isTrue, reason: r.error?.message);
    expect(r.data['opened'], isTrue);
    expect(published.single.publisher, 'builtin.diff');
    expect(published.single.channel, 'selection');
    expect(published.single.data, {'path': 'lib/main.dart'});
  });

  test('named args work too (reader/ref)', () async {
    wire();
    final r = await d.dispatch(IpcRequest(id: '1', cmd: 'ui.open', args: {'reader': 'tickets', 'ref': 'T-7'}));
    expect(r.ok, isTrue);
    expect(published.single.data, {'id': 'T-7'});
  });

  test('unknown reader → userError, nothing published', () async {
    wire();
    final r = await open(['canvas', 'foo']);
    expect(r.ok, isFalse);
    expect(r.error?.kind, IpcErrorKind.userError);
    expect(published, isEmpty);
  });

  test('missing ref → userError', () async {
    wire();
    final r = await open(['tickets']);
    expect(r.ok, isFalse);
    expect(r.error?.kind, IpcErrorKind.userError);
    expect(published, isEmpty);
  });

  test('no live UI (null publisher) → toolError, not a hang', () async {
    wire(liveUi: false);
    final r = await open(['tickets', 'T-48']);
    expect(r.ok, isFalse);
    expect(r.error?.kind, IpcErrorKind.toolError);
  });

  // -- ui.toast (T-50 drive-half) -------------------------------------------

  Future<IpcResponse> toast(List<String> positional, {Map<String, Object?>? flags}) => d.dispatch(
        IpcRequest(id: '1', cmd: 'ui.toast', args: {'positional': positional, if (flags != null) 'flags': flags}),
      );

  test('ui toast publishes a toast message (default info severity)', () async {
    wire();
    final r = await toast(['Build', 'finished']); // unquoted multi-word joins
    expect(r.ok, isTrue, reason: r.error?.message);
    expect(r.data['shown'], isTrue);
    expect(published.single.publisher, 'cli');
    expect(published.single.channel, 'toast');
    expect(published.single.data, {'message': 'Build finished', 'severity': 'info'});
  });

  test('ui toast honours --severity and --duration', () async {
    wire();
    final r = await toast(['Pushed'], flags: {'severity': 'success', 'duration': '2000'});
    expect(r.ok, isTrue);
    expect(published.single.data, {'message': 'Pushed', 'severity': 'success', 'durationMs': 2000});
  });

  test('ui toast rejects an unknown severity', () async {
    wire();
    final r = await toast(['x'], flags: {'severity': 'bogus'});
    expect(r.ok, isFalse);
    expect(r.error?.kind, IpcErrorKind.userError);
    expect(published, isEmpty);
  });

  test('ui toast rejects a non-integer duration', () async {
    wire();
    final r = await toast(['x'], flags: {'duration': 'soon'});
    expect(r.ok, isFalse);
    expect(r.error?.kind, IpcErrorKind.userError);
  });

  test('ui toast with no message → userError', () async {
    wire();
    final r = await toast([]);
    expect(r.ok, isFalse);
    expect(r.error?.kind, IpcErrorKind.userError);
    expect(published, isEmpty);
  });

  test('ui toast with no live UI → toolError', () async {
    wire(liveUi: false);
    final r = await toast(['hi']);
    expect(r.ok, isFalse);
    expect(r.error?.kind, IpcErrorKind.toolError);
  });

  // -- ui.filter (T-270 drive+observe half) ---------------------------------

  Future<IpcResponse> filter(List<String> positional) => d.dispatch(
        IpcRequest(id: '1', cmd: 'ui.filter', args: {'positional': positional}),
      );

  test('ui filter <address> <text> publishes a filter.set', () async {
    wire();
    final r = await filter(['decisions.panel', 'git']);
    expect(r.ok, isTrue, reason: r.error?.message);
    expect(r.data['set'], isTrue);
    expect(published.single.publisher, 'decisions.panel');
    expect(published.single.channel, 'filter.set');
    expect(published.single.data, {'query': 'git'});
  });

  test('ui filter <address> "" clears (drives an empty query)', () async {
    wire();
    final r = await filter(['decisions.panel', '']);
    expect(r.ok, isTrue, reason: r.error?.message);
    expect(published.single.data, {'query': ''});
  });

  test('ui filter <address> with no text observes the cached value', () async {
    wire();
    filterValues['decisions.panel'] = 'git';
    final r = await filter(['decisions.panel']);
    expect(r.ok, isTrue, reason: r.error?.message);
    expect(r.data, {'address': 'decisions.panel', 'query': 'git'});
    expect(published, isEmpty, reason: 'observe must not publish');
  });

  test('ui filter observe of an unknown address returns a null query', () async {
    wire();
    final r = await filter(['never.touched']);
    expect(r.ok, isTrue);
    expect(r.data, {'address': 'never.touched', 'query': null});
  });

  test('ui filter with no address → userError', () async {
    wire();
    final r = await filter([]);
    expect(r.ok, isFalse);
    expect(r.error?.kind, IpcErrorKind.userError);
    expect(published, isEmpty);
  });

  test('ui filter drive with no live UI → toolError', () async {
    wire(liveUi: false);
    final r = await filter(['decisions.panel', 'git']);
    expect(r.ok, isFalse);
    expect(r.error?.kind, IpcErrorKind.toolError);
  });

  test('ui filter observe with no live UI → toolError', () async {
    wire(liveUi: false);
    final r = await filter(['decisions.panel']);
    expect(r.ok, isFalse);
    expect(r.error?.kind, IpcErrorKind.toolError);
  });
}