jpmschweitzerandClaude Opus 4.8
6d0ebab721
Raise the declared minimums in pubspec.yaml to what our deps already require: Flutter >=3.35.0 / Dart >=3.9.0 (was 3.19.0 / 3.5.0). alchemist 0.12 needs Flutter 3.32; Dart 3.9 first ships in Flutter 3.35, so 3.35 is the binding floor. Pin the exact build toolchain in .fvmrc (Flutter 3.44.1). Moving to the Dart 3.9 language level switches `dart format` to the new "tall" style and enables two new lints. This commit is the resulting mechanical churn, isolated from any behaviour change: - whole-tree `dart format` reformat (tall style) - `dart fix` for unnecessary_underscores + use_null_aware_elements No runtime behaviour change; `make test` green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
56 lines
2.4 KiB
Dart
56 lines
2.4 KiB
Dart
/// Register the `_argv` sentinel command on a [DaemonDispatcher].
|
|
///
|
|
/// The C client (T-126) doesn't know the dispatcher's command surface
|
|
/// — it ships raw argv across the wire under cmd `_argv`. This handler
|
|
/// runs [parseArgv] on the embedded argv and either dispatches the
|
|
/// resulting [IpcRequest] or returns the pre-built error response.
|
|
///
|
|
/// Why a sentinel cmd rather than a top-level parse step in the IPC
|
|
/// server: keeps the server transport-agnostic — every consumer that
|
|
/// already has a typed [IpcRequest] goes the direct path; only the
|
|
/// CLI's raw-argv envelope hits this unwrap shim.
|
|
library;
|
|
|
|
import 'package:clide/src/cli/argv_to_request.dart';
|
|
import 'package:clide/src/daemon/dispatcher.dart';
|
|
import 'package:clide/src/ipc/envelope.dart';
|
|
import 'package:clide/src/ipc/schema_v1.dart';
|
|
|
|
/// Sentinel command id the C `clide` client sends. Anything else
|
|
/// goes through the normal dispatcher path unchanged.
|
|
const String argvSentinelCmd = '_argv';
|
|
|
|
/// Unwrap an `_argv` IpcRequest into the inner parsed request, or
|
|
/// return an error response if the envelope is malformed or the
|
|
/// argv doesn't parse. Pure function — no dispatch. Used by both
|
|
/// the IPC server (which needs the unwrapped cmd to decide whether
|
|
/// to enter streaming mode for `tail --events`, per T-129) and the
|
|
/// dispatcher-side handler below.
|
|
ArgvParseResult unwrapArgvRequest(IpcRequest outer) {
|
|
final raw = outer.args['argv'];
|
|
if (raw is! List) {
|
|
return ArgvError(
|
|
IpcResponse.err(
|
|
id: outer.id,
|
|
error: IpcError(code: IpcExitCode.userError, kind: IpcErrorKind.userError, message: '_argv requires args.argv to be a JSON array'),
|
|
),
|
|
);
|
|
}
|
|
return parseArgv(raw.cast<String>(), requestId: outer.id);
|
|
}
|
|
|
|
/// Wire the `_argv` sentinel handler onto [dispatcher]. The handler
|
|
/// unwraps the inner argv via [unwrapArgvRequest], dispatches the
|
|
/// resulting request through the same dispatcher, and otherwise
|
|
/// returns the pre-built error response. Kept registered for the
|
|
/// non-streaming path; the IPC server intercepts before dispatch
|
|
/// for `tail --events` (T-129).
|
|
void registerArgvUnwrap(DaemonDispatcher dispatcher) {
|
|
dispatcher.register(argvSentinelCmd, (outer) async {
|
|
return switch (unwrapArgvRequest(outer)) {
|
|
ArgvParsed(:final request) => await dispatcher.dispatch(request),
|
|
ArgvError(:final response) => response,
|
|
};
|
|
});
|
|
}
|