jpmschweitzerandClaude Opus 4.8
85cc34e09c
First increment of the observability epic (T-425), the productive pivot after the ConPTY freeze refused to reproduce on CI: if we can't reproduce it, make the next occurrence leave evidence. - FileLogSink (lib/kernel/src/file_log_sink.dart): synchronous, crash-survivable LogSink. Appends each record as one JSON line to a size-rotated file; fsyncs warn/error + risky-source (pty/ffi/conpty/watchdog) records immediately so the last breadcrumb is on disk before a hard death, batches the rest on a timer. Never throws. Flutter-free → unit-tested under dart test against a temp dir. - logDirectory() (paths.dart): persistent per-platform log dir (LOCALAPPDATA / ~/Library/Logs / $XDG_STATE_HOME) — durable across reboot, unlike the ephemeral socketDirectory. - resolveLogLevel() (log.dart): the requested dev/prod toggle. CLIDE_LOG dart-define → CLIDE_LOG env → app.log.level setting → warn(release)/info(debug). Lenient parse; an invalid source falls through. - Boot wiring (facade.boot + main.dart): FileLogSink leads the sink chain (so a crash records before the volatile stderr/ring sinks) and the resolved level sets Logger.minLevel. Tests: FileLogSink (JSON shape, error/stack, rotation cap, append-across-restart, timer-cancel), resolveLogLevel precedence + fall-through, logDirectory per-OS. Coverage gate 95.11%. Follow-ups under T-425: live toggle CLI/command/chip (T-433), FFI breadcrumbs (T-434), watchdog isolate (T-435), CI artifact wiring (T-436). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
91 lines
3.2 KiB
Dart
91 lines
3.2 KiB
Dart
import 'dart:io';
|
|
|
|
import 'package:clide/src/ipc/paths.dart';
|
|
import 'package:test/test.dart';
|
|
|
|
void main() {
|
|
group('workspaceSocketPath (D-70)', () {
|
|
test('returns the FNV-1a hashed path under the socket directory', () {
|
|
final p = workspaceSocketPath('/home/me/projects/clide');
|
|
expect(p, startsWith('${socketDirectory()}/'));
|
|
expect(p, endsWith('.sock'));
|
|
// 16-char hex hash.
|
|
final hash = p.split('/').last.replaceAll('.sock', '');
|
|
expect(hash, matches(RegExp(r'^[0-9a-f]{16}$')));
|
|
});
|
|
|
|
test('is deterministic for the same input', () {
|
|
expect(workspaceSocketPath('/home/me/repo'), workspaceSocketPath('/home/me/repo'));
|
|
});
|
|
|
|
test('different workspace roots hash to different paths', () {
|
|
expect(workspaceSocketPath('/home/me/repo-a'), isNot(workspaceSocketPath('/home/me/repo-b')));
|
|
});
|
|
|
|
test('socketDirectory uses XDG_RUNTIME_DIR on Linux when set', () {
|
|
if (Platform.isMacOS) return;
|
|
final xdg = Platform.environment['XDG_RUNTIME_DIR'];
|
|
if (xdg != null && xdg.isNotEmpty) {
|
|
expect(socketDirectory(), '$xdg/clide');
|
|
} else {
|
|
expect(socketDirectory(), '/tmp/clide');
|
|
}
|
|
});
|
|
|
|
test('socketDirectory uses ~/Library/Caches on macOS', () {
|
|
if (!Platform.isMacOS) return;
|
|
final home = Platform.environment['HOME']!;
|
|
expect(socketDirectory(), '$home/Library/Caches/clide');
|
|
});
|
|
});
|
|
|
|
group('logDirectory (T-425)', () {
|
|
test('is a persistent, non-ephemeral location distinct from the socket dir', () {
|
|
// The freeze evidence must survive a reboot, so logs must NOT live in
|
|
// the ephemeral socket/runtime dir.
|
|
expect(logDirectory(), isNot(socketDirectory()));
|
|
});
|
|
|
|
test('Linux: XDG_STATE_HOME/clide/logs when set, else ~/.local/state/...', () {
|
|
if (Platform.isMacOS || Platform.isWindows) return;
|
|
final state = Platform.environment['XDG_STATE_HOME'];
|
|
if (state != null && state.isNotEmpty) {
|
|
expect(logDirectory(), '$state/clide/logs');
|
|
} else {
|
|
final home = Platform.environment['HOME'] ?? '/tmp';
|
|
expect(logDirectory(), '$home/.local/state/clide/logs');
|
|
}
|
|
});
|
|
|
|
test('macOS: ~/Library/Logs/clide (not Caches)', () {
|
|
if (!Platform.isMacOS) return;
|
|
final home = Platform.environment['HOME']!;
|
|
expect(logDirectory(), '$home/Library/Logs/clide');
|
|
});
|
|
});
|
|
|
|
group('fnv1a64Hex (T-126 cross-check)', () {
|
|
// Reference values from <http://isthe.com/chongo/tech/comp/fnv/>.
|
|
// The C client in native/clide-cli/clide.c MUST produce the same
|
|
// 16-char hex strings for the same inputs, or server + client see
|
|
// different socket paths and the integration falls apart silently.
|
|
test('empty string → offset basis', () {
|
|
expect(fnv1a64Hex(''), 'cbf29ce484222325');
|
|
});
|
|
|
|
test('"a" → reference value', () {
|
|
expect(fnv1a64Hex('a'), 'af63dc4c8601ec8c');
|
|
});
|
|
|
|
test('"foo" → reference value', () {
|
|
expect(fnv1a64Hex('foo'), 'dcb27518fed9d577');
|
|
});
|
|
|
|
test('"/home/me/projects/clide" → 16 hex chars, deterministic', () {
|
|
final h = fnv1a64Hex('/home/me/projects/clide');
|
|
expect(h, matches(RegExp(r'^[0-9a-f]{16}$')));
|
|
expect(fnv1a64Hex('/home/me/projects/clide'), h);
|
|
});
|
|
});
|
|
}
|