Files
clide/test/panes/registry_test.dart
T
jpmschweitzerandClaude Opus 4.7 b66e8f6cc0 event-driven test waits, fail-loud on timeout (T-108)
Replaces the fixed Future.delayed sleeps the consultant flagged
with stream-based waits that complete when the awaited event
arrives. Timeout callbacks call fail() with a diagnostic instead
of `onTimeout: () {}` swallowing the signal — a never-producing
pty now reports "pty did not produce X within 5s" instead of an
unhelpful "Actual: ''".

session_test.dart:
  - _readUntil helper subscribes to s.output, completes when a
    marker substring appears (or onDone), fails on timeout.
  - _waitForBuffer polls a buffer the listener is already filling
    after a write; 25ms tick, 5s ceiling, fail-loud on miss.
  - Drops the 500ms settle + 50×100ms polling pattern in the write
    test; uses a "first-byte" completer for prompt-readiness.
  - retry: 2 restored on the four read-dependent forkpty tests
    (the underlying flutter-test-runner pty-output flake hasn't
    fully gone away; recovers cleanly on a fresh spawn).

watcher_test.dart:
  - "emits a created event" awaits stream.firstWhere instead of two
    fixed sleeps.
  - "filters ignored paths" uses pre + post sentinel markers to
    bracket the inotify-delivery window event-driven; the negative
    assertion only runs after the post marker is observed.

event_sink.dart:
  - RecordingEventSink gains a broadcast `stream` for the same
    event-await pattern. PaneRegistry's output test subscribes
    BEFORE spawn so first bytes aren't lost.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-17 22:05:49 +02:00

130 lines
4.3 KiB
Dart

/// Unit tests for [PaneRegistry].
///
/// Exercises spawn / list / write / resize / close against the real
/// NativePty (forkpty via FFI). Events are captured via
/// [RecordingEventSink].
library;
import 'dart:async';
import 'dart:convert';
import 'dart:io';
import 'package:clide/clide.dart';
import 'package:clide/src/panes/registry.dart';
import 'package:test/test.dart';
void main() {
if (!Platform.isLinux && !Platform.isMacOS) return;
group('PaneRegistry', () {
late RecordingEventSink sink;
late PaneRegistry registry;
setUp(() {
sink = RecordingEventSink();
registry = PaneRegistry(events: sink);
});
tearDown(() => registry.shutdown());
test('spawn → emits pane.spawned and lists the pane', () async {
final pane = await registry.spawn(
kind: PaneKind.terminal,
argv: const ['/bin/echo', 'hi'],
);
expect(pane.id, startsWith('p_'));
expect(pane.kind, PaneKind.terminal);
expect(registry.panes, contains(pane));
expect(sink.ofKind('pane.spawned'), hasLength(1));
final evt = sink.ofKind('pane.spawned').first;
expect(evt.data['id'], pane.id);
});
test('output events base64-encode the child bytes', tags: ['forkpty'], retry: 2, () async {
// Subscribe to the sink stream BEFORE spawn so we don't miss
// any pane.output events that arrive between spawn and listen.
final buf = StringBuffer();
final got = Completer<String>();
final sub = sink.stream.listen((e) {
if (e.kind != 'pane.output') return;
buf.write(utf8.decode(base64Decode(e.data['bytes_b64']! as String)));
if (buf.toString().contains('hello-panes') && !got.isCompleted) {
got.complete(buf.toString());
}
});
addTearDown(sub.cancel);
await registry.spawn(
kind: PaneKind.terminal,
// Child writes then lingers so the reader's poll has a wide
// window to see POLLIN before HUP.
argv: const ['/bin/sh', '-c', 'printf hello-panes; sleep 0.25'],
);
final decoded = await got.future.timeout(
const Duration(seconds: 5),
onTimeout: () => fail('pane.output never carried "hello-panes" within 5s'),
);
expect(decoded, contains('hello-panes'));
expect(sink.ofKind('pane.output'), isNotEmpty);
});
test('write + resize emit no spurious events, update state', () async {
final pane = await registry.spawn(
kind: PaneKind.terminal,
argv: const ['/bin/cat'],
);
final writeCount = registry.write(pane.id, utf8.encode('abc'));
expect(writeCount, greaterThan(0));
registry.resize(pane.id, cols: 120, rows: 40);
final resized = sink.ofKind('pane.resized').toList();
expect(resized, hasLength(1));
expect(resized.single.data['cols'], 120);
expect(resized.single.data['rows'], 40);
});
test('close is idempotent + emits pane.closed once', () async {
final pane = await registry.spawn(
kind: PaneKind.terminal,
argv: const ['/bin/cat'],
);
await registry.close(pane.id);
await registry.close(pane.id); // second call: no-op
expect(registry.get(pane.id), isNull);
expect(sink.ofKind('pane.closed'), hasLength(1));
});
test('close on unknown id does nothing', () async {
await registry.close('p_nonexistent');
expect(sink.ofKind('pane.closed'), isEmpty);
});
test('claude kind round-trips on the wire', () async {
final pane = await registry.spawn(
kind: PaneKind.claude,
argv: const ['/bin/sh', '-c', 'exit 0'],
);
expect(pane.kind, PaneKind.claude);
expect(pane.toJson()['kind'], 'claude');
});
});
group('RecordingEventSink filters', () {
test('ofSubsystem narrows events to a single subsystem', () {
final s = RecordingEventSink();
final ts = DateTime.now().toUtc();
s.emit(IpcEvent(subsystem: 'pane', kind: 'spawned', timestamp: ts, data: const {}));
s.emit(IpcEvent(subsystem: 'git', kind: 'changed', timestamp: ts, data: const {}));
s.emit(IpcEvent(subsystem: 'pane', kind: 'closed', timestamp: ts, data: const {}));
expect(s.ofSubsystem('pane'), hasLength(2));
expect(s.ofSubsystem('git'), hasLength(1));
expect(s.ofSubsystem('files'), isEmpty);
});
});
}